)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7e72923100e2381642629b5d74a970f85ec3b98e","unresolved":false,"context_lines":[{"line_number":3023,"context_line":"                    instance_type, network_info,"},{"line_number":3024,"context_line":"                    block_device_info)"},{"line_number":3025,"context_line":""},{"line_number":3026,"context_line":"            self.driver.destroy(instance, network_info,"},{"line_number":3027,"context_line":"                                block_device_info)"},{"line_number":3028,"context_line":""},{"line_number":3029,"context_line":"            self._terminate_volume_connections(context, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FPCU%3D","line":3026,"updated":"2013-10-20 08:15:38.000000000","message":"Is this not done with the confirmation of the resize?","commit_id":"bbaceb4b2de3934fe79e1557924040ed77a6dfee"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"067b1fa0c2f6ccebb210675029b4a179d1efc577","unresolved":false,"context_lines":[{"line_number":3023,"context_line":"                    instance_type, network_info,"},{"line_number":3024,"context_line":"                    block_device_info)"},{"line_number":3025,"context_line":""},{"line_number":3026,"context_line":"            self.driver.destroy(instance, network_info,"},{"line_number":3027,"context_line":"                                block_device_info)"},{"line_number":3028,"context_line":""},{"line_number":3029,"context_line":"            self._terminate_volume_connections(context, instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2FPA8%3D","line":3026,"in_reply_to":"AAAATH%2F%2FPCU%3D","updated":"2013-10-20 09:01:21.000000000","message":"Thanks Gary. Seems confirm resize does not handle this part. Also it seems that we cannot handle this part in confirm resize as when confirm resize, the VM was already running with new flavor, and we may not able to get its original disk except parsing the ***_resize/libvirt.xml.\n\nThe current solution seems still not good enough, if resize/migrate on same host and root_gb did not change, then there is no need to destroy the image disk but leave as it is.\n\n(Pdb) instance_type[\u0027root_gb\u0027]\n1\n(Pdb) instance.root_gb\n1\n(Pdb) instance.host\nu\u0027liugya-ubuntu\u0027\n(Pdb) migration.dest_compute\nu\u0027liugya-ubuntu\u0027\n\nFor above case, I think that we do not need to destroy the image disk. Comments? :-)","commit_id":"bbaceb4b2de3934fe79e1557924040ed77a6dfee"}]}