)]}'
{"nova/api/openstack/placement/handlers/resource_provider.py":[{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"ba4b8d3c90f42209eea42febf250b1fc024d2aad","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import webob"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from nova.api.openstack.placement import microversion"},{"line_number":22,"context_line":"from nova.api.openstack.placement.schemas import resource_provider as rp_schema"},{"line_number":23,"context_line":"from nova.api.openstack.placement import util"},{"line_number":24,"context_line":"from nova.api.openstack.placement import wsgi_wrapper"},{"line_number":25,"context_line":"from nova import exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_a4869fb8","line":22,"range":{"start_line":22,"start_character":70,"end_line":22,"end_character":79},"updated":"2017-12-18 17:35:49.000000000","message":"NIT: Why not stay consistent with the other nova.api.openstack.placement.schemas imports[1][2][3][4] and import as \"schema\", rather than \"rp_schema\"?\n\n[1] https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/aggregate.py#L19\n[2] https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/inventory.py#L22\n[3] https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/trait.py#L21\n[4] https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handlers/usage.py#L20","commit_id":"53f34ba0844cdc91118852bcd91789e3dd7016b9"},{"author":{"_account_id":24711,"name":"Jackie Truong","email":"jacklyn.truong@jhuapl.edu","username":"jackie-truong"},"change_message_id":"88686b98c71029dbbdd748c774dfcdf046964f4d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import webob"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from nova.api.openstack.placement import microversion"},{"line_number":22,"context_line":"from nova.api.openstack.placement.schemas import resource_provider as rp_schema"},{"line_number":23,"context_line":"from nova.api.openstack.placement import util"},{"line_number":24,"context_line":"from nova.api.openstack.placement import wsgi_wrapper"},{"line_number":25,"context_line":"from nova import exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_c6f9f64d","line":22,"range":{"start_line":22,"start_character":70,"end_line":22,"end_character":79},"in_reply_to":"df87a7cf_0aa64dac","updated":"2017-12-20 14:45:33.000000000","message":"Fair enough","commit_id":"53f34ba0844cdc91118852bcd91789e3dd7016b9"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"cdadc94992758adb04740f648dcbc5bef50a0fa5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import webob"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from nova.api.openstack.placement import microversion"},{"line_number":22,"context_line":"from nova.api.openstack.placement.schemas import resource_provider as rp_schema"},{"line_number":23,"context_line":"from nova.api.openstack.placement import util"},{"line_number":24,"context_line":"from nova.api.openstack.placement import wsgi_wrapper"},{"line_number":25,"context_line":"from nova import exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_0aa64dac","line":22,"range":{"start_line":22,"start_character":70,"end_line":22,"end_character":79},"in_reply_to":"df87a7cf_a4869fb8","updated":"2017-12-20 02:54:26.000000000","message":"Because there is a local variable \u0027schema\u0027.","commit_id":"53f34ba0844cdc91118852bcd91789e3dd7016b9"}]}