)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1ccc9187f17d31d045ee669176e88facb3c98852","unresolved":false,"context_lines":[{"line_number":842,"context_line":"                        image_meta, [instance])"},{"line_number":843,"context_line":"                    request_spec \u003d objects.RequestSpec.from_primitives("},{"line_number":844,"context_line":"                        context, request_spec, filter_properties)"},{"line_number":845,"context_line":"                elif recreate:"},{"line_number":846,"context_line":"                    # NOTE(sbauza): Augment the RequestSpec object by excluding"},{"line_number":847,"context_line":"                    # the source host for avoiding the scheduler to pick it"},{"line_number":848,"context_line":"                    request_spec.ignore_hosts \u003d request_spec.ignore_hosts or []"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf8cb3f7_867a0e86","line":845,"range":{"start_line":845,"start_character":0,"end_line":845,"end_character":30},"updated":"2017-12-20 14:28:45.000000000","message":"I\u0027m guessing the below should be in this context instead? If we\u0027re building the request_spec from scratch, we should be populating the project_id...right?","commit_id":"f9a06c42535ef7ebba92c793afd947073352f850"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e1de1b8dfff29d9586961635a4f58301caa2fcaa","unresolved":false,"context_lines":[{"line_number":842,"context_line":"                        image_meta, [instance])"},{"line_number":843,"context_line":"                    request_spec \u003d objects.RequestSpec.from_primitives("},{"line_number":844,"context_line":"                        context, request_spec, filter_properties)"},{"line_number":845,"context_line":"                elif recreate:"},{"line_number":846,"context_line":"                    # NOTE(sbauza): Augment the RequestSpec object by excluding"},{"line_number":847,"context_line":"                    # the source host for avoiding the scheduler to pick it"},{"line_number":848,"context_line":"                    request_spec.ignore_hosts \u003d request_spec.ignore_hosts or []"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf8cb3f7_6604aac7","line":845,"range":{"start_line":845,"start_character":0,"end_line":845,"end_character":30},"in_reply_to":"bf8cb3f7_867a0e86","updated":"2017-12-20 14:32:20.000000000","message":"No, we need to make sure the project_id is set on the request_spec whenever we call select_destinations (via _schedule_instances here), so I\u0027m doing it outside the if/elif block so I handle both cases.","commit_id":"f9a06c42535ef7ebba92c793afd947073352f850"}],"nova/conductor/tasks/live_migrate.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1ccc9187f17d31d045ee669176e88facb3c98852","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                self.instance.pci_requests,"},{"line_number":279,"context_line":"                filter_properties, None, self.instance.availability_zone"},{"line_number":280,"context_line":"            )"},{"line_number":281,"context_line":"        else:"},{"line_number":282,"context_line":"            request_spec \u003d self.request_spec"},{"line_number":283,"context_line":"            # NOTE(sbauza): Force_hosts/nodes needs to be reset"},{"line_number":284,"context_line":"            # if we want to make sure that the next destination"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf8cb3f7_a662b2d7","line":281,"range":{"start_line":281,"start_character":8,"end_line":281,"end_character":13},"updated":"2017-12-20 14:28:45.000000000","message":"ditto, though I guess we might also need to pass project_id in to \u0027from_components\u0027 above to be safe?","commit_id":"f9a06c42535ef7ebba92c793afd947073352f850"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e1de1b8dfff29d9586961635a4f58301caa2fcaa","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                self.instance.pci_requests,"},{"line_number":279,"context_line":"                filter_properties, None, self.instance.availability_zone"},{"line_number":280,"context_line":"            )"},{"line_number":281,"context_line":"        else:"},{"line_number":282,"context_line":"            request_spec \u003d self.request_spec"},{"line_number":283,"context_line":"            # NOTE(sbauza): Force_hosts/nodes needs to be reset"},{"line_number":284,"context_line":"            # if we want to make sure that the next destination"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf8cb3f7_662d8a45","line":281,"range":{"start_line":281,"start_character":8,"end_line":281,"end_character":13},"in_reply_to":"bf8cb3f7_a662b2d7","updated":"2017-12-20 14:32:20.000000000","message":"That\u0027s why I\u0027m doing it below, to kill two birds.","commit_id":"f9a06c42535ef7ebba92c793afd947073352f850"}],"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"4e9752fea5985e6c582612cc993dba3900ac847d","unresolved":false,"context_lines":[{"line_number":2260,"context_line":"            availability_zone\u003dNone,"},{"line_number":2261,"context_line":"            pci_requests\u003dNone,"},{"line_number":2262,"context_line":"            numa_topology\u003dNone,"},{"line_number":2263,"context_line":"            project_id\u003dself.context.project_id)"},{"line_number":2264,"context_line":"        image \u003d \u0027fake-image\u0027"},{"line_number":2265,"context_line":"        resvs \u003d \u0027fake-resvs\u0027"},{"line_number":2266,"context_line":"        fake_spec \u003d objects.RequestSpec(image\u003dobjects.ImageMeta())"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_0fa65fac","line":2263,"updated":"2017-12-20 01:48:48.000000000","message":"I\u0027m actually surprised you only had to update such a few number of lines in the test fixtures...","commit_id":"9694b7056d5d964b94bd9d77624713f9a10664ab"}]}