)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"abf1df821d6da65ecdd191de9a8c53127f2ad1cb","unresolved":false,"context_lines":[{"line_number":952,"context_line":"            self.driver.plug_vifs(instance, net_info)"},{"line_number":953,"context_line":"        except NotImplementedError as e:"},{"line_number":954,"context_line":"            LOG.debug(e, instance\u003dinstance)"},{"line_number":955,"context_line":"        except (exception.VirtualInterfacePlugException,"},{"line_number":956,"context_line":"                exception.NovaException) as e:"},{"line_number":957,"context_line":"            # we don\u0027t want an exception to block the init_host"},{"line_number":958,"context_line":"            LOG.exception(\"Vifs plug failed\", instance\u003dinstance)"},{"line_number":959,"context_line":"            compute_utils.add_instance_fault_from_exc(context, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_7acd66b5","line":956,"range":{"start_line":955,"start_character":0,"end_line":956,"end_character":46},"updated":"2017-12-20 08:02:08.000000000","message":"seems true that NovaException will raise in:\nhttps://github.com/openstack/nova/blob/stable/pike/nova/network/os_vif_util.py#L484\n\nBut if we are going to catch it, seems we don\u0027t have to catch exception.VirtualInterfacePlugException, as it is inherent from NovaException.","commit_id":"10462d2fa2be1bd1b384ba870efd12ae5f47a724"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"96ac01a4eefb5b0b55d227e1d62d841cfa617ba9","unresolved":false,"context_lines":[{"line_number":952,"context_line":"            self.driver.plug_vifs(instance, net_info)"},{"line_number":953,"context_line":"        except NotImplementedError as e:"},{"line_number":954,"context_line":"            LOG.debug(e, instance\u003dinstance)"},{"line_number":955,"context_line":"        except (exception.VirtualInterfacePlugException,"},{"line_number":956,"context_line":"                exception.NovaException) as e:"},{"line_number":957,"context_line":"            # we don\u0027t want an exception to block the init_host"},{"line_number":958,"context_line":"            LOG.exception(\"Vifs plug failed\", instance\u003dinstance)"},{"line_number":959,"context_line":"            compute_utils.add_instance_fault_from_exc(context, instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_5ab2e207","line":956,"range":{"start_line":955,"start_character":0,"end_line":956,"end_character":46},"in_reply_to":"df87a7cf_7acd66b5","updated":"2017-12-20 08:15:14.000000000","message":"Agreed. Some test as below:\n\n\u003e\u003e\u003e class TestException(Exception):\n...     pass\n...\n\u003e\u003e\u003e class ChildTestException(TestException):\n...     pass\n...\n\u003e\u003e\u003e try:\n...     raise ChildTestException\n... except TestException:\n...     print \u0027ChildTestException catched\u0027\n...\n\n\u003e ChildTestException catched","commit_id":"10462d2fa2be1bd1b384ba870efd12ae5f47a724"}]}