)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c5fb5e064547e8b696bd9df7a012549d951f3232","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"                    volume \u003d self.volume_api.get(context, volume_id)"},{"line_number":1017,"context_line":"                except exception.CinderConnectionFailed:"},{"line_number":1018,"context_line":"                    raise"},{"line_number":1019,"context_line":"                except Exception as exc:"},{"line_number":1020,"context_line":"                    raise exception.InvalidBDMVolume(id\u003dvolume_id,"},{"line_number":1021,"context_line":"                        reason\u003dexc.format_message())"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"                if not volume.get(\u0027bootable\u0027, True):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_c66ba3b6","line":1020,"range":{"start_line":1019,"start_character":16,"end_line":1020,"end_character":66},"updated":"2019-04-05 21:16:55.000000000","message":"Agree this is a pain and has caused me to do something like this to debug tests before, but Exception is generic and format_message() is only on NovaException, so if something else raised here, like TypeError then this would blow up.","commit_id":"2cf9f236008c10bd3d435f7851bdc34c544235a3"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"75c0e60d8b325af409b17e0b8064fe8913220409","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"                    raise"},{"line_number":1019,"context_line":"                except Exception as exc:"},{"line_number":1020,"context_line":"                    raise exception.InvalidBDMVolume(id\u003dvolume_id,"},{"line_number":1021,"context_line":"                        reason\u003dexc.format_message())"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"                if not volume.get(\u0027bootable\u0027, True):"},{"line_number":1024,"context_line":"                    raise exception.InvalidBDMVolumeNotBootable(id\u003dvolume_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_b83c5693","line":1021,"range":{"start_line":1021,"start_character":24,"end_line":1021,"end_character":51},"updated":"2017-12-20 09:34:24.000000000","message":"guess every Exception has format_message function here\nif we know specified exception will raise from get at line 1016, we need to be specific","commit_id":"2cf9f236008c10bd3d435f7851bdc34c544235a3"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"c1e6766a2d78f202c4910b2c11d7abf0d36106f2","unresolved":false,"context_lines":[{"line_number":1345,"context_line":"                    raise"},{"line_number":1346,"context_line":"                except exception.InvalidInput as exc:"},{"line_number":1347,"context_line":"                    raise exception.InvalidVolume(reason\u003dexc.format_message())"},{"line_number":1348,"context_line":"                except Exception as exc:"},{"line_number":1349,"context_line":"                    raise exception.InvalidBDMVolume(id\u003dvolume_id,"},{"line_number":1350,"context_line":"                        reason\u003dexc.format_message())"},{"line_number":1351,"context_line":"            elif snapshot_id is not None:"},{"line_number":1352,"context_line":"                try:"},{"line_number":1353,"context_line":"                    snap \u003d self.volume_api.get_snapshot(context, snapshot_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_7d6ec000","line":1350,"range":{"start_line":1348,"start_character":0,"end_line":1350,"end_character":52},"updated":"2017-12-20 09:19:47.000000000","message":"It seems that method check_availability_zone() which called by _check_attach() and _check_attach_and_reserve_volume raises exception.InvalidVolume which was handled above in line 1343, so why are the modifications here?\nhttps://github.com/openstack/nova/blob/stable/pike/nova/volume/cinder.py#L352","commit_id":"2cf9f236008c10bd3d435f7851bdc34c544235a3"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"e0afc5062604bcd1137a83238b796458030fb27b","unresolved":false,"context_lines":[{"line_number":1345,"context_line":"                    raise"},{"line_number":1346,"context_line":"                except exception.InvalidInput as exc:"},{"line_number":1347,"context_line":"                    raise exception.InvalidVolume(reason\u003dexc.format_message())"},{"line_number":1348,"context_line":"                except Exception as exc:"},{"line_number":1349,"context_line":"                    raise exception.InvalidBDMVolume(id\u003dvolume_id,"},{"line_number":1350,"context_line":"                        reason\u003dexc.format_message())"},{"line_number":1351,"context_line":"            elif snapshot_id is not None:"},{"line_number":1352,"context_line":"                try:"},{"line_number":1353,"context_line":"                    snap \u003d self.volume_api.get_snapshot(context, snapshot_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_d8727a12","line":1350,"range":{"start_line":1348,"start_character":0,"end_line":1350,"end_character":52},"in_reply_to":"df87a7cf_7d6ec000","updated":"2017-12-20 09:54:45.000000000","message":"I see \"Block Device Mapping is Invalid:\" in bug desciption, I think we need more exec stack info from log.","commit_id":"2cf9f236008c10bd3d435f7851bdc34c544235a3"}]}
