)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e880d69d0b88aeb8eec40fc5499651b466e8d7c4","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* There is some old code comments saying that get_host_states"},{"line_number":12,"context_line":"  returned an iterator or a list, but those are both wrong. We"},{"line_number":13,"context_line":"  haven\u0027t returned an iterator since 4660333d0 in Ocata. We return"},{"line_number":14,"context_line":"  a tuple of HostState objects."},{"line_number":15,"context_line":"* Cleans up some variable usage and alignment."},{"line_number":16,"context_line":"* Removes an unused variable from a test class."},{"line_number":17,"context_line":"* Adds a FIXME note about how we are potentially using the wrong"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf8cb3f7_34080827","line":14,"range":{"start_line":13,"start_character":56,"end_line":14,"end_character":31},"updated":"2017-12-20 15:26:43.000000000","message":"apparently we don\u0027t :) we return a generator expression, not a tuple. I got my learn-on from edleafe and mdbooth in IRC today...","commit_id":"c0c40de906281e7da6168483fd24a53e77d52823"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b2cd67898296c78ca613ea38a555f95ea936a0a5","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* There is some old code comments saying that get_host_states"},{"line_number":12,"context_line":"  returned an iterator or a list, but those are both wrong. We"},{"line_number":13,"context_line":"  haven\u0027t returned an iterator since 4660333d0 in Ocata. We return"},{"line_number":14,"context_line":"  a tuple of HostState objects."},{"line_number":15,"context_line":"* Cleans up some variable usage and alignment."},{"line_number":16,"context_line":"* Removes an unused variable from a test class."},{"line_number":17,"context_line":"* Adds a FIXME note about how we are potentially using the wrong"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf8cb3f7_af76053e","line":14,"range":{"start_line":13,"start_character":56,"end_line":14,"end_character":31},"in_reply_to":"bf8cb3f7_34080827","updated":"2017-12-20 16:20:16.000000000","message":"Yup:\n\nhttp://intermediatepythonista.com/python-generators#generator-expressions_1\n\nNews to me too.","commit_id":"c0c40de906281e7da6168483fd24a53e77d52823"}],"nova/scheduler/utils.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"143a0354c72f7dc2ba306e06996044419b53aeeb","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"        # the allocations for something like counting quota usage because in"},{"line_number":1008,"context_line":"        # the case of migrating or evacuating an instance, the user here is"},{"line_number":1009,"context_line":"        # likely the admin, not the owner of the instance, so the allocation"},{"line_number":1010,"context_line":"        # would be tracked against the wrong user."},{"line_number":1011,"context_line":"        user_id \u003d ctx.user_id"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    # NOTE(gibi): this could raise AllocationUpdateFailed which means there is"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_784d4e3a","line":1010,"updated":"2018-10-26 14:05:38.000000000","message":"Luckily, we don\u0027t see a future with user-specific quotas in them.\n\nThat said, if we\u0027re ever going to be able to use placement for *real* usage queries -- i.e. to get rid of GET /os-simple-tenant-usage -- then placement is going to need to have much more information stored in it, including a consumer type (to indicate the consumer is an instance vs. some non-instance thingies) as well as things like claim_time and release_time for the allocations (otherwise we can\u0027t emulate the behaviour of os-simple-tenant-usage which does the whole crazy \"get my amounts then multiply the usage amounts by a \u0027number of hours of usage\u0027 amount\"...","commit_id":"f14c21f87e4c97161c2d78044e08234731b2f6a2"}]}