)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b007066a70d6348ef9cfca6509a0752a43f98d36","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"This change takes the simplest approach and simply removes the setting"},{"line_number":32,"context_line":"of the \u0027id\u0027 attribute on the allocations in the \u0027allocs\u0027 list. There are"},{"line_number":33,"context_line":"other ways to deal with this, this is the last intrusive. It works"},{"line_number":34,"context_line":"because:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* create_all is only called from the allocation handler in placement,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf8cb3f7_7d83d057","line":33,"range":{"start_line":33,"start_character":42,"end_line":33,"end_character":46},"updated":"2017-12-20 19:08:59.000000000","message":"least","commit_id":"997154b7f6a0f277bb10d090b8ce9ad030596a9d"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b007066a70d6348ef9cfca6509a0752a43f98d36","unresolved":false,"context_lines":[{"line_number":34,"context_line":"because:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* create_all is only called from the allocation handler in placement,"},{"line_number":37,"context_line":"  and the objects are not used (there response body is empty)"},{"line_number":38,"context_line":"* other than the \u0027id\u0027 change, the alloc members in the allocs list"},{"line_number":39,"context_line":"  are otherwise unchanged"},{"line_number":40,"context_line":"* this kind of side-effecty business is dangerous, so let\u0027s not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf8cb3f7_bde5d83a","line":37,"range":{"start_line":37,"start_character":32,"end_line":37,"end_character":37},"updated":"2017-12-20 19:08:59.000000000","message":"the","commit_id":"997154b7f6a0f277bb10d090b8ce9ad030596a9d"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b007066a70d6348ef9cfca6509a0752a43f98d36","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  and the objects are not used (there response body is empty)"},{"line_number":38,"context_line":"* other than the \u0027id\u0027 change, the alloc members in the allocs list"},{"line_number":39,"context_line":"  are otherwise unchanged"},{"line_number":40,"context_line":"* this kind of side-effecty business is dangerous, so let\u0027s not"},{"line_number":41,"context_line":"  rely on it"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Tests which were relying on the side-effecty business have been adjusted"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf8cb3f7_fdc4c094","line":40,"range":{"start_line":40,"start_character":19,"end_line":40,"end_character":20},"updated":"2017-12-20 19:08:59.000000000","message":"And here I thought that you hated hyphens!","commit_id":"997154b7f6a0f277bb10d090b8ce9ad030596a9d"}],"nova/objects/resource_provider.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5ba5a9c0509b509a84374de0971ffcae2e9c2978","unresolved":false,"context_lines":[{"line_number":2083,"context_line":"                    consumer_id\u003dconsumer_id,"},{"line_number":2084,"context_line":"                    used\u003dalloc.used)"},{"line_number":2085,"context_line":"            result \u003d context.session.execute(ins_stmt)"},{"line_number":2086,"context_line":"            alloc.id \u003d result.lastrowid"},{"line_number":2087,"context_line":""},{"line_number":2088,"context_line":"        # Generation checking happens here. If the inventory for this resource"},{"line_number":2089,"context_line":"        # provider changed out from under us, this will raise a"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf8cb3f7_b8bff1ce","side":"PARENT","line":2086,"updated":"2017-12-23 15:13:55.000000000","message":"We should maybe put a note in the docstring for this method that the id won\u0027t be set on the allocation objects and if the caller needs those after this call, they\u0027d need to refresh the list.","commit_id":"609ddc2244bf9ba84d66cced52e7d4e2987ec669"}]}