)]}'
{"nova/tests/unit/virt/libvirt/test_config.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b7d7f7ba6302c52ca8e819987968e49625bf0b17","unresolved":false,"context_lines":[{"line_number":2223,"context_line":"                \u003cboot dev\u003d\"fd\"/\u003e"},{"line_number":2224,"context_line":"                \u003csmbios mode\u003d\"sysinfo\"/\u003e"},{"line_number":2225,"context_line":"              \u003c/os\u003e"},{"line_number":2226,"context_line":"              \u003cfeatures\u003e"},{"line_number":2227,"context_line":"                \u003cacpi/\u003e"},{"line_number":2228,"context_line":"                \u003capic/\u003e"},{"line_number":2229,"context_line":"                \u003cpae/\u003e"},{"line_number":2230,"context_line":"                \u003ckvm\u003e"},{"line_number":2231,"context_line":"                  \u003chidden state\u003d\u0027on\u0027/\u003e"},{"line_number":2232,"context_line":"                \u003c/kvm\u003e"},{"line_number":2233,"context_line":"              \u003c/features\u003e"},{"line_number":2234,"context_line":"              \u003ccputune\u003e"},{"line_number":2235,"context_line":"                \u003cshares\u003e100\u003c/shares\u003e"},{"line_number":2236,"context_line":"                \u003cquota\u003e50000\u003c/quota\u003e"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf8cb3f7_c3d0d2fa","line":2233,"range":{"start_line":2226,"start_character":14,"end_line":2233,"end_character":25},"updated":"2017-12-22 17:28:05.000000000","message":"don\u0027t you need smm in here?","commit_id":"61821479f6568859fca65151d3966243fb21a4c0"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"8f2e36e5a23f78cdf0f7dcf3311a67733a537c2d","unresolved":false,"context_lines":[{"line_number":2223,"context_line":"                \u003cboot dev\u003d\"fd\"/\u003e"},{"line_number":2224,"context_line":"                \u003csmbios mode\u003d\"sysinfo\"/\u003e"},{"line_number":2225,"context_line":"              \u003c/os\u003e"},{"line_number":2226,"context_line":"              \u003cfeatures\u003e"},{"line_number":2227,"context_line":"                \u003cacpi/\u003e"},{"line_number":2228,"context_line":"                \u003capic/\u003e"},{"line_number":2229,"context_line":"                \u003cpae/\u003e"},{"line_number":2230,"context_line":"                \u003ckvm\u003e"},{"line_number":2231,"context_line":"                  \u003chidden state\u003d\u0027on\u0027/\u003e"},{"line_number":2232,"context_line":"                \u003c/kvm\u003e"},{"line_number":2233,"context_line":"              \u003c/features\u003e"},{"line_number":2234,"context_line":"              \u003ccputune\u003e"},{"line_number":2235,"context_line":"                \u003cshares\u003e100\u003c/shares\u003e"},{"line_number":2236,"context_line":"                \u003cquota\u003e50000\u003c/quota\u003e"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf8cb3f7_c3553252","line":2233,"range":{"start_line":2226,"start_character":14,"end_line":2233,"end_character":25},"in_reply_to":"bf8cb3f7_c3d0d2fa","updated":"2017-12-22 17:38:58.000000000","message":"Yep, eagle eyes.  I\u0027ll add it.","commit_id":"61821479f6568859fca65151d3966243fb21a4c0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b7d7f7ba6302c52ca8e819987968e49625bf0b17","unresolved":false,"context_lines":[{"line_number":3351,"context_line":""},{"line_number":3352,"context_line":"        xml \u003d obj.to_xml()"},{"line_number":3353,"context_line":"        self.assertXmlEqual(xml, \"\"\""},{"line_number":3354,"context_line":"            \u003csmm state\u003d\"on\"/\u003e"},{"line_number":3355,"context_line":"        \"\"\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf8cb3f7_e3cdd65d","line":3354,"range":{"start_line":3354,"start_character":12,"end_line":3354,"end_character":29},"updated":"2017-12-22 17:28:05.000000000","message":"Looks like it\u0027s expecting something like this:\n\n\u003csmm\u003e\n  \u003csmm state\u003d\"on\"/\u003e\n\u003c/smm\u003e","commit_id":"61821479f6568859fca65151d3966243fb21a4c0"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"8f2e36e5a23f78cdf0f7dcf3311a67733a537c2d","unresolved":false,"context_lines":[{"line_number":3351,"context_line":""},{"line_number":3352,"context_line":"        xml \u003d obj.to_xml()"},{"line_number":3353,"context_line":"        self.assertXmlEqual(xml, \"\"\""},{"line_number":3354,"context_line":"            \u003csmm state\u003d\"on\"/\u003e"},{"line_number":3355,"context_line":"        \"\"\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf8cb3f7_23617e37","line":3354,"range":{"start_line":3354,"start_character":12,"end_line":3354,"end_character":29},"in_reply_to":"bf8cb3f7_e3cdd65d","updated":"2017-12-22 17:38:58.000000000","message":"That\u0027s wrong; it should be:\n\n \u003cfeatures\u003e\n   ...\n   \u003csmm state\u003d\"on\"/\u003e\n   ...\n \u003c/features\u003e","commit_id":"61821479f6568859fca65151d3966243fb21a4c0"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b7d7f7ba6302c52ca8e819987968e49625bf0b17","unresolved":false,"context_lines":[{"line_number":2052,"context_line":"class LibvirtConfigGuestFeatureSMM(LibvirtConfigGuestFeature):"},{"line_number":2053,"context_line":""},{"line_number":2054,"context_line":"    def __init__(self, **kwargs):"},{"line_number":2055,"context_line":"        super(LibvirtConfigGuestFeatureSMM, self).__init__(\"smm\","},{"line_number":2056,"context_line":"                                                           **kwargs)"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        self.state \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf8cb3f7_43060289","line":2055,"range":{"start_line":2055,"start_character":60,"end_line":2055,"end_character":63},"updated":"2017-12-22 17:28:05.000000000","message":"This defines the parent element, so that\u0027s why the tests expect it to be in something like:\n\n\u003csmm\u003e\n\n\u003c/smm\u003e\n\nIf \"features\" is the parent, then shouldn\u0027t this be \"features\"?","commit_id":"61821479f6568859fca65151d3966243fb21a4c0"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"8f2e36e5a23f78cdf0f7dcf3311a67733a537c2d","unresolved":false,"context_lines":[{"line_number":2052,"context_line":"class LibvirtConfigGuestFeatureSMM(LibvirtConfigGuestFeature):"},{"line_number":2053,"context_line":""},{"line_number":2054,"context_line":"    def __init__(self, **kwargs):"},{"line_number":2055,"context_line":"        super(LibvirtConfigGuestFeatureSMM, self).__init__(\"smm\","},{"line_number":2056,"context_line":"                                                           **kwargs)"},{"line_number":2057,"context_line":""},{"line_number":2058,"context_line":"        self.state \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf8cb3f7_83764a06","line":2055,"range":{"start_line":2055,"start_character":60,"end_line":2055,"end_character":63},"in_reply_to":"bf8cb3f7_43060289","updated":"2017-12-22 17:38:58.000000000","message":"Yes, you\u0027re right, \u0027features\u0027 is indeed the parent.  I\u0027ll fix this.","commit_id":"61821479f6568859fca65151d3966243fb21a4c0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c0ead64ff2682b8ccb2ba7a0f48ef971f0fe903f","unresolved":false,"context_lines":[{"line_number":2060,"context_line":"    def format_dom(self):"},{"line_number":2061,"context_line":"        root \u003d super(LibvirtConfigGuestFeatureSMM, self).format_dom()"},{"line_number":2062,"context_line":""},{"line_number":2063,"context_line":"        root.append(etree.Element(\"smm\", state\u003d\"on\"))"},{"line_number":2064,"context_line":""},{"line_number":2065,"context_line":"        return root"},{"line_number":2066,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf8cb3f7_e3ae362d","line":2063,"range":{"start_line":2063,"start_character":20,"end_line":2063,"end_character":52},"updated":"2017-12-22 17:47:23.000000000","message":"I think the issue is you\u0027re trying to append a sub-element. Isn\u0027t there a way to just add an attribute to the root element?\n\nCan\u0027t you just do:\n\nroot.set(\u0027state\u0027, \u0027on\u0027)\n\n?","commit_id":"61821479f6568859fca65151d3966243fb21a4c0"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"4458d9782aa155923b31d2c63a0ed534382be2c5","unresolved":false,"context_lines":[{"line_number":2060,"context_line":"    def format_dom(self):"},{"line_number":2061,"context_line":"        root \u003d super(LibvirtConfigGuestFeatureSMM, self).format_dom()"},{"line_number":2062,"context_line":""},{"line_number":2063,"context_line":"        root.append(etree.Element(\"smm\", state\u003d\"on\"))"},{"line_number":2064,"context_line":""},{"line_number":2065,"context_line":"        return root"},{"line_number":2066,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf8cb3f7_f57d896e","line":2063,"range":{"start_line":2063,"start_character":20,"end_line":2063,"end_character":52},"in_reply_to":"bf8cb3f7_e3ae362d","updated":"2017-12-22 18:07:47.000000000","message":"What you\u0027re observing is correct. \n\nI haven\u0027t yet tried root.set(\u0027state\u0027, \u0027on\u0027), was first going to try the earlier approach of appending to the \u0027features\u0027 root element.","commit_id":"61821479f6568859fca65151d3966243fb21a4c0"}]}