)]}'
{"nova/tests/unit/virt/test_block_device.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"55cf6053dea8309d21ae87adb52a5461ba7b771a","unresolved":false,"context_lines":[{"line_number":418,"context_line":"            mock.patch.object(self.virt_driver, \u0027get_volume_connector\u0027,"},{"line_number":419,"context_line":"                              return_value\u003dconnector),"},{"line_number":420,"context_line":"            mock.patch.object(self.volume_api, \u0027attachment_delete\u0027),"},{"line_number":421,"context_line":"        ) as (mock_get_volume, mock_get_connector, vapi_attach_del):"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"            driver_bdm.detach(elevated_context, instance,"},{"line_number":424,"context_line":"                              self.volume_api, self.virt_driver,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_0f224801","line":421,"updated":"2018-01-04 02:21:32.000000000","message":"Hm, nothing is verifying that the locked detach happens if shared_targets, as opposed to the unlocked detach. Whether you set shared_targets \u003d True or not, these asserts will act the same.\n\nI found a couple of examples in our unit tests where tests patched \u0027nova.utils.synchronized\u0027 and asserted that it was called with the expected stuff. Can we do that here for the include_shared_targets case?","commit_id":"2b4cfeb506c1544afded443b71cb8f1ef02a7920"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"b91f8addcd0e26981d10a3fe4339947b9e83b985","unresolved":false,"context_lines":[{"line_number":418,"context_line":"            mock.patch.object(self.virt_driver, \u0027get_volume_connector\u0027,"},{"line_number":419,"context_line":"                              return_value\u003dconnector),"},{"line_number":420,"context_line":"            mock.patch.object(self.volume_api, \u0027attachment_delete\u0027),"},{"line_number":421,"context_line":"        ) as (mock_get_volume, mock_get_connector, vapi_attach_del):"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"            driver_bdm.detach(elevated_context, instance,"},{"line_number":424,"context_line":"                              self.volume_api, self.virt_driver,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_5dd2415e","line":421,"in_reply_to":"9f91af0f_0f224801","updated":"2018-01-04 09:56:53.000000000","message":"Done","commit_id":"2b4cfeb506c1544afded443b71cb8f1ef02a7920"}]}