)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f0a883048266142d88df8c87808f692120c55806","unresolved":false,"context_lines":[{"line_number":4218,"context_line":"                guest_numa_tune \u003d vconfig.LibvirtConfigGuestNUMATune()"},{"line_number":4219,"context_line":"                guest_numa_tune.memory \u003d ("},{"line_number":4220,"context_line":"                    vconfig.LibvirtConfigGuestNUMATuneMemory())"},{"line_number":4221,"context_line":"                guest_numa_tune.memnodes \u003d ("},{"line_number":4222,"context_line":"                    [vconfig.LibvirtConfigGuestNUMATuneMemNode()"},{"line_number":4223,"context_line":"                        for _ in guest_cpu_numa_config.cells])"},{"line_number":4224,"context_line":""},{"line_number":4225,"context_line":"                emulator_threads_isolated \u003d ("},{"line_number":4226,"context_line":"                    instance_numa_topology.emulator_threads_isolated)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f93b717_dd9842c1","line":4223,"range":{"start_line":4221,"start_character":0,"end_line":4223,"end_character":62},"updated":"2018-01-31 08:48:20.000000000","message":"instead of creating LibvirtConfigGuestNUMATuneMemNode object here too, can we define guest_numa_tune.memnodes as empty list which going to be populated @L4243","commit_id":"0ac52958ebe5d030d0b36d5459cacbeef727d466"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"1191d0501fee84b3d56b22223c1f6a072d7350f0","unresolved":false,"context_lines":[{"line_number":4218,"context_line":"                guest_numa_tune \u003d vconfig.LibvirtConfigGuestNUMATune()"},{"line_number":4219,"context_line":"                guest_numa_tune.memory \u003d ("},{"line_number":4220,"context_line":"                    vconfig.LibvirtConfigGuestNUMATuneMemory())"},{"line_number":4221,"context_line":"                guest_numa_tune.memnodes \u003d ("},{"line_number":4222,"context_line":"                    [vconfig.LibvirtConfigGuestNUMATuneMemNode()"},{"line_number":4223,"context_line":"                        for _ in guest_cpu_numa_config.cells])"},{"line_number":4224,"context_line":""},{"line_number":4225,"context_line":"                emulator_threads_isolated \u003d ("},{"line_number":4226,"context_line":"                    instance_numa_topology.emulator_threads_isolated)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f93b717_42f3cb74","line":4223,"range":{"start_line":4221,"start_character":0,"end_line":4223,"end_character":62},"in_reply_to":"5f93b717_dd9842c1","updated":"2018-02-01 10:14:33.000000000","message":"Great idea. Done.","commit_id":"0ac52958ebe5d030d0b36d5459cacbeef727d466"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"03342dc73cd1aaf73c7d9dc6c3d308d6c89729da","unresolved":false,"context_lines":[{"line_number":4232,"context_line":""},{"line_number":4233,"context_line":"                # TODO(sahid): Defining domain topology should be"},{"line_number":4234,"context_line":"                # refactored."},{"line_number":4235,"context_line":"                for guest_node_id, guest_config_cell in enumerate("},{"line_number":4236,"context_line":"                        guest_cpu_numa_config.cells):"},{"line_number":4237,"context_line":"                    for host_cell in topology.cells:"},{"line_number":4238,"context_line":"                        if guest_config_cell.id \u003d\u003d host_cell.id:"},{"line_number":4239,"context_line":"                            guest_numa_tune.memnodes.append("},{"line_number":4240,"context_line":"                                self._get_numa_memnode(guest_node_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_e3b5e8ce","line":4237,"range":{"start_line":4235,"start_character":0,"end_line":4237,"end_character":52},"updated":"2018-02-15 15:08:30.000000000","message":"Is it necessary to change the order of this? I\u0027m trying to fathom why it would be. We\u0027d never have more than N iterations of this, where N \u003d\u003d number of guest nodes \u003d\u003d number of host nodes (they should be identical at this point, I think)","commit_id":"23d21a20a26df12c26537d2a57921a4a589dd515"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"a131ac0e88be9189fbb25e74e8dd3614f200b909","unresolved":false,"context_lines":[{"line_number":4232,"context_line":""},{"line_number":4233,"context_line":"                # TODO(sahid): Defining domain topology should be"},{"line_number":4234,"context_line":"                # refactored."},{"line_number":4235,"context_line":"                for guest_node_id, guest_config_cell in enumerate("},{"line_number":4236,"context_line":"                        guest_cpu_numa_config.cells):"},{"line_number":4237,"context_line":"                    for host_cell in topology.cells:"},{"line_number":4238,"context_line":"                        if guest_config_cell.id \u003d\u003d host_cell.id:"},{"line_number":4239,"context_line":"                            guest_numa_tune.memnodes.append("},{"line_number":4240,"context_line":"                                self._get_numa_memnode(guest_node_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_bb55b51f","line":4237,"range":{"start_line":4235,"start_character":0,"end_line":4237,"end_character":52},"in_reply_to":"3fa0c359_e3b5e8ce","updated":"2018-02-16 09:55:47.000000000","message":"Not necessary. I just wanted guest_numa_tune.memnodes to be in order of not host node ids but guest node ids.\n\nI just prefered in xml files\n\n      \u003cmemnode cellid\u003d\"0\" mode\u003d\"strict\" nodeset\u003d\"1\"/\u003e\n      \u003cmemnode cellid\u003d\"1\" mode\u003d\"strict\" nodeset\u003d\"0\"/\u003e\n      \u003cmemnode cellid\u003d\"2\" mode\u003d\"strict\" nodeset\u003d\"2\"/\u003e\n\nthan \n\n      \u003cmemnode cellid\u003d\"1\" mode\u003d\"strict\" nodeset\u003d\"0\"/\u003e\n      \u003cmemnode cellid\u003d\"0\" mode\u003d\"strict\" nodeset\u003d\"1\"/\u003e\n      \u003cmemnode cellid\u003d\"2\" mode\u003d\"strict\" nodeset\u003d\"2\"/\u003e","commit_id":"23d21a20a26df12c26537d2a57921a4a589dd515"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"03342dc73cd1aaf73c7d9dc6c3d308d6c89729da","unresolved":false,"context_lines":[{"line_number":4235,"context_line":"                for guest_node_id, guest_config_cell in enumerate("},{"line_number":4236,"context_line":"                        guest_cpu_numa_config.cells):"},{"line_number":4237,"context_line":"                    for host_cell in topology.cells:"},{"line_number":4238,"context_line":"                        if guest_config_cell.id \u003d\u003d host_cell.id:"},{"line_number":4239,"context_line":"                            guest_numa_tune.memnodes.append("},{"line_number":4240,"context_line":"                                self._get_numa_memnode(guest_node_id,"},{"line_number":4241,"context_line":"                                                       host_cell.id))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_c3feac6a","line":4238,"range":{"start_line":4238,"start_character":0,"end_line":4238,"end_character":64},"updated":"2018-02-15 15:08:30.000000000","message":"unrelated to this, but we could clean this up further by either changing this to:\n\n    if guest_config_cell.id !\u003d host_cell.id:\n        continue\n\nor replacing it with some kind of zip where the two are identical","commit_id":"23d21a20a26df12c26537d2a57921a4a589dd515"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"a131ac0e88be9189fbb25e74e8dd3614f200b909","unresolved":false,"context_lines":[{"line_number":4235,"context_line":"                for guest_node_id, guest_config_cell in enumerate("},{"line_number":4236,"context_line":"                        guest_cpu_numa_config.cells):"},{"line_number":4237,"context_line":"                    for host_cell in topology.cells:"},{"line_number":4238,"context_line":"                        if guest_config_cell.id \u003d\u003d host_cell.id:"},{"line_number":4239,"context_line":"                            guest_numa_tune.memnodes.append("},{"line_number":4240,"context_line":"                                self._get_numa_memnode(guest_node_id,"},{"line_number":4241,"context_line":"                                                       host_cell.id))"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_6651d40e","line":4238,"range":{"start_line":4238,"start_character":0,"end_line":4238,"end_character":64},"in_reply_to":"3fa0c359_c3feac6a","updated":"2018-02-16 09:55:47.000000000","message":"I took the \"some kind of zip\" option since that saves one more indent and I guess that is more kindful to readers.","commit_id":"23d21a20a26df12c26537d2a57921a4a589dd515"}]}