)]}'
{"id":"openstack%2Fnova~52991","triplet_id":"openstack%2Fnova~stable%2Fgrizzly~I6295a782df328a759e358fb82b76dd3f7bd4b39e","project":"openstack/nova","branch":"stable/grizzly","topic":"bug/1073306","hashtags":[],"change_id":"I6295a782df328a759e358fb82b76dd3f7bd4b39e","subject":"xenapi: apply firewall rules in finish_migrate","status":"MERGED","created":"2013-10-21 18:40:25.000000000","updated":"2013-10-31 09:25:32.000000000","submitted":"2013-10-31 09:25:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e6a85aa106c8de9bd2ff2717eb84f67890970142","_number":52991,"virtual_id_number":52991,"owner":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":2,"date":"2013-10-31 09:25:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"recommended":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"all":[{"value":1,"date":"2013-10-29 22:10:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-10-30 16:11:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},{"value":2,"date":"2013-10-31 08:17:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"date":"2013-10-30 09:04:08.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":1,"date":"2013-10-30 07:52:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},{"value":1,"date":"2013-10-31 08:17:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"date":"2013-10-30 09:04:08.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-29 22:10:02.000000000","updated_by":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"reviewer":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"state":"REVIEWER"},{"updated":"2013-10-30 07:52:21.000000000","updated_by":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"reviewer":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"state":"REVIEWER"},{"updated":"2013-10-30 09:04:08.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2013-10-30 16:11:34.000000000","updated_by":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"reviewer":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"state":"REVIEWER"},{"updated":"2013-10-31 08:17:10.000000000","updated_by":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"reviewer":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"state":"REVIEWER"},{"updated":"2013-10-31 09:25:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"07898316b102b84fce097da641269a09a1fd4d3c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-21 19:19:21.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/91/52991/1/check/gate-nova-pep8/caac0f1 : SUCCESS in 3m 28s\n- gate-nova-docs http://docs-draft.openstack.org/91/52991/1/check/gate-nova-docs/2ac60d2/doc/build/html/ : SUCCESS in 10m 53s\n- gate-nova-python26 http://logs.openstack.org/91/52991/1/check/gate-nova-python26/d3a8f38 : SUCCESS in 11m 35s\n- gate-nova-python27 http://logs.openstack.org/91/52991/1/check/gate-nova-python27/97dc2eb : SUCCESS in 9m 54s\n- check-tempest-devstack-vm-full http://logs.openstack.org/91/52991/1/check/check-tempest-devstack-vm-full/294c4ff : SUCCESS in 38m 07s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/91/52991/1/check/check-tempest-devstack-vm-postgres-full/415dab0 : SUCCESS in 36m 05s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/91/52991/1/check/check-tempest-devstack-vm-neutron/c15c544 : SUCCESS in 20m 08s\n- gate-devstack-vm-cells http://logs.openstack.org/91/52991/1/check/gate-devstack-vm-cells/a535bfe : SUCCESS in 10m 17s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/91/52991/1/check/gate-nova-pylint/f3c2608 : SUCCESS in 9m 02s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"6c153dc2e4650834069b1d804b7f973960446d11","author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"date":"2013-10-21 21:22:46.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"8b47cf7bbd148289a5b0d870ec7e59f89a2df707","author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"date":"2013-10-29 17:32:59.000000000","message":"Patch Set 1: Rebased","accounts_in_message":[],"_revision_number":1},{"id":"bf175ed2acccbcd13b7a9a34a243248aa030ab9d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-29 18:14:18.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/91/52991/2/check/gate-nova-pep8/df34cc5 : SUCCESS in 3m 32s\n- gate-nova-docs http://docs-draft.openstack.org/91/52991/2/check/gate-nova-docs/5d083be/doc/build/html/ : SUCCESS in 10m 14s\n- gate-nova-python26 http://logs.openstack.org/91/52991/2/check/gate-nova-python26/6545f14 : SUCCESS in 11m 27s\n- gate-nova-python27 http://logs.openstack.org/91/52991/2/check/gate-nova-python27/70262d7 : SUCCESS in 8m 25s\n- check-tempest-devstack-vm-full http://logs.openstack.org/91/52991/2/check/check-tempest-devstack-vm-full/bc65c3f : SUCCESS in 36m 03s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/91/52991/2/check/check-tempest-devstack-vm-postgres-full/4cd11fe : SUCCESS in 40m 57s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/91/52991/2/check/check-tempest-devstack-vm-neutron/0fd2ac4 : SUCCESS in 19m 53s\n- gate-devstack-vm-cells http://logs.openstack.org/91/52991/2/check/gate-devstack-vm-cells/66b6f17 : SUCCESS in 9m 24s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/91/52991/2/check/gate-nova-pylint/3b4a3a0 : SUCCESS in 8m 41s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"6edcc1a843e33b3b17fd36f961191ca053f0ce9b","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2013-10-29 22:10:02.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"108dc9ae0f118e2f65751de33bffc1a7372ac1ef","author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"date":"2013-10-30 07:52:21.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"cc9d4cbd2f7c6c18b0871b71c9c8ca4f2416b1c4","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-10-30 09:04:08.000000000","message":"Patch Set 2:\n\nCan you please add the commit ID in from the original change set (https://wiki.openstack.org/wiki/StableBranch#Workflow)\nThanks\nGary","accounts_in_message":[],"_revision_number":2},{"id":"a6f636bd50825a810d392e2737faf4f97d5c369c","author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"date":"2013-10-30 16:11:34.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"56b8dc2ee65decf2b6c9c6817d1a3b70b83e5ee7","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2013-10-31 08:17:10.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nSecurity fix","accounts_in_message":[],"_revision_number":2},{"id":"75cd167bfd2f34114d371144fb73495e8ea58277","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-31 08:17:20.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"7fed653db47340450ef21a44d591205f5371d4b4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-31 09:25:29.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-nova-docs http://docs-draft.openstack.org/91/52991/2/gate/gate-nova-docs/97e36fc/doc/build/html/ : SUCCESS in 9m 32s\n- gate-nova-pep8 http://logs.openstack.org/91/52991/2/gate/gate-nova-pep8/0f6fa7c : SUCCESS in 4m 53s\n- gate-nova-python26 http://logs.openstack.org/91/52991/2/gate/gate-nova-python26/f71c801 : SUCCESS in 11m 43s\n- gate-nova-python27 http://logs.openstack.org/91/52991/2/gate/gate-nova-python27/44eb308 : SUCCESS in 10m 35s\n- gate-tempest-devstack-vm-full http://logs.openstack.org/91/52991/2/gate/gate-tempest-devstack-vm-full/25953e4 : SUCCESS in 32m 11s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/91/52991/2/gate/gate-tempest-devstack-vm-postgres-full/704ceff : SUCCESS in 37m 27s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/91/52991/2/gate/gate-tempest-devstack-vm-neutron/36d32a8 : SUCCESS in 15m 10s\n","accounts_in_message":[],"_revision_number":2},{"id":"64b9856e84c316470b96be22713cb4903c8e248c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-31 09:25:32.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"01de658210fd65171bfbf5450c93673b5ce0bd9e","revisions":{"24005bbae3b3f08046997ec22c3732205d84e8ef":{"kind":"REWORK","_number":1,"created":"2013-10-21 18:40:25.000000000","uploader":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"ref":"refs/changes/91/52991/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/91/52991/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/91/52991/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/91/52991/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/91/52991/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/91/52991/1"}}},"commit":{"parents":[{"commit":"24937fe5c19ed75b15d7ccb982488dc068a10457","subject":"Bump stable/grizzly next version to 2013.1.5","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/24937fe5c19ed75b15d7ccb982488dc068a10457"}]}],"author":{"name":"John Garbutt","email":"john.garbutt@rackspace.com","date":"2013-10-21 18:34:43.000000000","tz":60},"committer":{"name":"John Garbutt","email":"john.garbutt@rackspace.com","date":"2013-10-21 18:34:43.000000000","tz":60},"subject":"xenapi: apply firewall rules in finish_migrate","message":"xenapi: apply firewall rules in finish_migrate\n\nWhen security groups were added, the rules were not re-applied to\nservers that have been migrated to a new hypervisor.\n\nThis change ensures the firewall rules are applied as part of creating\nthe new VM in finish_migrate. This code follows a very similar pattern\nto the code in spawn, and that is where the cut and paste code comes\nfrom. This code duplication was removed in Havana.\n\nFixes bug 1073306\n\nChange-Id: I6295a782df328a759e358fb82b76dd3f7bd4b39e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/24005bbae3b3f08046997ec22c3732205d84e8ef"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/24005bbae3b3f08046997ec22c3732205d84e8ef"}]},"branch":"refs/heads/stable/grizzly"},"01de658210fd65171bfbf5450c93673b5ce0bd9e":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2013-10-21 18:40:25.000000000","uploader":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"ref":"refs/changes/91/52991/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/91/52991/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/91/52991/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/91/52991/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/91/52991/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/91/52991/2"}}},"commit":{"parents":[{"commit":"f56a0412eae0708d9c71152c21ea5f1f6194f355","subject":"Merge \"Fixes KeyError bug with network api associate\" into stable/grizzly","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f56a0412eae0708d9c71152c21ea5f1f6194f355"}]}],"author":{"name":"John Garbutt","email":"john.garbutt@rackspace.com","date":"2013-10-21 18:34:43.000000000","tz":60},"committer":{"name":"Gerrit Code Review","email":"review@openstack.org","date":"2013-10-29 17:32:58.000000000","tz":0},"subject":"xenapi: apply firewall rules in finish_migrate","message":"xenapi: apply firewall rules in finish_migrate\n\nWhen security groups were added, the rules were not re-applied to\nservers that have been migrated to a new hypervisor.\n\nThis change ensures the firewall rules are applied as part of creating\nthe new VM in finish_migrate. This code follows a very similar pattern\nto the code in spawn, and that is where the cut and paste code comes\nfrom. This code duplication was removed in Havana.\n\nFixes bug 1073306\n\nChange-Id: I6295a782df328a759e358fb82b76dd3f7bd4b39e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/01de658210fd65171bfbf5450c93673b5ce0bd9e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/01de658210fd65171bfbf5450c93673b5ce0bd9e"}]},"branch":"refs/heads/stable/grizzly"}},"requirements":[],"submit_records":[],"submit_requirements":[]}