)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"11d07deaaacf76ad8e4fe548c721a55e90000ff1","unresolved":false,"context_lines":[{"line_number":6851,"context_line":"                # skip fast on future calls rather than waste effort getting"},{"line_number":6852,"context_line":"                # the list of instances."},{"line_number":6853,"context_line":"                LOG.info(\"Bandwidth usage not supported by %(driver)s.\","},{"line_number":6854,"context_line":"                        {\u0027driver\u0027: CONF.compute_driver})"},{"line_number":6855,"context_line":"                self._bw_usage_supported \u003d False"},{"line_number":6856,"context_line":"                return"},{"line_number":6857,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_271bd91b","line":6854,"range":{"start_line":6854,"start_character":16,"end_line":6854,"end_character":25},"updated":"2018-01-02 14:22:51.000000000","message":"nit: Can you either align under quote or indent by only four space","commit_id":"b404e203913b363a1c13270256c132cb79ed384a"},{"author":{"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},"change_message_id":"a633ef65212d6dd5da4e43fa19984dd8c11c9800","unresolved":false,"context_lines":[{"line_number":6851,"context_line":"                # skip fast on future calls rather than waste effort getting"},{"line_number":6852,"context_line":"                # the list of instances."},{"line_number":6853,"context_line":"                LOG.info(\"Bandwidth usage not supported by %(driver)s.\","},{"line_number":6854,"context_line":"                        {\u0027driver\u0027: CONF.compute_driver})"},{"line_number":6855,"context_line":"                self._bw_usage_supported \u003d False"},{"line_number":6856,"context_line":"                return"},{"line_number":6857,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_7acdf45b","line":6854,"range":{"start_line":6854,"start_character":16,"end_line":6854,"end_character":25},"in_reply_to":"9f91af0f_271bd91b","updated":"2018-01-02 15:18:32.000000000","message":"Done","commit_id":"b404e203913b363a1c13270256c132cb79ed384a"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"47545cd78bb922697c316c950a51733d7d264074","unresolved":false,"context_lines":[{"line_number":753,"context_line":"        # then LOG.info something below:"},{"line_number":754,"context_line":"        self.compute._poll_bandwidth_usage(ctxt)"},{"line_number":755,"context_line":"        self.assertIn(\u0027Bandwidth usage not supported by\u0027,"},{"line_number":756,"context_line":"                log.logger.output)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        # A second call won\u0027t call the stubs again as the bandwidth"},{"line_number":759,"context_line":"        # poll is now disabled"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_0ad6c8c6","line":756,"updated":"2018-01-03 11:16:38.000000000","message":"This doesn\u0027t actually test the change, it\u0027s only confirming that the log message was the same as it was before. In order to actually be testing your change, you need to verify that the driver name is in the log message.","commit_id":"c66e85008c5770918c1d5c347d2deea5b45c9bbf"},{"author":{"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},"change_message_id":"4345e9d727631a96697853306325c351f6cc08bd","unresolved":false,"context_lines":[{"line_number":753,"context_line":"        # then LOG.info something below:"},{"line_number":754,"context_line":"        self.compute._poll_bandwidth_usage(ctxt)"},{"line_number":755,"context_line":"        self.assertIn(\u0027Bandwidth usage not supported by\u0027,"},{"line_number":756,"context_line":"                log.logger.output)"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        # A second call won\u0027t call the stubs again as the bandwidth"},{"line_number":759,"context_line":"        # poll is now disabled"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_80d719ee","line":756,"in_reply_to":"9f91af0f_0ad6c8c6","updated":"2018-01-03 13:24:00.000000000","message":"Done","commit_id":"c66e85008c5770918c1d5c347d2deea5b45c9bbf"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e1312f1c20d9c36671d23935f6a5a99f89cd5170","unresolved":false,"context_lines":[{"line_number":754,"context_line":"        self.compute._poll_bandwidth_usage(ctxt)"},{"line_number":755,"context_line":"        self.assertIn(\u0027Bandwidth usage not supported \u0027"},{"line_number":756,"context_line":"                      \u0027by %s\u0027 % CONF.compute_driver,"},{"line_number":757,"context_line":"                      log.logger.output)"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        # A second call won\u0027t call the stubs again as the bandwidth"},{"line_number":760,"context_line":"        # poll is now disabled"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_da5429cd","line":757,"range":{"start_line":757,"start_character":22,"end_line":757,"end_character":39},"updated":"2018-01-03 15:02:26.000000000","message":"I think you can just check \u0027self.output\u0027 now [1]\n\n[1] https://github.com/openstack/nova/commit/d0ef6fd4","commit_id":"217a1344a3afa6f06ea4f37ec8f6c4c8c4a0a3cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"959606ee9c443c8f79fb1f8743d35cc158a15aed","unresolved":false,"context_lines":[{"line_number":754,"context_line":"        self.compute._poll_bandwidth_usage(ctxt)"},{"line_number":755,"context_line":"        self.assertIn(\u0027Bandwidth usage not supported \u0027"},{"line_number":756,"context_line":"                      \u0027by %s\u0027 % CONF.compute_driver,"},{"line_number":757,"context_line":"                      log.logger.output)"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        # A second call won\u0027t call the stubs again as the bandwidth"},{"line_number":760,"context_line":"        # poll is now disabled"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_7dbb9771","line":757,"range":{"start_line":757,"start_character":22,"end_line":757,"end_character":39},"in_reply_to":"9f91af0f_9ac78113","updated":"2018-01-03 16:06:57.000000000","message":"Ah, stdlog indeed","commit_id":"217a1344a3afa6f06ea4f37ec8f6c4c8c4a0a3cc"},{"author":{"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},"change_message_id":"a503dbb9e897cc2c14569a1f648817cf653cac94","unresolved":false,"context_lines":[{"line_number":754,"context_line":"        self.compute._poll_bandwidth_usage(ctxt)"},{"line_number":755,"context_line":"        self.assertIn(\u0027Bandwidth usage not supported \u0027"},{"line_number":756,"context_line":"                      \u0027by %s\u0027 % CONF.compute_driver,"},{"line_number":757,"context_line":"                      log.logger.output)"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        # A second call won\u0027t call the stubs again as the bandwidth"},{"line_number":760,"context_line":"        # poll is now disabled"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_9ac78113","line":757,"range":{"start_line":757,"start_character":22,"end_line":757,"end_character":39},"in_reply_to":"9f91af0f_da5429cd","updated":"2018-01-03 15:34:08.000000000","message":"Thanks for your hints.\nAs we\u0027ll check output of LOG.info, we should use self.stdlog.","commit_id":"217a1344a3afa6f06ea4f37ec8f6c4c8c4a0a3cc"}]}