)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b36b983d5014dbc902692e9eb8629e4523122c38","unresolved":false,"context_lines":[{"line_number":164,"context_line":"libvirt_volume_drivers \u003d ["},{"line_number":165,"context_line":"    \u0027iscsi\u003dnova.virt.libvirt.volume.iscsi.LibvirtISCSIVolumeDriver\u0027,"},{"line_number":166,"context_line":"    \u0027iser\u003dnova.virt.libvirt.volume.iser.LibvirtISERVolumeDriver\u0027,"},{"line_number":167,"context_line":"    \u0027local\u003dnova.virt.libvirt.volume.volume.LibvirtBaseVolumeDriver\u0027,"},{"line_number":168,"context_line":"    \u0027drbd\u003dnova.virt.libvirt.volume.drbd.LibvirtDRBDVolumeDriver\u0027,"},{"line_number":169,"context_line":"    \u0027fake\u003dnova.virt.libvirt.volume.volume.LibvirtFakeVolumeDriver\u0027,"},{"line_number":170,"context_line":"    \u0027rbd\u003dnova.virt.libvirt.volume.net.LibvirtNetVolumeDriver\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_b4da9014","line":167,"range":{"start_line":167,"start_character":43,"end_line":167,"end_character":66},"updated":"2018-05-08 13:59:16.000000000","message":"It seems odd to be using a \"base\" for something other than a superclass. Could we set an alias for this in the module. Something like so:\n\n  LibvirtLocalVolumeDriver \u003d LibvirtBaseVolumeDriver","commit_id":"30e19280098fc081842e4f21c6e508711ce9e22f"}],"nova/virt/libvirt/volume/disco.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b36b983d5014dbc902692e9eb8629e4523122c38","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            device_scan_attempts\u003dCONF.libvirt.num_volume_scan_tries)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def get_host_type(self):"},{"line_number":43,"context_line":"        return \"file\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def get_config(self, connection_info, disk_info):"},{"line_number":46,"context_line":"        \"\"\"Get DISCO volume attachment configuration.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_54877c10","line":43,"range":{"start_line":43,"start_character":15,"end_line":43,"end_character":21},"updated":"2018-05-08 13:59:16.000000000","message":"nit: \u0027file\u0027","commit_id":"30e19280098fc081842e4f21c6e508711ce9e22f"}],"nova/virt/libvirt/volume/volume.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b36b983d5014dbc902692e9eb8629e4523122c38","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def __init__(self, host):"},{"line_number":35,"context_line":"        self.host \u003d host"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get_host_type(self):"},{"line_number":38,"context_line":"        \"\"\"The libvirt type of the volume\u0027s source, as exposed to the libvirt"},{"line_number":39,"context_line":"        domain. This is currently one of:"},{"line_number":40,"context_line":"           * block - a block device on the host"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_54b53ccc","line":37,"range":{"start_line":37,"start_character":8,"end_line":37,"end_character":21},"updated":"2018-05-08 13:59:16.000000000","message":"style nit: /me wonders if this would make more sense as a simple attribute?\n\n   #: The libvirt type of the volume\u0027s...\n   #: ...\n   host_type \u003d \u0027block\u0027","commit_id":"30e19280098fc081842e4f21c6e508711ce9e22f"}]}