)]}'
{"nova/conf/network.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"2ba479063a88fc953614762ab5e1c377bdeba143","unresolved":false,"context_lines":[{"line_number":1399,"context_line":""},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"service_opts \u003d ["},{"line_number":1402,"context_line":"    cfg.StrOpt(\u0027network_manager\u0027,"},{"line_number":1403,"context_line":"        choices\u003d["},{"line_number":1404,"context_line":"            \u0027nova.network.manager.FlatManager\u0027,"},{"line_number":1405,"context_line":"            \u0027nova.network.manager.FlatDHCPManager\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_09cc835f","line":1402,"range":{"start_line":1402,"start_character":15,"end_line":1402,"end_character":32},"updated":"2018-01-04 06:39:41.000000000","message":"It should be marked as \u0027deprecated\u0027 like other nova-network options, shouldn\u0027t it?","commit_id":"224999979aec657fbfabb7fd848ee3a6615b55c6"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"42faccfd3a9651a894e383f6c1554cbe73f928da","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"            \u0027nova.network.manager.FlatDHCPManager\u0027,"},{"line_number":1406,"context_line":"            \u0027nova.network.manager.VlanManager\u0027,"},{"line_number":1407,"context_line":"        ],"},{"line_number":1408,"context_line":"        default\u003d\u0027nova.network.manager.VlanManager\u0027,"},{"line_number":1409,"context_line":"        deprecated_since\u003d\u002718.0.0\u0027,"},{"line_number":1410,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":1411,"context_line":"nova-network is deprecated, as are any related configuration options."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_cb03ec75","line":1408,"updated":"2018-06-19 07:00:08.000000000","message":"nit: deprecated_for_removal\u003dTrue?","commit_id":"38981d3f3959f1bcca741812247b10682c4989c2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8fb08618b16e5a78307771c70d43c837eb21b82e","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"            \u0027nova.network.manager.FlatDHCPManager\u0027,"},{"line_number":1406,"context_line":"            \u0027nova.network.manager.VlanManager\u0027,"},{"line_number":1407,"context_line":"        ],"},{"line_number":1408,"context_line":"        default\u003d\u0027nova.network.manager.VlanManager\u0027,"},{"line_number":1409,"context_line":"        deprecated_since\u003d\u002718.0.0\u0027,"},{"line_number":1410,"context_line":"        deprecated_reason\u003d\"\"\""},{"line_number":1411,"context_line":"nova-network is deprecated, as are any related configuration options."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_fe01713a","line":1408,"in_reply_to":"5f7c97a3_cb03ec75","updated":"2018-06-22 14:05:43.000000000","message":"Oh, indeed. Good catch","commit_id":"38981d3f3959f1bcca741812247b10682c4989c2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4689bafdd14c413706a5d02854461080c0e189bc","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"nova-network is deprecated, as are any related configuration options."},{"line_number":1413,"context_line":"\"\"\","},{"line_number":1414,"context_line":"        help\u003d\u0027Full class name for the Manager for network\u0027),"},{"line_number":1415,"context_line":"]"},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"ALL_DEFAULT_OPTS \u003d (linux_net_opts + network_opts + ldap_dns_opts"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_30478c7a","line":1415,"updated":"2018-06-29 08:26:24.000000000","message":"After searching related code in Nova, I saw the following code:\n\nnova/cmd/manage.py\n 311         if \"NeutronManager\" in CONF.network_manager:\n 312             if uuid is None:\n 313                 raise Exception(_(\"UUID is required to delete \"\n 314                                   \"Neutron Networks\"))\n 315             if fixed_range:\n 316                 raise Exception(_(\"Deleting by fixed_range is not supported \"\n 317                                 \"with the NeutronManager\"))\n\nI felt the network_manager option can be related to Neutron as \"NeutronManager\", but the value should not appear based on the above choices. If that is right, the above code of manage.py also needs to be removed with different patch.","commit_id":"44181a5a20abd984e9aad976dad533e03f44cb10"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e0631918a52d3a416b713782042ee1600c56cfba","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"nova-network is deprecated, as are any related configuration options."},{"line_number":1413,"context_line":"\"\"\","},{"line_number":1414,"context_line":"        help\u003d\u0027Full class name for the Manager for network\u0027),"},{"line_number":1415,"context_line":"]"},{"line_number":1416,"context_line":""},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"ALL_DEFAULT_OPTS \u003d (linux_net_opts + network_opts + ldap_dns_opts"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_617a14f1","line":1415,"in_reply_to":"5f7c97a3_30478c7a","updated":"2018-06-29 10:50:34.000000000","message":"Good spot. See https://review.openstack.org/579118","commit_id":"44181a5a20abd984e9aad976dad533e03f44cb10"}]}