)]}'
{"nova/db/sqlalchemy/migrate_repo/versions/376_add_migrations_updated_at_index.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0e9b63f5500812922d8c40a4f5cde9059f16ab4b","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"INDEX_COLUMNS \u003d [\u0027updated_at\u0027]"},{"line_number":22,"context_line":"INDEX_NAME \u003d \u0027migrations_updated_at_idx\u0027"},{"line_number":23,"context_line":"TABLE_NAME \u003d \u0027migrations\u0027"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_399dc8bb","line":21,"updated":"2018-01-08 16:57:43.000000000","message":"I\u0027m not entirely sure how much this helps unless the user is only filtering on this field, because there are other columns that can be included in the same query:\n\nhttps://review.openstack.org/#/c/514904/33/nova/db/sqlalchemy/api.py\n\nBut from the novaclient perspective, listing migrations and filtering on --changes-since will probably be pretty normal, so this is probably better than not having it.","commit_id":"e7d5eaa0faf1e59c803586fdf258399294d3971a"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c3d209e22c6f2e7536bcb57a01af1ded9021f3c0","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"INDEX_COLUMNS \u003d [\u0027updated_at\u0027]"},{"line_number":22,"context_line":"INDEX_NAME \u003d \u0027migrations_updated_at_idx\u0027"},{"line_number":23,"context_line":"TABLE_NAME \u003d \u0027migrations\u0027"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_d4ef59e7","line":21,"in_reply_to":"9f91af0f_399dc8bb","updated":"2018-01-11 01:27:16.000000000","message":"An index on updated_at will have very good cardinality and will likely be used even when other fields (yes, even other fields that are in other indexes) are being queried on.","commit_id":"e7d5eaa0faf1e59c803586fdf258399294d3971a"}]}