)]}'
{"nova/tests/unit/virt/libvirt/fakelibvirt.py":[{"author":{"_account_id":14203,"name":"yangzhenyu","email":"cdyangzhenyu@gmail.com","username":"yangzhenyu"},"change_message_id":"48d98bfa0bfbb2b076610698045854bcead6e2bd","unresolved":false,"context_lines":[{"line_number":809,"context_line":"    def XMLDesc(self, flags):"},{"line_number":810,"context_line":"        disks \u003d \u0027\u0027"},{"line_number":811,"context_line":"        for disk in self._def[\u0027devices\u0027][\u0027disks\u0027]:"},{"line_number":812,"context_line":"            if disk[\u0027type\u0027] \u003d\u003d \u0027file\u0027:"},{"line_number":813,"context_line":"                source_attr \u003d \u0027file\u0027"},{"line_number":814,"context_line":"            else:"},{"line_number":815,"context_line":"                source_attr \u003d \u0027dev\u0027"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"            disks +\u003d \u0027\u0027\u0027\u003cdisk type\u003d\u0027%(type)s\u0027 device\u003d\u0027%(device)s\u0027\u003e"},{"line_number":818,"context_line":"      \u003cdriver name\u003d\u0027%(driver_name)s\u0027 type\u003d\u0027%(driver_type)s\u0027/\u003e"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_1c7a68f0","line":815,"range":{"start_line":812,"start_character":3,"end_line":815,"end_character":35},"updated":"2018-01-05 05:09:17.000000000","message":"I think this is more concise：\nsource_attr \u003d \u0027file\u0027 if disk[\u0027type\u0027] \u003d\u003d \u0027file\u0027 else \u0027dev\u0027","commit_id":"3664dd22539dca0e9663ff0686e1c657176d9e8c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"623cd6288927e751aa5647d4e9b01aa36ee19b41","unresolved":false,"context_lines":[{"line_number":809,"context_line":"    def XMLDesc(self, flags):"},{"line_number":810,"context_line":"        disks \u003d \u0027\u0027"},{"line_number":811,"context_line":"        for disk in self._def[\u0027devices\u0027][\u0027disks\u0027]:"},{"line_number":812,"context_line":"            if disk[\u0027type\u0027] \u003d\u003d \u0027file\u0027:"},{"line_number":813,"context_line":"                source_attr \u003d \u0027file\u0027"},{"line_number":814,"context_line":"            else:"},{"line_number":815,"context_line":"                source_attr \u003d \u0027dev\u0027"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"            disks +\u003d \u0027\u0027\u0027\u003cdisk type\u003d\u0027%(type)s\u0027 device\u003d\u0027%(device)s\u0027\u003e"},{"line_number":818,"context_line":"      \u003cdriver name\u003d\u0027%(driver_name)s\u0027 type\u003d\u0027%(driver_type)s\u0027/\u003e"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_e0b6968a","line":815,"range":{"start_line":812,"start_character":3,"end_line":815,"end_character":35},"in_reply_to":"9f91af0f_05bd28d7","updated":"2018-01-17 19:07:34.000000000","message":"+1","commit_id":"3664dd22539dca0e9663ff0686e1c657176d9e8c"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"f3a31bac9720deef04cb85ec5a4a1a8ca0ce3f99","unresolved":false,"context_lines":[{"line_number":809,"context_line":"    def XMLDesc(self, flags):"},{"line_number":810,"context_line":"        disks \u003d \u0027\u0027"},{"line_number":811,"context_line":"        for disk in self._def[\u0027devices\u0027][\u0027disks\u0027]:"},{"line_number":812,"context_line":"            if disk[\u0027type\u0027] \u003d\u003d \u0027file\u0027:"},{"line_number":813,"context_line":"                source_attr \u003d \u0027file\u0027"},{"line_number":814,"context_line":"            else:"},{"line_number":815,"context_line":"                source_attr \u003d \u0027dev\u0027"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"            disks +\u003d \u0027\u0027\u0027\u003cdisk type\u003d\u0027%(type)s\u0027 device\u003d\u0027%(device)s\u0027\u003e"},{"line_number":818,"context_line":"      \u003cdriver name\u003d\u0027%(driver_name)s\u0027 type\u003d\u0027%(driver_type)s\u0027/\u003e"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_05bd28d7","line":815,"range":{"start_line":812,"start_character":3,"end_line":815,"end_character":35},"in_reply_to":"9f91af0f_1c7a68f0","updated":"2018-01-05 13:04:16.000000000","message":"Please don\u0027t leave a -1 for this. You might mark this as a \u0027nit\u0027, however as it\u0027s a matter of personal preference I would mark this as a \u0027suggestion\u0027 when leaving a comment about something like this.\n\nThis is not a reason to exclude a fix.","commit_id":"3664dd22539dca0e9663ff0686e1c657176d9e8c"}]}