)]}'
{"nova/conductor/tasks/migrate.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b2453fb00b17fe1ee938b0ad7bca0eeab263ee60","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        source_cn.uuid, instance.uuid)"},{"line_number":49,"context_line":"    if not orig_alloc:"},{"line_number":50,"context_line":"        LOG.error(\u0027Unable to find existing allocations for instance on \u0027"},{"line_number":51,"context_line":"                  \u0027source compute node: %s\u0027, source_cn.uuid,"},{"line_number":52,"context_line":"                  instance\u003dinstance)"},{"line_number":53,"context_line":"        raise exception.ConsumerAllocationNotFound("},{"line_number":54,"context_line":"            consumer_id\u003dinstance.uuid, provider_uuid\u003dsource_cn.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_76743436","side":"PARENT","line":51,"updated":"2018-01-11 19:35:32.000000000","message":"It kinda sucks to lose this extremely important error log because of the ambiguity :/","commit_id":"5dad1ecc32e23f4e2656c210528a67ac16c0f834"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"93b2c4f058e59df2aefc990287149594f009b51a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        source_cn.uuid, instance.uuid)"},{"line_number":49,"context_line":"    if not orig_alloc:"},{"line_number":50,"context_line":"        LOG.error(\u0027Unable to find existing allocations for instance on \u0027"},{"line_number":51,"context_line":"                  \u0027source compute node: %s\u0027, source_cn.uuid,"},{"line_number":52,"context_line":"                  instance\u003dinstance)"},{"line_number":53,"context_line":"        raise exception.ConsumerAllocationNotFound("},{"line_number":54,"context_line":"            consumer_id\u003dinstance.uuid, provider_uuid\u003dsource_cn.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_36cc6c34","side":"PARENT","line":51,"in_reply_to":"7f96bb07_76743436","updated":"2018-01-11 19:40:12.000000000","message":"I know. We could check CONF.scheduler.driver, but that\u0027s not guaranteed to be set here either.","commit_id":"5dad1ecc32e23f4e2656c210528a67ac16c0f834"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b2453fb00b17fe1ee938b0ad7bca0eeab263ee60","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                  \u0027source compute node: %s\u0027, source_cn.uuid,"},{"line_number":52,"context_line":"                  instance\u003dinstance)"},{"line_number":53,"context_line":"        raise exception.ConsumerAllocationNotFound("},{"line_number":54,"context_line":"            consumer_id\u003dinstance.uuid, provider_uuid\u003dsource_cn.uuid)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    # FIXME(danms): This method is flawed in that it asssumes allocations"},{"line_number":57,"context_line":"    # against only one provider. So, this may overwite allocations against"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_d6b188e3","side":"PARENT","line":54,"updated":"2018-01-11 19:35:32.000000000","message":"Hmm, kinda feels like we should keep this and just handle it in each case instead of returning None,None, just if someone else uses this for something and/or if we were to want to detect versions and decide how important this is to log, stop a migration, etc. I know we can still detect if from the return value but, I dunno. Just sucky all around I guess.","commit_id":"5dad1ecc32e23f4e2656c210528a67ac16c0f834"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"93b2c4f058e59df2aefc990287149594f009b51a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                  \u0027source compute node: %s\u0027, source_cn.uuid,"},{"line_number":52,"context_line":"                  instance\u003dinstance)"},{"line_number":53,"context_line":"        raise exception.ConsumerAllocationNotFound("},{"line_number":54,"context_line":"            consumer_id\u003dinstance.uuid, provider_uuid\u003dsource_cn.uuid)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    # FIXME(danms): This method is flawed in that it asssumes allocations"},{"line_number":57,"context_line":"    # against only one provider. So, this may overwite allocations against"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_76e1949a","side":"PARENT","line":54,"in_reply_to":"7f96bb07_d6b188e3","updated":"2018-01-11 19:40:12.000000000","message":"We just need to figure out how to get rid of the CachingScheduler and migrate people using it to the FilterScheduler, and then all of our problems will be over. I\u0027ll add a reminder to the PTG etherpad for Rocky.","commit_id":"5dad1ecc32e23f4e2656c210528a67ac16c0f834"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"44b97dd81870067ef70dcc9428a4afdd62863597","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                  \u0027source compute node: %s. This is normal if you are not \u0027"},{"line_number":52,"context_line":"                  \u0027using the FilterScheduler.\u0027, source_cn.uuid,"},{"line_number":53,"context_line":"                  instance\u003dinstance)"},{"line_number":54,"context_line":"        return None, None"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    # FIXME(danms): This method is flawed in that it asssumes allocations"},{"line_number":57,"context_line":"    # against only one provider. So, this may overwite allocations against"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_d140b20a","line":54,"updated":"2018-01-11 20:04:42.000000000","message":"Note to self: we return None for compute node and allocation, respectively, so we avoid raising ConsumerAllocationNotFound. And then in the case of a migrate task rollback(), if self._held_allocations is None, it just returns.","commit_id":"68f7b95bdc9530d76937465c9018d1242548ac2e"}]}