)]}'
{"nova/compute/provider_tree.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4206a1d3f2b35eed901094fdcbe997794c4326f6","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        :param generation: Generation to set for the new child provider"},{"line_number":405,"context_line":"        :returns: the UUID of the new provider"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        :raises ValueError if parent_uuid points to a non-existing provider."},{"line_number":408,"context_line":"        \"\"\""},{"line_number":409,"context_line":"        with self.lock:"},{"line_number":410,"context_line":"            exists \u003d True"}],"source_content_type":"text/x-python","patch_set":33,"id":"df7087c5_8d50f10c","line":407,"range":{"start_line":407,"start_character":30,"end_line":407,"end_character":76},"updated":"2018-03-16 23:35:57.000000000","message":"need to add\n\n specifying an existing child provider\n\nfor ValueError condition.","commit_id":"98655d064852a67bc4a3d2d0f3af1cff436f3069"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f3b91ca6b281778ae1ae59b75076a6d9d9439e65","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        :param generation: Generation to set for the new child provider"},{"line_number":405,"context_line":"        :returns: the UUID of the new provider"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        :raises ValueError if parent_uuid points to a non-existing provider."},{"line_number":408,"context_line":"        \"\"\""},{"line_number":409,"context_line":"        with self.lock:"},{"line_number":410,"context_line":"            exists \u003d True"}],"source_content_type":"text/x-python","patch_set":33,"id":"df7087c5_917d021e","line":407,"range":{"start_line":407,"start_character":30,"end_line":407,"end_character":76},"in_reply_to":"df7087c5_71c4ee5f","updated":"2018-03-22 00:25:54.000000000","message":"Oh, turns out I had already done that here: https://review.openstack.org/#/c/539324/11/nova/compute/provider_tree.py@456","commit_id":"98655d064852a67bc4a3d2d0f3af1cff436f3069"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d3fac9eccc1005626ea46c975d7e62b1ac1dc9ac","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        :param generation: Generation to set for the new child provider"},{"line_number":405,"context_line":"        :returns: the UUID of the new provider"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"        :raises ValueError if parent_uuid points to a non-existing provider."},{"line_number":408,"context_line":"        \"\"\""},{"line_number":409,"context_line":"        with self.lock:"},{"line_number":410,"context_line":"            exists \u003d True"}],"source_content_type":"text/x-python","patch_set":33,"id":"df7087c5_71c4ee5f","line":407,"range":{"start_line":407,"start_character":30,"end_line":407,"end_character":76},"in_reply_to":"df7087c5_8d50f10c","updated":"2018-03-22 00:22:57.000000000","message":"Done","commit_id":"98655d064852a67bc4a3d2d0f3af1cff436f3069"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"4206a1d3f2b35eed901094fdcbe997794c4326f6","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        :raises ValueError if parent_uuid points to a non-existing provider."},{"line_number":408,"context_line":"        \"\"\""},{"line_number":409,"context_line":"        with self.lock:"},{"line_number":410,"context_line":"            exists \u003d True"},{"line_number":411,"context_line":"            try:"},{"line_number":412,"context_line":"                self._find_with_lock(uuid or name)"},{"line_number":413,"context_line":"            except ValueError:"},{"line_number":414,"context_line":"                exists \u003d False"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"            if exists:"},{"line_number":417,"context_line":"                err \u003d _(\"Provider %s already exists.\")"},{"line_number":418,"context_line":"                raise ValueError(err % (uuid or name))"},{"line_number":419,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"df7087c5_2da3e502","line":416,"range":{"start_line":410,"start_character":0,"end_line":416,"end_character":22},"updated":"2018-03-16 23:35:57.000000000","message":"nit: How about\n\n try:\n     self._find_with_lock(uuid or name)\n except ValueError:\n     pass\n else:\n     err \u003d _(\"Provider %s already exists.\")\n     raise ValueError(err % (uuid or name))\n\nwithout the value exists?","commit_id":"98655d064852a67bc4a3d2d0f3af1cff436f3069"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d3fac9eccc1005626ea46c975d7e62b1ac1dc9ac","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        :raises ValueError if parent_uuid points to a non-existing provider."},{"line_number":408,"context_line":"        \"\"\""},{"line_number":409,"context_line":"        with self.lock:"},{"line_number":410,"context_line":"            exists \u003d True"},{"line_number":411,"context_line":"            try:"},{"line_number":412,"context_line":"                self._find_with_lock(uuid or name)"},{"line_number":413,"context_line":"            except ValueError:"},{"line_number":414,"context_line":"                exists \u003d False"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"            if exists:"},{"line_number":417,"context_line":"                err \u003d _(\"Provider %s already exists.\")"},{"line_number":418,"context_line":"                raise ValueError(err % (uuid or name))"},{"line_number":419,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"df7087c5_51c9aa75","line":416,"range":{"start_line":410,"start_character":0,"end_line":416,"end_character":22},"in_reply_to":"df7087c5_2da3e502","updated":"2018-03-22 00:22:57.000000000","message":"Nice, done.","commit_id":"98655d064852a67bc4a3d2d0f3af1cff436f3069"}],"nova/scheduler/client/report.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"21c67deda95afacd3c5c5f8e85715492401fdaff","unresolved":false,"context_lines":[{"line_number":1349,"context_line":"                self._provider_tree.remove(rp_uuid)"},{"line_number":1350,"context_line":"            except ValueError:"},{"line_number":1351,"context_line":"                pass"},{"line_number":1352,"context_line":"            self.association_refresh_time.pop(rp_uuid, None)"},{"line_number":1353,"context_line":""},{"line_number":1354,"context_line":"        # Overall indicator of success.  Will be set to False on any exception."},{"line_number":1355,"context_line":"        success \u003d True"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f96bb07_e7299ee5","line":1352,"range":{"start_line":1352,"start_character":17,"end_line":1352,"end_character":41},"updated":"2018-01-18 22:04:22.000000000","message":"_association_refresh_time","commit_id":"d6ae28f867749a4eab5f7989deb3dc110e3fd135"}]}