)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"966da8770a9a04edd3f6c16c1014ea0b7c8e61bc","unresolved":false,"context_lines":[{"line_number":14015,"context_line":"        self.stubs.Set(host.Host, \"get_capabilities\","},{"line_number":14016,"context_line":"                       get_host_capabilities_stub)"},{"line_number":14017,"context_line":""},{"line_number":14018,"context_line":"        want \u003d [(fields.Architecture.X86_64, \u0027kvm\u0027, \u0027hvm\u0027),"},{"line_number":14019,"context_line":"                (fields.Architecture.I686, \u0027kvm\u0027, \u0027hvm\u0027)]"},{"line_number":14020,"context_line":"        got \u003d drvr._get_instance_capabilities()"},{"line_number":14021,"context_line":"        self.assertEqual(want, got)"},{"line_number":14022,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_4b925fa0","line":14019,"range":{"start_line":14018,"start_character":0,"end_line":14019,"end_character":57},"updated":"2018-01-05 14:40:43.000000000","message":"Can you add a note here stating that \u0027qemu\u0027 is purposefully excluded because it\u0027s not in the default list of virt drivers?\n\nSpeaking of which, where _is_ that default list defined?","commit_id":"c5b798ef22bbaddb11a84cffed9b437a0ab5c76f"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"5be06c69a9859fdb8eeb7f9b6eff8a5eacdde4ce","unresolved":false,"context_lines":[{"line_number":14015,"context_line":"        self.stubs.Set(host.Host, \"get_capabilities\","},{"line_number":14016,"context_line":"                       get_host_capabilities_stub)"},{"line_number":14017,"context_line":""},{"line_number":14018,"context_line":"        want \u003d [(fields.Architecture.X86_64, \u0027kvm\u0027, \u0027hvm\u0027),"},{"line_number":14019,"context_line":"                (fields.Architecture.I686, \u0027kvm\u0027, \u0027hvm\u0027)]"},{"line_number":14020,"context_line":"        got \u003d drvr._get_instance_capabilities()"},{"line_number":14021,"context_line":"        self.assertEqual(want, got)"},{"line_number":14022,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f91af0f_b3a2754a","line":14019,"range":{"start_line":14018,"start_character":0,"end_line":14019,"end_character":57},"in_reply_to":"9f91af0f_4b925fa0","updated":"2018-01-06 02:24:38.000000000","message":"That makes a lot of sense. To make things clearer, I prepared 2 tests; one for kvm and the other for qemu.","commit_id":"c5b798ef22bbaddb11a84cffed9b437a0ab5c76f"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ff99a129f537c82191e23cd5529ae74acf07b042","unresolved":false,"context_lines":[{"line_number":5529,"context_line":"        instance_caps \u003d list()"},{"line_number":5530,"context_line":"        for g in caps.guests:"},{"line_number":5531,"context_line":"            for dt in g.domtype:"},{"line_number":5532,"context_line":"                if dt !\u003d CONF.libvirt.virt_type:"},{"line_number":5533,"context_line":"                    continue"},{"line_number":5534,"context_line":"                instance_cap \u003d ("},{"line_number":5535,"context_line":"                    fields.Architecture.canonicalize(g.arch),"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_3fb54fce","line":5532,"updated":"2018-03-16 21:59:30.000000000","message":"I guess this isn\u0027t a problem for qemu vs. lxc because we connect by major type (i.e. qemu:///system) ?\n\nAnyway, this looks sane to me.","commit_id":"eaa766ee2093c24fd61c61e52f46bdd9ff9e93d2"}]}