)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"befc8103861221c12eadb1bf33bd90b70d625c1e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"idempotent. We depend on the fixes for those os-brick drivers."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Depends-On: I31d72357c89db53a147c2d986a28c9c6870efad0"},{"line_number":46,"context_line":"Depends-On: I9f52f89b8466d03699cfd5c0e32c672c934cd6fb"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Closes-bug: #1724573"},{"line_number":49,"context_line":"Change-Id: Id188d48609f3d22d14e16c7f6114291d547a8986"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_1a66db52","line":46,"range":{"start_line":46,"start_character":12,"end_line":46,"end_character":53},"updated":"2018-01-05 18:23:30.000000000","message":"Hmm, this hasn\u0027t been released on pike:\n\nhttps://review.openstack.org/#/c/527490/\n\nAnd when it is, I don\u0027t think we can bump the minimum required in global-requirements. We can raise upper-constraints, though, but I\u0027m thinking since it\u0027s stable and we can\u0027t bump the minimum required os-brick for pike, we might need a \u0027fixes\u0027 release note with this to point out the change and dependency on os-brick.","commit_id":"420390eb3af9903ede33bb7bf430ff77f47837c8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a08dd14488c72157421a8c0dd8e62b23e97015d8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"idempotent. We depend on the fixes for those os-brick drivers."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Depends-On: I31d72357c89db53a147c2d986a28c9c6870efad0"},{"line_number":46,"context_line":"Depends-On: I9f52f89b8466d03699cfd5c0e32c672c934cd6fb"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Closes-bug: #1724573"},{"line_number":49,"context_line":"Change-Id: Id188d48609f3d22d14e16c7f6114291d547a8986"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_400be87b","line":46,"range":{"start_line":46,"start_character":12,"end_line":46,"end_character":53},"in_reply_to":"9f91af0f_1a66db52","updated":"2018-01-09 01:32:13.000000000","message":"I\u0027ve uploaded a new PS that handles the exit code in the driver, as we discussed on IRC.","commit_id":"420390eb3af9903ede33bb7bf430ff77f47837c8"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bf4007d7ce0590ce83648b452ae0be07dd3fc04a","unresolved":false,"context_lines":[{"line_number":988,"context_line":"                    try:"},{"line_number":989,"context_line":"                        encryptor.detach_volume(**encryption)"},{"line_number":990,"context_line":"                    except processutils.ProcessExecutionError as e:"},{"line_number":991,"context_line":"                        if e.exit_code \u003d\u003d 4:"},{"line_number":992,"context_line":"                            LOG.debug(\u0027Ignoring exit code 4, volume already \u0027"},{"line_number":993,"context_line":"                                      \u0027destroyed\u0027)"},{"line_number":994,"context_line":"                        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_5d8494b1","line":991,"range":{"start_line":991,"start_character":24,"end_line":991,"end_character":44},"updated":"2018-01-12 20:40:03.000000000","message":"OK on master this is handled in os-brick:\n\nhttps://review.openstack.org/#/c/521809/2/os_brick/encryptors/luks.py\n\nhttps://review.openstack.org/#/c/522263/1/os_brick/encryptors/cryptsetup.py","commit_id":"bd66397230054cdcdcd9556b49d6bd1fe3694c1b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bf4007d7ce0590ce83648b452ae0be07dd3fc04a","unresolved":false,"context_lines":[{"line_number":989,"context_line":"                        encryptor.detach_volume(**encryption)"},{"line_number":990,"context_line":"                    except processutils.ProcessExecutionError as e:"},{"line_number":991,"context_line":"                        if e.exit_code \u003d\u003d 4:"},{"line_number":992,"context_line":"                            LOG.debug(\u0027Ignoring exit code 4, volume already \u0027"},{"line_number":993,"context_line":"                                      \u0027destroyed\u0027)"},{"line_number":994,"context_line":"                        else:"},{"line_number":995,"context_line":"                            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_bdc7d812","line":992,"updated":"2018-01-12 20:40:03.000000000","message":"Arguably we don\u0027t even need to log anything here...","commit_id":"bd66397230054cdcdcd9556b49d6bd1fe3694c1b"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"fdf58b1343fef5dee1b45494113fc7997fd7a7e5","unresolved":false,"context_lines":[{"line_number":989,"context_line":"                        encryptor.detach_volume(**encryption)"},{"line_number":990,"context_line":"                    except processutils.ProcessExecutionError as e:"},{"line_number":991,"context_line":"                        if e.exit_code \u003d\u003d 4:"},{"line_number":992,"context_line":"                            LOG.debug(\u0027Ignoring exit code 4, volume already \u0027"},{"line_number":993,"context_line":"                                      \u0027destroyed\u0027)"},{"line_number":994,"context_line":"                        else:"},{"line_number":995,"context_line":"                            with excutils.save_and_reraise_exception():"},{"line_number":996,"context_line":"                                LOG.warning("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f91af0f_06ee4eec","line":993,"range":{"start_line":992,"start_character":61,"end_line":993,"end_character":49},"updated":"2018-01-09 11:31:37.000000000","message":"supersupernit - `encryptor already detached`","commit_id":"bd66397230054cdcdcd9556b49d6bd1fe3694c1b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bf4007d7ce0590ce83648b452ae0be07dd3fc04a","unresolved":false,"context_lines":[{"line_number":996,"context_line":"                                LOG.warning("},{"line_number":997,"context_line":"                                    \u0027Could not disconnect encrypted volume \u0027"},{"line_number":998,"context_line":"                                    \u0027%(volume)s. If the device is still \u0027"},{"line_number":999,"context_line":"                                    \u0027active, it will have to destroyed \u0027"},{"line_number":1000,"context_line":"                                    \u0027manually for cleanup to succeed.\u0027,"},{"line_number":1001,"context_line":"                                    {\u0027volume\u0027: disk_dev})"},{"line_number":1002,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_fd4fa0ba","line":999,"range":{"start_line":999,"start_character":61,"end_line":999,"end_character":70},"updated":"2018-01-12 20:40:03.000000000","message":"be destroyed","commit_id":"bd66397230054cdcdcd9556b49d6bd1fe3694c1b"}]}