)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d28bfe34ba28ea84c1d42714d8dda3cda6d506a3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Parent:     e0879835 (libvirt: create vGPU for instance)"},{"line_number":2,"context_line":"Author:     Sylvain Bauza \u003csbauza@redhat.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2018-01-08 14:23:56 +0100"},{"line_number":4,"context_line":"Commit:     Sylvain Bauza \u003csbauza@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_407bf5f3","line":1,"updated":"2018-01-08 15:44:45.000000000","message":"line width (annoying having to right-scroll)","commit_id":"d86a409ffdcf765d9f5f1a2dc49bceb8b99bdb8e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d28bfe34ba28ea84c1d42714d8dda3cda6d506a3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sylvain Bauza \u003csbauza@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-01-08 14:50:07 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt : Force a specificly static UUID for a mediated device"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since mediated devices are not persisted upon reboot with libvirt, we need a"},{"line_number":10,"context_line":"way to consider non-dynamically generated UUIDs and rather use hashed UUIDs so"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_00816dc3","line":7,"range":{"start_line":7,"start_character":18,"end_line":7,"end_character":28},"updated":"2018-01-08 15:44:45.000000000","message":"specifically","commit_id":"d86a409ffdcf765d9f5f1a2dc49bceb8b99bdb8e"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"d28bfe34ba28ea84c1d42714d8dda3cda6d506a3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Fortunately, RFC4122 proposes 2 versions for our purpose: v3 and v5."},{"line_number":14,"context_line":"Let\u0027s take v3 (MD5 hash) and use it by generating an UUID based on the existing"},{"line_number":15,"context_line":"instance UUID and the current index of the number of mediated devices we want"},{"line_number":16,"context_line":"to create."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"For example, say instance A uses 2 mediated devices in its guest configuration."},{"line_number":19,"context_line":"Instead of looking up the guest XML (which can be wrong in case of a hard"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f91af0f_40c9b523","line":16,"updated":"2018-01-08 15:44:45.000000000","message":"Is this is going to break down when we want to support multiple types?  Unless the devices are always going to be in the same order...","commit_id":"d86a409ffdcf765d9f5f1a2dc49bceb8b99bdb8e"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"b01d4261d61feb65e96d0a462e6a77fdc850864a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since mediated devices are not persisted upon reboot with libvirt, we need a"},{"line_number":10,"context_line":"way to consider non-dynamically generated UUIDs and rather use hashed UUIDs so"},{"line_number":11,"context_line":"when we restart nova-compute, it can pass the same UUID for creating it again."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Fortunately, RFC4122 proposes 2 versions for our purpose: v3 and v5."},{"line_number":14,"context_line":"Let\u0027s take v3 (MD5 hash) and use it by generating an UUID based on the existing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f96bb07_9478f1f8","line":11,"updated":"2018-01-11 01:45:39.000000000","message":"why though? it\u0027s not like the mediated device is a resource provider or something that we need to have a permanent identifier. The mediated device is merely a connector to a VGPU (or some other type of device handle that uses an mdev bus).\n\nThe resource *provider* in this case is the physical GPU, not the mediated device. The physical GPU has a permanent identifier so we should be just fine using that...","commit_id":"84756ca41ac4fc46f9bf09ad03d04c98e6718c2b"}]}