)]}'
{".zuul.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0388d3e0db4a384cdf15ae92536020ad70f6c9fb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      jobs:"},{"line_number":56,"context_line":"        # Please try to keep this list of job names sorted alphabetically."},{"line_number":57,"context_line":"        - nova-lvm"},{"line_number":58,"context_line":"        - nova-multiattach"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f96bb07_79872b11","line":58,"updated":"2018-01-12 15:27:35.000000000","message":"We should probably make this a non-voting check queue job otherwise people will forget to run it. We can do that after the changes are all merged though.","commit_id":"0e8871ba42d3fc30f40af86c6ac241b19be2f2bf"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"092bc07c5700f0d6bd0281433e7abae53fc76e0f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      jobs:"},{"line_number":56,"context_line":"        # Please try to keep this list of job names sorted alphabetically."},{"line_number":57,"context_line":"        - nova-lvm"},{"line_number":58,"context_line":"        - nova-multiattach"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f96bb07_7fcf0bb0","line":58,"in_reply_to":"7f96bb07_79872b11","updated":"2018-01-12 16:34:35.000000000","message":"+1","commit_id":"0e8871ba42d3fc30f40af86c6ac241b19be2f2bf"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4afa739f2d2b808c5533c2c8b97854dcf4cf02e7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    name: nova-base"},{"line_number":5,"context_line":"    parent: legacy-dsvm-base"},{"line_number":6,"context_line":"    description: |"},{"line_number":7,"context_line":"      The base job definition for nova jobs. Contains common configuration."},{"line_number":8,"context_line":"    timeout: 10800"},{"line_number":9,"context_line":"    required-projects:"},{"line_number":10,"context_line":"      - openstack-infra/devstack-gate"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_7c476c78","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":43},"updated":"2018-02-02 14:19:17.000000000","message":"nit: It is only base job for the devstack jobs but not for the functional jobs.","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fa0f877811c09b6d789863a8091807fbd39f3c32","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    name: nova-base"},{"line_number":5,"context_line":"    parent: legacy-dsvm-base"},{"line_number":6,"context_line":"    description: |"},{"line_number":7,"context_line":"      The base job definition for nova jobs. Contains common configuration."},{"line_number":8,"context_line":"    timeout: 10800"},{"line_number":9,"context_line":"    required-projects:"},{"line_number":10,"context_line":"      - openstack-infra/devstack-gate"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_20921258","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":43},"in_reply_to":"5f93b717_7c476c78","updated":"2018-02-02 16:18:12.000000000","message":"I suppose I should rename to nova-dsvm-base.","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4afa739f2d2b808c5533c2c8b97854dcf4cf02e7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    description: |"},{"line_number":7,"context_line":"      The base job definition for nova jobs. Contains common configuration."},{"line_number":8,"context_line":"    timeout: 10800"},{"line_number":9,"context_line":"    required-projects:"},{"line_number":10,"context_line":"      - openstack-infra/devstack-gate"},{"line_number":11,"context_line":"      - openstack/nova"},{"line_number":12,"context_line":"      - openstack/tempest"},{"line_number":13,"context_line":"    irrelevant-files:"},{"line_number":14,"context_line":"      - ^(placement-)?api-.*$"},{"line_number":15,"context_line":"      - ^(test-|)requirements.txt$"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_b72d0f96","line":12,"range":{"start_line":9,"start_character":1,"end_line":12,"end_character":25},"updated":"2018-02-02 14:19:17.000000000","message":"This list does not make sense to me. The base job, defines a lot longer list [1] that already includes these 3 projects as well. So if this definition just adds to that list then it is not necessary. If this definition totally overwrites that based job required-projects list then I don\u0027t see how the tempest scenario tests could run with only these three modules installed. \n\n[1] https://github.com/openstack-infra/openstack-zuul-jobs/blob/628dfad2809f803fbacd00ed78f78254a6811531/zuul.d/jobs.yaml#L647","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fa0f877811c09b6d789863a8091807fbd39f3c32","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    description: |"},{"line_number":7,"context_line":"      The base job definition for nova jobs. Contains common configuration."},{"line_number":8,"context_line":"    timeout: 10800"},{"line_number":9,"context_line":"    required-projects:"},{"line_number":10,"context_line":"      - openstack-infra/devstack-gate"},{"line_number":11,"context_line":"      - openstack/nova"},{"line_number":12,"context_line":"      - openstack/tempest"},{"line_number":13,"context_line":"    irrelevant-files:"},{"line_number":14,"context_line":"      - ^(placement-)?api-.*$"},{"line_number":15,"context_line":"      - ^(test-|)requirements.txt$"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_e070aa42","line":12,"range":{"start_line":9,"start_character":1,"end_line":12,"end_character":25},"in_reply_to":"5f93b717_b72d0f96","updated":"2018-02-02 16:18:12.000000000","message":"This was copied from the existing nova-lvm job in here, I don\u0027t really know what required-projects even means or how it\u0027s used, i.e. we\u0027d also need cinder, neutron, glance, keystone, etc obviously. If it\u0027s alright with you, I\u0027d just prefer to leave this for now and if/when we get a clear answer from infra on if we should even care about this, we can change it.","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6023ba8c8ebe64bf4019949a86a0d733dc1a60fa","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    description: |"},{"line_number":7,"context_line":"      The base job definition for nova jobs. Contains common configuration."},{"line_number":8,"context_line":"    timeout: 10800"},{"line_number":9,"context_line":"    required-projects:"},{"line_number":10,"context_line":"      - openstack-infra/devstack-gate"},{"line_number":11,"context_line":"      - openstack/nova"},{"line_number":12,"context_line":"      - openstack/tempest"},{"line_number":13,"context_line":"    irrelevant-files:"},{"line_number":14,"context_line":"      - ^(placement-)?api-.*$"},{"line_number":15,"context_line":"      - ^(test-|)requirements.txt$"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_e01aeac3","line":12,"range":{"start_line":9,"start_character":1,"end_line":12,"end_character":25},"in_reply_to":"5f93b717_e070aa42","updated":"2018-02-02 16:35:18.000000000","message":"Sure. Let\u0027s handle this in a follow up if needed.","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6c8eb123c14ca5d31e5a79d212f364221f1a5841","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      It uses the default Cinder volume type in devstack (lvm) and the"},{"line_number":78,"context_line":"      default compute driver in devstack (libvirt). It also disables the"},{"line_number":79,"context_line":"      Pike Ubuntu Cloud Archive because volume multiattach support with"},{"line_number":80,"context_line":"      the libvirt driver only works with qemu\u003c2.10 or libvirt\u003e\u003d3.10 which"},{"line_number":81,"context_line":"      won\u0027t work with the Pike UCA."},{"line_number":82,"context_line":"    branches: ^(?!stable/(newton|ocata|pike)).*$"},{"line_number":83,"context_line":"    run: playbooks/legacy/nova-multiattach/run.yaml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_88332962","line":80,"range":{"start_line":80,"start_character":41,"end_line":80,"end_character":50},"updated":"2018-02-01 16:48:55.000000000","message":"ditto","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3997f5b1931472cffde95c71ef571373dc689834","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      It uses the default Cinder volume type in devstack (lvm) and the"},{"line_number":78,"context_line":"      default compute driver in devstack (libvirt). It also disables the"},{"line_number":79,"context_line":"      Pike Ubuntu Cloud Archive because volume multiattach support with"},{"line_number":80,"context_line":"      the libvirt driver only works with qemu\u003c2.10 or libvirt\u003e\u003d3.10 which"},{"line_number":81,"context_line":"      won\u0027t work with the Pike UCA."},{"line_number":82,"context_line":"    branches: ^(?!stable/(newton|ocata|pike)).*$"},{"line_number":83,"context_line":"    run: playbooks/legacy/nova-multiattach/run.yaml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_3ce57a38","line":80,"range":{"start_line":80,"start_character":41,"end_line":80,"end_character":50},"in_reply_to":"5f93b717_88332962","updated":"2018-02-01 16:58:59.000000000","message":"not really following you","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0edb25cd30902ab53f7f90d71e15363b53884422","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      Run tempest integration tests with volume multiattach support enabled."},{"line_number":76,"context_line":"      This job will only work starting with Queens."},{"line_number":77,"context_line":"      It uses the default Cinder volume type in devstack (lvm) and the"},{"line_number":78,"context_line":"      default compute driver in devstack (libvirt). It also disables the"},{"line_number":79,"context_line":"      Pike Ubuntu Cloud Archive because volume multiattach support with"},{"line_number":80,"context_line":"      the libvirt driver only works with qemu\u003c2.10 or libvirt\u003e\u003d3.10 which"},{"line_number":81,"context_line":"      won\u0027t work with the Pike UCA."},{"line_number":82,"context_line":"    branches: ^(?!stable/(newton|ocata|pike)).*$"},{"line_number":83,"context_line":"    run: playbooks/legacy/nova-multiattach/run.yaml"},{"line_number":84,"context_line":"    post-run: playbooks/legacy/nova-multiattach/post.yaml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_7c15423f","line":81,"range":{"start_line":78,"start_character":52,"end_line":81,"end_character":35},"updated":"2018-02-01 16:51:30.000000000","message":"This confuses me. Based on the linked bug, it seems the feature _did work_ with cloud archive, and _did not work_ with standard packages. This seems to say the inverse. What am I missing?","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e38ea08707114bede8ee6e6324fc5fbd4b9ea3ab","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      Run tempest integration tests with volume multiattach support enabled."},{"line_number":76,"context_line":"      This job will only work starting with Queens."},{"line_number":77,"context_line":"      It uses the default Cinder volume type in devstack (lvm) and the"},{"line_number":78,"context_line":"      default compute driver in devstack (libvirt). It also disables the"},{"line_number":79,"context_line":"      Pike Ubuntu Cloud Archive because volume multiattach support with"},{"line_number":80,"context_line":"      the libvirt driver only works with qemu\u003c2.10 or libvirt\u003e\u003d3.10 which"},{"line_number":81,"context_line":"      won\u0027t work with the Pike UCA."},{"line_number":82,"context_line":"    branches: ^(?!stable/(newton|ocata|pike)).*$"},{"line_number":83,"context_line":"    run: playbooks/legacy/nova-multiattach/run.yaml"},{"line_number":84,"context_line":"    post-run: playbooks/legacy/nova-multiattach/post.yaml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_fc65d21e","line":81,"range":{"start_line":78,"start_character":52,"end_line":81,"end_character":35},"in_reply_to":"5f93b717_5cb96612","updated":"2018-02-01 17:29:11.000000000","message":"It was this section from the bug that was linked in the commit message [1] that confused me:\n\n  earlier in Queens, we were testing against the Pike UCA\n  packages which has libvirt 3.6.0 and qemu 2.10. Live\n  snapshots of a paused instance work with those package\n  versions as shown by the test_create_image_from_paused_server\n  test in Tempest. However, if you just use the Ubuntu 16.04\n  packages for libvirt (1.3.1) and qemu (2.5), that test fails\n  and the live snapshot hangs on the paused instance.\n\nI missed the fact that this was referring to \"live snapshot\" support - not volume multi-attach support.\n\nHowever, that does raise another question: if QEMU removed support for this in 2.10, I assume there was a good reason for doing so? If so, do we really want to be validating behavior on this version as opposed to saying (in code) \"you need libvirt \u003e\u003d 3.10\" and using a Fedora base or similar for this job?\n\n[1] https://review.openstack.org/#/c/532214/","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3997f5b1931472cffde95c71ef571373dc689834","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      Run tempest integration tests with volume multiattach support enabled."},{"line_number":76,"context_line":"      This job will only work starting with Queens."},{"line_number":77,"context_line":"      It uses the default Cinder volume type in devstack (lvm) and the"},{"line_number":78,"context_line":"      default compute driver in devstack (libvirt). It also disables the"},{"line_number":79,"context_line":"      Pike Ubuntu Cloud Archive because volume multiattach support with"},{"line_number":80,"context_line":"      the libvirt driver only works with qemu\u003c2.10 or libvirt\u003e\u003d3.10 which"},{"line_number":81,"context_line":"      won\u0027t work with the Pike UCA."},{"line_number":82,"context_line":"    branches: ^(?!stable/(newton|ocata|pike)).*$"},{"line_number":83,"context_line":"    run: playbooks/legacy/nova-multiattach/run.yaml"},{"line_number":84,"context_line":"    post-run: playbooks/legacy/nova-multiattach/post.yaml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_5cb96612","line":81,"range":{"start_line":78,"start_character":52,"end_line":81,"end_character":35},"in_reply_to":"5f93b717_7c15423f","updated":"2018-02-01 16:58:59.000000000","message":"qemu 2.10 intentionally prohibited the ability to do shared disks which are required for volume multiattach, at least it wouldn\u0027t work with libvirt\u003c3.10. Based on my comment in the commit message, I\u0027m not sure why this isn\u0027t clear.","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"846f3d30a09e482c06c896354ecf3a1890cb054d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      Run tempest integration tests with volume multiattach support enabled."},{"line_number":76,"context_line":"      This job will only work starting with Queens."},{"line_number":77,"context_line":"      It uses the default Cinder volume type in devstack (lvm) and the"},{"line_number":78,"context_line":"      default compute driver in devstack (libvirt). It also disables the"},{"line_number":79,"context_line":"      Pike Ubuntu Cloud Archive because volume multiattach support with"},{"line_number":80,"context_line":"      the libvirt driver only works with qemu\u003c2.10 or libvirt\u003e\u003d3.10 which"},{"line_number":81,"context_line":"      won\u0027t work with the Pike UCA."},{"line_number":82,"context_line":"    branches: ^(?!stable/(newton|ocata|pike)).*$"},{"line_number":83,"context_line":"    run: playbooks/legacy/nova-multiattach/run.yaml"},{"line_number":84,"context_line":"    post-run: playbooks/legacy/nova-multiattach/post.yaml"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_ffa384b0","line":81,"range":{"start_line":78,"start_character":52,"end_line":81,"end_character":35},"in_reply_to":"5f93b717_fc65d21e","updated":"2018-02-01 17:32:57.000000000","message":"\u003e However, that does raise another question: if QEMU removed support\n \u003e for this in 2.10, I assume there was a good reason for doing so? If\n \u003e so, do we really want to be validating behavior on this version as\n \u003e opposed to saying (in code) \"you need libvirt \u003e\u003d 3.10\" and using a\n \u003e Fedora base or similar for this job?\n\nThe answer to that is here:\n\n  https://bugzilla.redhat.com/show_bug.cgi?id\u003d1378242#c21\n\nQEMU added a new requirement around locking. We validate that here:\n\n  https://github.com/openstack/nova/blob/02b505806a3a4d7cb51cf0a78523bb15338b27ce/nova/virt/libvirt/driver.py#L599\n\nSo we\u0027re good to go","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4afa739f2d2b808c5533c2c8b97854dcf4cf02e7","unresolved":false,"context_lines":[{"line_number":80,"context_line":"      the libvirt driver only works with qemu\u003c2.10 or libvirt\u003e\u003d3.10 which"},{"line_number":81,"context_line":"      won\u0027t work with the Pike UCA."},{"line_number":82,"context_line":"    branches: ^(?!stable/(newton|ocata|pike)).*$"},{"line_number":83,"context_line":"    run: playbooks/legacy/nova-multiattach/run.yaml"},{"line_number":84,"context_line":"    post-run: playbooks/legacy/nova-multiattach/post.yaml"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"- project:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_177963c6","line":83,"range":{"start_line":83,"start_character":19,"end_line":83,"end_character":25},"updated":"2018-02-02 14:19:17.000000000","message":"Is this really a legacy job?","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fa0f877811c09b6d789863a8091807fbd39f3c32","unresolved":false,"context_lines":[{"line_number":80,"context_line":"      the libvirt driver only works with qemu\u003c2.10 or libvirt\u003e\u003d3.10 which"},{"line_number":81,"context_line":"      won\u0027t work with the Pike UCA."},{"line_number":82,"context_line":"    branches: ^(?!stable/(newton|ocata|pike)).*$"},{"line_number":83,"context_line":"    run: playbooks/legacy/nova-multiattach/run.yaml"},{"line_number":84,"context_line":"    post-run: playbooks/legacy/nova-multiattach/post.yaml"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"- project:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_40971e3b","line":83,"range":{"start_line":83,"start_character":19,"end_line":83,"end_character":25},"in_reply_to":"5f93b717_177963c6","updated":"2018-02-02 16:18:12.000000000","message":"Yes because it\u0027s using the devstack-gate variables. A native zuulv3 job is foreign brave new world to me, and involves a bunch of ansible tasks that I\u0027m not familiar with.","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6023ba8c8ebe64bf4019949a86a0d733dc1a60fa","unresolved":false,"context_lines":[{"line_number":80,"context_line":"      the libvirt driver only works with qemu\u003c2.10 or libvirt\u003e\u003d3.10 which"},{"line_number":81,"context_line":"      won\u0027t work with the Pike UCA."},{"line_number":82,"context_line":"    branches: ^(?!stable/(newton|ocata|pike)).*$"},{"line_number":83,"context_line":"    run: playbooks/legacy/nova-multiattach/run.yaml"},{"line_number":84,"context_line":"    post-run: playbooks/legacy/nova-multiattach/post.yaml"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"- project:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_00583685","line":83,"range":{"start_line":83,"start_character":19,"end_line":83,"end_character":25},"in_reply_to":"5f93b717_40971e3b","updated":"2018-02-02 16:35:18.000000000","message":"Ohh. OK. Then It is a brave new word to me too. :)","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4afa739f2d2b808c5533c2c8b97854dcf4cf02e7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        - nova-tox-functional-py35"},{"line_number":98,"context_line":"    experimental:"},{"line_number":99,"context_line":"      jobs:"},{"line_number":100,"context_line":"        # Please try to keep this list of job names sorted alphabetically."},{"line_number":101,"context_line":"        - nova-lvm"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_773c67e0","line":100,"updated":"2018-02-02 14:19:17.000000000","message":"Don\u0027t we want to keep gate and check jobs sorted as well?","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fa0f877811c09b6d789863a8091807fbd39f3c32","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        - nova-tox-functional-py35"},{"line_number":98,"context_line":"    experimental:"},{"line_number":99,"context_line":"      jobs:"},{"line_number":100,"context_line":"        # Please try to keep this list of job names sorted alphabetically."},{"line_number":101,"context_line":"        - nova-lvm"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_00a596a1","line":100,"in_reply_to":"5f93b717_773c67e0","updated":"2018-02-02 16:18:12.000000000","message":"I can move the comment.","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"}],"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6c8eb123c14ca5d31e5a79d212f364221f1a5841","unresolved":false,"context_lines":[{"line_number":10,"context_line":"volume multiattach compute API tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This configures devstack to enable tempest for volume multiattach"},{"line_number":13,"context_line":"support and disables the Pike UCA since we need qemu\u003c2.10 for"},{"line_number":14,"context_line":"libvirt to work with multiattach volumes."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Depends on the following devstack patch to add the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f93b717_c82db1fe","line":13,"range":{"start_line":13,"start_character":48,"end_line":13,"end_character":57},"updated":"2018-02-01 16:48:55.000000000","message":"qemu\u003e\u003d2.10 or qemu!\u003d2.10?","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3997f5b1931472cffde95c71ef571373dc689834","unresolved":false,"context_lines":[{"line_number":10,"context_line":"volume multiattach compute API tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This configures devstack to enable tempest for volume multiattach"},{"line_number":13,"context_line":"support and disables the Pike UCA since we need qemu\u003c2.10 for"},{"line_number":14,"context_line":"libvirt to work with multiattach volumes."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Depends on the following devstack patch to add the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f93b717_1cef5e1e","line":13,"range":{"start_line":13,"start_character":48,"end_line":13,"end_character":57},"in_reply_to":"5f93b717_c82db1fe","updated":"2018-02-01 16:58:59.000000000","message":"Huh? The Pike UCA has qemu 2.10 which adds a change such that you can\u0027t do shared disks. That\u0027s fixed in libvirt 3.10, which we don\u0027t have in the Pike UCA. So we go with what we have which is QEMU\u003c2.10.","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e38ea08707114bede8ee6e6324fc5fbd4b9ea3ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5f93b717_7c79c2c5","line":39,"updated":"2018-02-01 17:29:11.000000000","message":"Related-bug would be helpful, I guess?","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"}],"playbooks/legacy/nova-multiattach/run.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b9159d3f5189e4f865e2f2b8ab9257b082dde3f7","unresolved":false,"context_lines":[{"line_number":42,"context_line":"          set -e"},{"line_number":43,"context_line":"          set -x"},{"line_number":44,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"},{"line_number":45,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":46,"context_line":"          export BRANCH_OVERRIDE\u003ddefault"},{"line_number":47,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":48,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f96bb07_76bbb871","line":45,"updated":"2018-01-12 15:07:13.000000000","message":"missing\n\nexport DEVSTACK_GATE_TEMPEST_FULL\u003d1","commit_id":"1b85edda7fbdbcc067aa1a27f9442080de1ac860"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1d7dd874a86a168c7beaca65109bf6814afb444a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"          # Yes we want to run Tempest."},{"line_number":46,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":47,"context_line":"          # Run the full suite of non-slow Tempest API and scenario tests."},{"line_number":48,"context_line":"          export DEVSTACK_GATE_TEMPEST_FULL\u003d1"},{"line_number":49,"context_line":"          export BRANCH_OVERRIDE\u003ddefault"},{"line_number":50,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":51,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f96bb07_b9c133e7","line":48,"range":{"start_line":48,"start_character":17,"end_line":48,"end_character":43},"updated":"2018-01-12 15:43:52.000000000","message":"To save time for this job, we should consider using DEVSTACK_GATE_TEMPEST_REGEX and provide a custom regex to only run the multiattach tests we care about, which so far are only in tempest.api.compute.volumes.test_attach_volume.\n\nThe downside is if new tests are added to tempest for multiattach support, like for swap volume testing, we\u0027d have to remember to adjust the regex. We could at least just run tempest.api.compute tests?\n\nAlso, what if Cinder adds tests for multiattach on the volumes API side for this? Then they need to update the job definition within nova...but we could cross that bridge when we need to.","commit_id":"0e8871ba42d3fc30f40af86c6ac241b19be2f2bf"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"092bc07c5700f0d6bd0281433e7abae53fc76e0f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"          # Yes we want to run Tempest."},{"line_number":46,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":47,"context_line":"          # Run the full suite of non-slow Tempest API and scenario tests."},{"line_number":48,"context_line":"          export DEVSTACK_GATE_TEMPEST_FULL\u003d1"},{"line_number":49,"context_line":"          export BRANCH_OVERRIDE\u003ddefault"},{"line_number":50,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":51,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f96bb07_9f3777b1","line":48,"range":{"start_line":48,"start_character":17,"end_line":48,"end_character":43},"in_reply_to":"7f96bb07_b9c133e7","updated":"2018-01-12 16:34:35.000000000","message":"The tempest.api.compute tests sound like a good compromise to me at this stage. We can look into Cinder, etc. when we need to.","commit_id":"0e8871ba42d3fc30f40af86c6ac241b19be2f2bf"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"979293e5bb7d36b9bfb94b146830567422132e1c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"},{"line_number":45,"context_line":"          # Yes we want to run Tempest."},{"line_number":46,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":47,"context_line":"          # Only run compute API tests; note that this will need to"},{"line_number":48,"context_line":"          # be updated if multiattach scenario tests are ever added."},{"line_number":49,"context_line":"          export DEVSTACK_GATE_TEMPEST_REGEX\u003d\"api.compute\""},{"line_number":50,"context_line":"          export BRANCH_OVERRIDE\u003ddefault"},{"line_number":51,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":52,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f93b717_ed663a52","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":58},"updated":"2018-01-25 09:27:10.000000000","message":"or even multi-attach tests ? but that can lead to stale this list and asking to update each time test is added related to multiattach.","commit_id":"ee743d3bd0ec9a16b7323b075378069bec777275"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f9a11dc2ed43715c699a42847f351c7a30045d5d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"},{"line_number":45,"context_line":"          # Yes we want to run Tempest."},{"line_number":46,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":47,"context_line":"          # Only run compute API tests; note that this will need to"},{"line_number":48,"context_line":"          # be updated if multiattach scenario tests are ever added."},{"line_number":49,"context_line":"          export DEVSTACK_GATE_TEMPEST_REGEX\u003d\"api.compute\""},{"line_number":50,"context_line":"          export BRANCH_OVERRIDE\u003ddefault"},{"line_number":51,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":52,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f93b717_d5b17291","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":58},"in_reply_to":"5f93b717_bb914355","updated":"2018-01-26 00:38:15.000000000","message":"yea, i was thinking to only add multiattach tests not all compite.api but thats too much overhead i think. looks good to me and update it if any tests outside compute.api","commit_id":"ee743d3bd0ec9a16b7323b075378069bec777275"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"89311713b2444bc978baed11cdef9f5f4ca32408","unresolved":false,"context_lines":[{"line_number":44,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"},{"line_number":45,"context_line":"          # Yes we want to run Tempest."},{"line_number":46,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":47,"context_line":"          # Only run compute API tests; note that this will need to"},{"line_number":48,"context_line":"          # be updated if multiattach scenario tests are ever added."},{"line_number":49,"context_line":"          export DEVSTACK_GATE_TEMPEST_REGEX\u003d\"api.compute\""},{"line_number":50,"context_line":"          export BRANCH_OVERRIDE\u003ddefault"},{"line_number":51,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":52,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f93b717_bb914355","line":49,"range":{"start_line":47,"start_character":0,"end_line":49,"end_character":58},"in_reply_to":"5f93b717_ed663a52","updated":"2018-01-25 15:35:38.000000000","message":"I\u0027m not sure what your question is. Yes I realize this is rigid and we\u0027d have to update this if/when new multiattach tests are added outside of the tempest.api.compute tree, but that\u0027s a known compromise for now to avoid adding a new tempest-full job when we really only care to run a handful of tests.","commit_id":"ee743d3bd0ec9a16b7323b075378069bec777275"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6c8eb123c14ca5d31e5a79d212f364221f1a5841","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5f93b717_a8d2a5cf","updated":"2018-02-01 16:48:55.000000000","message":"You can view the meaningful changes for this via:\n\n  diff playbooks/legacy/nova-lvm/run.yaml playbooks/legacy/nova-multiattach/run.yaml\n\nFrom that, you can see some the following changes:\n\n- Add the following to local.conf\n\n    ENABLE_VOLUME_MULTIATTACH\u003dTrue\n    ENABLE_VOLUME_MULTIATTACH\u003dTrue\n\n- Only run tempest tests using the following regex:\n\n    \"api.compute\"\n\nThe \u0027DEVSTACK_GATE_SETTINGS\u0027 option is removed, but that makes sense since that option allows you to define \"a path to a file to source after the environment has been set up. This is useful for projects to be able to set custom environment variables from a file in their project instead of maintaining them in project-config.\" Given that we\u0027re using project configuration here, that should drop.","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4afa739f2d2b808c5533c2c8b97854dcf4cf02e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5f93b717_1710824d","in_reply_to":"5f93b717_a8d2a5cf","updated":"2018-02-02 14:19:17.000000000","message":"\u003e You can view the meaningful changes for this via:\n \u003e \n \u003e diff playbooks/legacy/nova-lvm/run.yaml playbooks/legacy/nova-multiattach/run.yaml\n \u003e \n \u003e From that, you can see some the following changes:\n \u003e \n \u003e - Add the following to local.conf\n \u003e \n \u003e ENABLE_VOLUME_MULTIATTACH\u003dTrue\n \u003e ENABLE_VOLUME_MULTIATTACH\u003dTrue\n\nYou mean:\nENABLE_UBUNTU_CLOUD_ARCHIVE\u003dFalse","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4afa739f2d2b808c5533c2c8b97854dcf4cf02e7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"          # Only run compute API tests; note that this will need to"},{"line_number":48,"context_line":"          # be updated if multiattach scenario tests are ever added."},{"line_number":49,"context_line":"          export DEVSTACK_GATE_TEMPEST_REGEX\u003d\"api.compute\""},{"line_number":50,"context_line":"          export BRANCH_OVERRIDE\u003ddefault"},{"line_number":51,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":52,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":53,"context_line":"          fi"},{"line_number":54,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"},{"line_number":55,"context_line":"          ./safe-devstack-vm-gate-wrap.sh"},{"line_number":56,"context_line":"        executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_d743fa3d","line":53,"range":{"start_line":50,"start_character":0,"end_line":53,"end_character":12},"updated":"2018-02-02 14:19:17.000000000","message":"These lines seems bogus to me. This way L52 will never run.","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17c4b126cc5f0945bf98cc0b4d2e17062546a22b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"          # Only run compute API tests; note that this will need to"},{"line_number":48,"context_line":"          # be updated if multiattach scenario tests are ever added."},{"line_number":49,"context_line":"          export DEVSTACK_GATE_TEMPEST_REGEX\u003d\"api.compute\""},{"line_number":50,"context_line":"          export BRANCH_OVERRIDE\u003ddefault"},{"line_number":51,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":52,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":53,"context_line":"          fi"},{"line_number":54,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"},{"line_number":55,"context_line":"          ./safe-devstack-vm-gate-wrap.sh"},{"line_number":56,"context_line":"        executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_a01f026a","line":53,"range":{"start_line":50,"start_character":0,"end_line":53,"end_character":12},"in_reply_to":"5f93b717_007916c6","updated":"2018-02-02 16:37:20.000000000","message":"Oh right, yeah. I think we can just remove this entire block about branch overrides.","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9826b8704c0a05d6ad5d9baf67413941de3a44cd","unresolved":false,"context_lines":[{"line_number":47,"context_line":"          # Only run compute API tests; note that this will need to"},{"line_number":48,"context_line":"          # be updated if multiattach scenario tests are ever added."},{"line_number":49,"context_line":"          export DEVSTACK_GATE_TEMPEST_REGEX\u003d\"api.compute\""},{"line_number":50,"context_line":"          export BRANCH_OVERRIDE\u003ddefault"},{"line_number":51,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":52,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":53,"context_line":"          fi"},{"line_number":54,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"},{"line_number":55,"context_line":"          ./safe-devstack-vm-gate-wrap.sh"},{"line_number":56,"context_line":"        executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_ab1a836b","line":53,"range":{"start_line":50,"start_character":0,"end_line":53,"end_character":12},"in_reply_to":"5f93b717_a01f026a","updated":"2018-02-02 16:38:51.000000000","message":"Let\u0027s do that in a follow up as the jobs works as is already.","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fa0f877811c09b6d789863a8091807fbd39f3c32","unresolved":false,"context_lines":[{"line_number":47,"context_line":"          # Only run compute API tests; note that this will need to"},{"line_number":48,"context_line":"          # be updated if multiattach scenario tests are ever added."},{"line_number":49,"context_line":"          export DEVSTACK_GATE_TEMPEST_REGEX\u003d\"api.compute\""},{"line_number":50,"context_line":"          export BRANCH_OVERRIDE\u003ddefault"},{"line_number":51,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":52,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":53,"context_line":"          fi"},{"line_number":54,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"},{"line_number":55,"context_line":"          ./safe-devstack-vm-gate-wrap.sh"},{"line_number":56,"context_line":"        executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_e0be6aac","line":53,"range":{"start_line":50,"start_character":0,"end_line":53,"end_character":12},"in_reply_to":"5f93b717_d743fa3d","updated":"2018-02-02 16:18:12.000000000","message":"This is a carry over for legacy jobs from project-config jobs using devstack-gate, I\u0027m not sure what ever set those, but if the assertion is that this is bogus because now that the job is defined within nova, we have control over what would be setting the variables, and since nothing is setting BRANCH_OVERRIDE we don\u0027t need it, I can get behind that and remove this.","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6023ba8c8ebe64bf4019949a86a0d733dc1a60fa","unresolved":false,"context_lines":[{"line_number":47,"context_line":"          # Only run compute API tests; note that this will need to"},{"line_number":48,"context_line":"          # be updated if multiattach scenario tests are ever added."},{"line_number":49,"context_line":"          export DEVSTACK_GATE_TEMPEST_REGEX\u003d\"api.compute\""},{"line_number":50,"context_line":"          export BRANCH_OVERRIDE\u003ddefault"},{"line_number":51,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":52,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":53,"context_line":"          fi"},{"line_number":54,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"},{"line_number":55,"context_line":"          ./safe-devstack-vm-gate-wrap.sh"},{"line_number":56,"context_line":"        executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f93b717_007916c6","line":53,"range":{"start_line":50,"start_character":0,"end_line":53,"end_character":12},"in_reply_to":"5f93b717_e0be6aac","updated":"2018-02-02 16:35:18.000000000","message":"I think we we move this into nova tree the we are responsible to understand and maintain this. \n\nMy assertion is that L50 sets BRANCH_OVERRIDE to \u0027default\u0027 therefore the condition in L51 will never be True. This means either we keep L50 and remove L51-53 (as L52 never called) or remove L50 and keep L51-53 (as somebody might set BRANCH_OVERRIDE in the env)\n\nI don\u0027t know which one we need here.","commit_id":"862c6fb794f918bd22835a1d9c492cd97e1f5091"}]}