)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"365677be16c82857952434a38a8eb1f58e3222e6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"each time on capacity check from the placement_api side."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"When operator wants to change allocation_ratios for specific"},{"line_number":23,"context_line":"compute he updates the config. This change needs to be notified"},{"line_number":24,"context_line":"and also populated. This commit moves this update to _get_from_db()"},{"line_number":25,"context_line":"method - to be more visible."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I99d6231b968db5b12a6fa6bd1c257996f8f6faff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f96bb07_34288895","line":24,"range":{"start_line":23,"start_character":31,"end_line":24,"end_character":19},"updated":"2018-01-24 10:22:25.000000000","message":"I don\u0027t really understand what you mean here?","commit_id":"af8121f49ca2fa6045ece7a76209e93549802e4e"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"a91c0434921b4356b01409584578222d9c0b178a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"each time on capacity check from the placement_api side."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"When operator wants to change allocation_ratios for specific"},{"line_number":23,"context_line":"compute he updates the config. This change needs to be notified"},{"line_number":24,"context_line":"and also populated. This commit moves this update to _get_from_db()"},{"line_number":25,"context_line":"method - to be more visible."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I99d6231b968db5b12a6fa6bd1c257996f8f6faff"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f93b717_97130967","line":24,"range":{"start_line":23,"start_character":31,"end_line":24,"end_character":19},"in_reply_to":"7f96bb07_34288895","updated":"2018-01-25 08:35:17.000000000","message":"Ok I updated the commit message to be more clean. Thx","commit_id":"af8121f49ca2fa6045ece7a76209e93549802e4e"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"c6a46cd35711bcaef3a666ad3b4828247b274786","unresolved":false,"context_lines":[{"line_number":582,"context_line":"            context,"},{"line_number":583,"context_line":"            cpu_allocation_ratio\u003dself.cpu_allocation_ratio,"},{"line_number":584,"context_line":"            ram_allocation_ratio\u003dself.ram_allocation_ratio,"},{"line_number":585,"context_line":"            disk_allocation_ratio\u003dself.ram_allocation_ratio)"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"        cn.host \u003d self.host"},{"line_number":588,"context_line":"        self._copy_resources(cn, resources)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_7c9c830d","line":585,"range":{"start_line":585,"start_character":39,"end_line":585,"end_character":59},"updated":"2018-02-12 08:37:28.000000000","message":"disk_allocation_ratio!!!\n... Any chance to update the tests for resource tracker?","commit_id":"15f156e44246c4bf90734242566f10c1b04dc16d"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"975af888ab564857e87070be227a8125156d890d","unresolved":false,"context_lines":[{"line_number":582,"context_line":"            context,"},{"line_number":583,"context_line":"            cpu_allocation_ratio\u003dself.cpu_allocation_ratio,"},{"line_number":584,"context_line":"            ram_allocation_ratio\u003dself.ram_allocation_ratio,"},{"line_number":585,"context_line":"            disk_allocation_ratio\u003dself.ram_allocation_ratio)"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"        cn.host \u003d self.host"},{"line_number":588,"context_line":"        self._copy_resources(cn, resources)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f9dbf25_670d7d36","line":585,"range":{"start_line":585,"start_character":39,"end_line":585,"end_character":59},"in_reply_to":"3fa0c359_7c9c830d","updated":"2018-02-27 16:38:02.000000000","message":"Related tests validates if expected object is same as final one and nothing has been change in \u0027final view\u0027.\n\nWe only moved this update to be done during object initialization instead after it.","commit_id":"15f156e44246c4bf90734242566f10c1b04dc16d"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e6e778ec99a61c18741ccdc4e56671aa0cb5d245","unresolved":false,"context_lines":[{"line_number":582,"context_line":"            context,"},{"line_number":583,"context_line":"            cpu_allocation_ratio\u003dself.cpu_allocation_ratio,"},{"line_number":584,"context_line":"            ram_allocation_ratio\u003dself.ram_allocation_ratio,"},{"line_number":585,"context_line":"            disk_allocation_ratio\u003dself.ram_allocation_ratio)"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"        cn.host \u003d self.host"},{"line_number":588,"context_line":"        self._copy_resources(cn, resources)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f9dbf25_4a716be0","line":585,"range":{"start_line":585,"start_character":39,"end_line":585,"end_character":59},"in_reply_to":"3fa0c359_7c9c830d","updated":"2018-02-27 14:27:39.000000000","message":"hey, thanks for that catch! Im looking for any place that I can check this initialization.","commit_id":"15f156e44246c4bf90734242566f10c1b04dc16d"}],"nova/conf/compute.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"365677be16c82857952434a38a8eb1f58e3222e6","unresolved":false,"context_lines":[{"line_number":454,"context_line":"available physical disk, which can be useful for more"},{"line_number":455,"context_line":"efficiently packing instances created with images that do not"},{"line_number":456,"context_line":"use the entire virtual disk, such as sparse or compressed"},{"line_number":457,"context_line":"images. It can be set to a value between 0.0 and 1.0 in order"},{"line_number":458,"context_line":"to preserve a percentage of the disk for uses other than"},{"line_number":459,"context_line":"instances."},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"NOTE: As of the 16.0.0 Pike release, this configuration option is ignored"},{"line_number":462,"context_line":"for the ironic.IronicDriver compute driver and is hardcoded to 1.0."}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_37164a4b","line":459,"range":{"start_line":457,"start_character":8,"end_line":459,"end_character":10},"updated":"2018-01-24 10:22:25.000000000","message":"not related to this patch, but at some point we may wish to indicate that \u0027reserved\u0027 is also useful for this.","commit_id":"af8121f49ca2fa6045ece7a76209e93549802e4e"}],"nova/objects/compute_node.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"365677be16c82857952434a38a8eb1f58e3222e6","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        for key in fields:"},{"line_number":176,"context_line":"            value \u003d db_compute[key]"},{"line_number":177,"context_line":"            # NOTE(mjozefcz): Check if operator changed allocation ratios in"},{"line_number":178,"context_line":"            # configuration files. If so - apply that change."},{"line_number":179,"context_line":"            if (key \u003d\u003d \u0027cpu_allocation_ratio\u0027 or key \u003d\u003d \u0027ram_allocation_ratio\u0027"},{"line_number":180,"context_line":"                or key \u003d\u003d \u0027disk_allocation_ratio\u0027):"},{"line_number":181,"context_line":"                # Take value from configuration"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_1760eece","line":178,"updated":"2018-01-24 10:22:25.000000000","message":"It took me a while to understand this mechanism but once I did ✔","commit_id":"af8121f49ca2fa6045ece7a76209e93549802e4e"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"a91c0434921b4356b01409584578222d9c0b178a","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        for key in fields:"},{"line_number":176,"context_line":"            value \u003d db_compute[key]"},{"line_number":177,"context_line":"            # NOTE(mjozefcz): Check if operator changed allocation ratios in"},{"line_number":178,"context_line":"            # configuration files. If so - apply that change."},{"line_number":179,"context_line":"            if (key \u003d\u003d \u0027cpu_allocation_ratio\u0027 or key \u003d\u003d \u0027ram_allocation_ratio\u0027"},{"line_number":180,"context_line":"                or key \u003d\u003d \u0027disk_allocation_ratio\u0027):"},{"line_number":181,"context_line":"                # Take value from configuration"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f93b717_aa0d7838","line":178,"in_reply_to":"7f96bb07_1760eece","updated":"2018-01-25 08:35:17.000000000","message":":)!","commit_id":"af8121f49ca2fa6045ece7a76209e93549802e4e"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"efbb5df331bbc8b1f97db5b805e4b07d91f7d6a3","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            value \u003d db_compute[key]"},{"line_number":177,"context_line":"            # NOTE(mjozefcz): Check if operator changed allocation ratios in"},{"line_number":178,"context_line":"            # configuration files. If so - apply that change."},{"line_number":179,"context_line":"            if (key \u003d\u003d \u0027cpu_allocation_ratio\u0027 or key \u003d\u003d \u0027ram_allocation_ratio\u0027"},{"line_number":180,"context_line":"                or key \u003d\u003d \u0027disk_allocation_ratio\u0027):"},{"line_number":181,"context_line":"                # Take value from configuration"},{"line_number":182,"context_line":"                value_conf \u003d getattr(CONF, key)"},{"line_number":183,"context_line":"                # If configuration is different than value taken from"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f93b717_3600a501","line":180,"range":{"start_line":179,"start_character":12,"end_line":180,"end_character":50},"updated":"2018-01-29 08:34:29.000000000","message":"if key in [\"cpu_allocation_ration\", \"ram_allocation_ration\", \"disk_allocation_issue\"]?","commit_id":"9e150a895d98428c6712726f2a9ae7bba0511529"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"2ee81c89c5649ee8c37f77766756acb61942c0e9","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            value \u003d db_compute[key]"},{"line_number":177,"context_line":"            # NOTE(mjozefcz): Check if operator changed allocation ratios in"},{"line_number":178,"context_line":"            # configuration files. If so - apply that change."},{"line_number":179,"context_line":"            if (key \u003d\u003d \u0027cpu_allocation_ratio\u0027 or key \u003d\u003d \u0027ram_allocation_ratio\u0027"},{"line_number":180,"context_line":"                or key \u003d\u003d \u0027disk_allocation_ratio\u0027):"},{"line_number":181,"context_line":"                # Take value from configuration"},{"line_number":182,"context_line":"                value_conf \u003d getattr(CONF, key)"},{"line_number":183,"context_line":"                # If configuration is different than value taken from"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f93b717_560a118a","line":180,"range":{"start_line":179,"start_character":12,"end_line":180,"end_character":50},"in_reply_to":"5f93b717_3600a501","updated":"2018-01-29 08:59:10.000000000","message":"Yes, would be better. Changed. Thx!","commit_id":"9e150a895d98428c6712726f2a9ae7bba0511529"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0dd706737dbaf9457117f12e6733b0910c5e62bd","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                # Take value from configuration"},{"line_number":182,"context_line":"                value_conf \u003d getattr(CONF, key)"},{"line_number":183,"context_line":"                # If configuration is different than value taken from"},{"line_number":184,"context_line":"                # db - operator changed it in config. Apply the change."},{"line_number":185,"context_line":"                value \u003d value_conf if value !\u003d value_conf else value"},{"line_number":186,"context_line":"            elif key \u003d\u003d \u0027mapped\u0027:"},{"line_number":187,"context_line":"                value \u003d 0 if value is None else value"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f93b717_39784dc2","line":184,"range":{"start_line":184,"start_character":23,"end_line":184,"end_character":52},"updated":"2018-01-31 16:46:49.000000000","message":"Like I said earlier, there are two possibilities :\n- either the operator changed the config value\n- or the compute node itself is running Pike but the caller of that method is running Queens (eg. a nova-scheduler service). In that case, we should make sure to use the right compute value, not the default.","commit_id":"15f156e44246c4bf90734242566f10c1b04dc16d"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"c6a46cd35711bcaef3a666ad3b4828247b274786","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            if key in [\u0027cpu_allocation_ratio\u0027, \u0027ram_allocation_ratio\u0027,"},{"line_number":180,"context_line":"                       \u0027disk_allocation_ratio\u0027]:"},{"line_number":181,"context_line":"                # Take value from configuration"},{"line_number":182,"context_line":"                value_conf \u003d getattr(CONF, key)"},{"line_number":183,"context_line":"                # If configuration is different than value taken from"},{"line_number":184,"context_line":"                # db - operator changed it in config. Apply the change."},{"line_number":185,"context_line":"                value \u003d value_conf if value !\u003d value_conf else value"},{"line_number":186,"context_line":"            elif key \u003d\u003d \u0027mapped\u0027:"},{"line_number":187,"context_line":"                value \u003d 0 if value is None else value"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa0c359_b78b041d","line":185,"range":{"start_line":182,"start_character":0,"end_line":185,"end_character":68},"updated":"2018-02-12 08:37:28.000000000","message":"I  don\u0027t fully understand @sbauza\u0027s comment, but what I can say here is that since the else of \"value !\u003d value_conf\" is \"value \u003d value_conf\", this line is the same with \"value \u003d value_conf\", thus this block can be reduced to just \"value \u003d getattr(CONF,key)\".\n\nTransforming db\u0027s 0 value to the default seems to be included in this operation since now the conf\u0027s default is changed from 0 and who reads that conf is compute nodes upgraded, no?","commit_id":"15f156e44246c4bf90734242566f10c1b04dc16d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f425f586823f00624de8c9a4b17f4a1dede762fc","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                value_conf \u003d getattr(CONF, key)"},{"line_number":183,"context_line":"                # If configuration is different than value taken from"},{"line_number":184,"context_line":"                # db - operator changed it in config. Apply the change."},{"line_number":185,"context_line":"                value \u003d value_conf if value !\u003d value_conf else value"},{"line_number":186,"context_line":"            elif key \u003d\u003d \u0027mapped\u0027:"},{"line_number":187,"context_line":"                value \u003d 0 if value is None else value"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f93b717_ae4df19a","line":185,"updated":"2018-01-31 16:13:24.000000000","message":"while I think it works great with a full Queens cloud, if we have a rolling-upgrade, old Pike nodes would still have unnormalized ratios in the DB (ie. 0.0).\n\nThere are two possibilities then :\n- I\u0027m calling the ComputeNode object from a Queens node. Since the local opt value for the ratio will be set for example to 16.0 by default (for CPU), the related field in the object will be set to 16.0. Good.\n- I\u0027m calling the ComputeNode object from a Pike node. I\u0027ll still have the old code that does the normalization so I\u0027ll continue to provide 16.0 in the case of a CPU ratio. Good too.","commit_id":"15f156e44246c4bf90734242566f10c1b04dc16d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6c76bbd3aff8f81328cbb1359ea82dd25d8aece6","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                value_conf \u003d getattr(CONF, key)"},{"line_number":183,"context_line":"                # If configuration is different than value taken from"},{"line_number":184,"context_line":"                # db - operator changed it in config. Apply the change."},{"line_number":185,"context_line":"                value \u003d value_conf if value !\u003d value_conf else value"},{"line_number":186,"context_line":"            elif key \u003d\u003d \u0027mapped\u0027:"},{"line_number":187,"context_line":"                value \u003d 0 if value is None else value"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f93b717_9db29648","line":185,"in_reply_to":"5f93b717_5923d9bd","updated":"2018-02-01 10:28:02.000000000","message":"We discussed on IRC and here are the outcomes :\nwe could possible use obj_make_compatible() to verify the object version (or asking for the compute service version) and if the ratio value is 0.0, then change it to the default.","commit_id":"15f156e44246c4bf90734242566f10c1b04dc16d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3277e333b8467cb929a5918032b4bd669fba98a5","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                value_conf \u003d getattr(CONF, key)"},{"line_number":183,"context_line":"                # If configuration is different than value taken from"},{"line_number":184,"context_line":"                # db - operator changed it in config. Apply the change."},{"line_number":185,"context_line":"                value \u003d value_conf if value !\u003d value_conf else value"},{"line_number":186,"context_line":"            elif key \u003d\u003d \u0027mapped\u0027:"},{"line_number":187,"context_line":"                value \u003d 0 if value is None else value"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f93b717_dd481e2e","line":185,"in_reply_to":"5f93b717_9db29648","updated":"2018-02-01 10:32:08.000000000","message":"Mmm, after thinking more, why should we verify the version ? Just transform 0.0 into the default value we want should be fine, that\u0027s it and remove the conditional in the next release...","commit_id":"15f156e44246c4bf90734242566f10c1b04dc16d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0dd706737dbaf9457117f12e6733b0910c5e62bd","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                value_conf \u003d getattr(CONF, key)"},{"line_number":183,"context_line":"                # If configuration is different than value taken from"},{"line_number":184,"context_line":"                # db - operator changed it in config. Apply the change."},{"line_number":185,"context_line":"                value \u003d value_conf if value !\u003d value_conf else value"},{"line_number":186,"context_line":"            elif key \u003d\u003d \u0027mapped\u0027:"},{"line_number":187,"context_line":"                value \u003d 0 if value is None else value"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5f93b717_5923d9bd","line":185,"in_reply_to":"5f93b717_ae4df19a","updated":"2018-01-31 16:46:49.000000000","message":"So, after thinking hard on that, I think we have problems with a rolling upgraded cloud with Pike compute nodes. If the Pike compute nova.conf is modified for using a specific ratio, then if we call the ComputeNode object within a Queens service for that specific Pike node, then the ratio should be the default, which is not something we want.","commit_id":"15f156e44246c4bf90734242566f10c1b04dc16d"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e6e778ec99a61c18741ccdc4e56671aa0cb5d245","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                value_conf \u003d getattr(CONF, key)"},{"line_number":183,"context_line":"                # If configuration is different than value taken from"},{"line_number":184,"context_line":"                # db - operator changed it in config. Apply the change."},{"line_number":185,"context_line":"                value \u003d value_conf if value !\u003d value_conf else value"},{"line_number":186,"context_line":"            elif key \u003d\u003d \u0027mapped\u0027:"},{"line_number":187,"context_line":"                value \u003d 0 if value is None else value"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f9dbf25_2ab73f89","line":185,"in_reply_to":"5f93b717_dd481e2e","updated":"2018-02-27 14:27:39.000000000","message":"Done - default values are now set. I also left normalization (if conditionals) - to be removed in S release.","commit_id":"15f156e44246c4bf90734242566f10c1b04dc16d"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"3ea74ba215ceda7e27c9b9a4c609c5555682c05f","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                    if value_conf \u003d\u003d 0.0 and key \u003d\u003d \u0027disk_allocation_ratio\u0027:"},{"line_number":205,"context_line":"                        # It\u0027s not specified either on the controller"},{"line_number":206,"context_line":"                        value \u003d 1.0"},{"line_number":207,"context_line":"                if value !\u003d value_conf:"},{"line_number":208,"context_line":"                    # If configuration is different than value taken from"},{"line_number":209,"context_line":"                    # db - operator changed it in config."},{"line_number":210,"context_line":"                    # Apply the change."}],"source_content_type":"text/x-python","patch_set":8,"id":"1f9dbf25_156624ef","line":207,"updated":"2018-02-27 14:33:45.000000000","message":"Sbauza: What do you think of moving it here? Instead doing it in _copy_resoures()?","commit_id":"e17003d09b92af909b0c43d54e49696b8a89a28f"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"a8da9876976ccd8892213933deb0b3abbed51300","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                    # If configuration is different than value taken from"},{"line_number":209,"context_line":"                    # db - operator changed it in config."},{"line_number":210,"context_line":"                    # Apply the change."},{"line_number":211,"context_line":"                    value \u003d value_conf"},{"line_number":212,"context_line":"            elif key \u003d\u003d \u0027mapped\u0027:"},{"line_number":213,"context_line":"                value \u003d 0 if value is None else value"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"df7087c5_7ebb77c3","line":211,"updated":"2018-03-11 04:44:12.000000000","message":"Let\u0027s consider about the case that\n\n  value \u003d None or 0.0 (from DB)\n  value_conf \u003d 0.0 (from CONF)\n\nDon\u0027t we want to catch this case to result with a non-zero allocation ratio? This block returns value \u003d 0.0 after all in that case. Did you intend value_conf @L200, L203, L206?\n\n...And if you ask me, if we after all overwrite \"value\" with \"value_conf\" then checking if the \"value\" is None(@L190) or 0.0(@L194) and checking if they have different values(@L207) sound useless to me. Why do we need them?","commit_id":"4560aaee84707a76d266626d96ef5a03dcb9a453"}],"nova/tests/unit/objects/test_compute_node.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0dd706737dbaf9457117f12e6733b0910c5e62bd","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        primitive \u003d compute.obj_to_primitive(target_version\u003d\u00271.15\u0027)"},{"line_number":533,"context_line":"        self.assertNotIn(\u0027disk_allocation_ratio\u0027, primitive)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"    def test_compat_allocation_ratios_old_compute(self):"},{"line_number":536,"context_line":"        self.flags(cpu_allocation_ratio\u003d2.0, ram_allocation_ratio\u003d3.0,"},{"line_number":537,"context_line":"                   disk_allocation_ratio\u003d0.9)"},{"line_number":538,"context_line":"        compute_dict \u003d fake_compute_node.copy()"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f93b717_940b6822","side":"PARENT","line":535,"updated":"2018-01-31 16:46:49.000000000","message":"IMHO, we should keep that test at least for making sure old Pike compute ratio values still work with Queens services using the ComputeNode object.","commit_id":"90a92d33edaea2b7411a5fd528f3159a486e1fd0"}],"releasenotes/notes/move-default-allocation-values-to-config-f31c012289383900.yaml":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"a8da9876976ccd8892213933deb0b3abbed51300","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    is 1.0 (previously 0.0) and ``cpu_allocation_ratio`` is 16.0 (previously 0.0)."},{"line_number":8,"context_line":"    Please refer to the `nova documentation"},{"line_number":9,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/configuration/config.html\u003e`_"},{"line_number":10,"context_line":"    for a detailed allocation ratio parameters explanation."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"df7087c5_9e4f6bbc","line":10,"updated":"2018-03-11 04:44:12.000000000","message":"Thank you for updating! Looks good to me.","commit_id":"4560aaee84707a76d266626d96ef5a03dcb9a453"}],"releasenotes/notes/releasenotes/notes/move-default-allocation-values-to-config-f31c012289383900.yaml":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"365677be16c82857952434a38a8eb1f58e3222e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"upgrade:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Allocation ratios default values were previusly normalized if those were"},{"line_number":4,"context_line":"    not set in configuration files for backport compatibilities reasons."},{"line_number":5,"context_line":"    The defaults are now moved to config. Default value for"},{"line_number":6,"context_line":"    ``ram_allocation_ratio`` is 1.5, ``disk_allocation_ratio`` is 1.0 and"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_37c3aa59","line":3,"range":{"start_line":3,"start_character":42,"end_line":3,"end_character":51},"updated":"2018-01-24 10:22:25.000000000","message":"previously","commit_id":"af8121f49ca2fa6045ece7a76209e93549802e4e"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"365677be16c82857952434a38a8eb1f58e3222e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"upgrade:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Allocation ratios default values were previusly normalized if those were"},{"line_number":4,"context_line":"    not set in configuration files for backport compatibilities reasons."},{"line_number":5,"context_line":"    The defaults are now moved to config. Default value for"},{"line_number":6,"context_line":"    ``ram_allocation_ratio`` is 1.5, ``disk_allocation_ratio`` is 1.0 and"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_f7c1c255","line":3,"range":{"start_line":3,"start_character":15,"end_line":3,"end_character":21},"updated":"2018-01-24 10:22:25.000000000","message":"ratio","commit_id":"af8121f49ca2fa6045ece7a76209e93549802e4e"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"365677be16c82857952434a38a8eb1f58e3222e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"upgrade:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Allocation ratios default values were previusly normalized if those were"},{"line_number":4,"context_line":"    not set in configuration files for backport compatibilities reasons."},{"line_number":5,"context_line":"    The defaults are now moved to config. Default value for"},{"line_number":6,"context_line":"    ``ram_allocation_ratio`` is 1.5, ``disk_allocation_ratio`` is 1.0 and"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_77cdb283","line":3,"range":{"start_line":3,"start_character":66,"end_line":3,"end_character":71},"updated":"2018-01-24 10:22:25.000000000","message":"they","commit_id":"af8121f49ca2fa6045ece7a76209e93549802e4e"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"a91c0434921b4356b01409584578222d9c0b178a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"upgrade:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Allocation ratios default values were previusly normalized if those were"},{"line_number":4,"context_line":"    not set in configuration files for backport compatibilities reasons."},{"line_number":5,"context_line":"    The defaults are now moved to config. Default value for"},{"line_number":6,"context_line":"    ``ram_allocation_ratio`` is 1.5, ``disk_allocation_ratio`` is 1.0 and"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f93b717_0a634cde","line":3,"range":{"start_line":3,"start_character":42,"end_line":3,"end_character":51},"in_reply_to":"7f96bb07_37c3aa59","updated":"2018-01-25 08:35:17.000000000","message":"+1, thx","commit_id":"af8121f49ca2fa6045ece7a76209e93549802e4e"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"a91c0434921b4356b01409584578222d9c0b178a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"upgrade:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Allocation ratios default values were previusly normalized if those were"},{"line_number":4,"context_line":"    not set in configuration files for backport compatibilities reasons."},{"line_number":5,"context_line":"    The defaults are now moved to config. Default value for"},{"line_number":6,"context_line":"    ``ram_allocation_ratio`` is 1.5, ``disk_allocation_ratio`` is 1.0 and"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f93b717_ca9a44c4","line":3,"range":{"start_line":3,"start_character":66,"end_line":3,"end_character":71},"in_reply_to":"7f96bb07_77cdb283","updated":"2018-01-25 08:35:17.000000000","message":"+1, thx","commit_id":"af8121f49ca2fa6045ece7a76209e93549802e4e"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"a91c0434921b4356b01409584578222d9c0b178a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"upgrade:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Allocation ratios default values were previusly normalized if those were"},{"line_number":4,"context_line":"    not set in configuration files for backport compatibilities reasons."},{"line_number":5,"context_line":"    The defaults are now moved to config. Default value for"},{"line_number":6,"context_line":"    ``ram_allocation_ratio`` is 1.5, ``disk_allocation_ratio`` is 1.0 and"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f93b717_aaa9f8df","line":3,"range":{"start_line":3,"start_character":15,"end_line":3,"end_character":21},"in_reply_to":"7f96bb07_f7c1c255","updated":"2018-01-25 08:35:17.000000000","message":"+1, thx","commit_id":"af8121f49ca2fa6045ece7a76209e93549802e4e"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"365677be16c82857952434a38a8eb1f58e3222e6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"upgrade:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Allocation ratios default values were previusly normalized if those were"},{"line_number":4,"context_line":"    not set in configuration files for backport compatibilities reasons."},{"line_number":5,"context_line":"    The defaults are now moved to config. Default value for"},{"line_number":6,"context_line":"    ``ram_allocation_ratio`` is 1.5, ``disk_allocation_ratio`` is 1.0 and"},{"line_number":7,"context_line":"    ``cpu_allocation_ratio`` is 16.0. For all of those ratios minimum value"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_f7a6a2c1","line":4,"range":{"start_line":4,"start_character":48,"end_line":4,"end_character":63},"updated":"2018-01-24 10:22:25.000000000","message":"compatibility\n\nAlso, I would adjust the sentence so that \"For backport compatibility reasons, allocation ratio default values...\" is the order","commit_id":"af8121f49ca2fa6045ece7a76209e93549802e4e"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"a91c0434921b4356b01409584578222d9c0b178a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"upgrade:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Allocation ratios default values were previusly normalized if those were"},{"line_number":4,"context_line":"    not set in configuration files for backport compatibilities reasons."},{"line_number":5,"context_line":"    The defaults are now moved to config. Default value for"},{"line_number":6,"context_line":"    ``ram_allocation_ratio`` is 1.5, ``disk_allocation_ratio`` is 1.0 and"},{"line_number":7,"context_line":"    ``cpu_allocation_ratio`` is 16.0. For all of those ratios minimum value"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f93b717_aa457819","line":4,"range":{"start_line":4,"start_character":48,"end_line":4,"end_character":63},"in_reply_to":"7f96bb07_f7a6a2c1","updated":"2018-01-25 08:35:17.000000000","message":"Hm, You\u0027re right. Would be more correct :) thanks, done","commit_id":"af8121f49ca2fa6045ece7a76209e93549802e4e"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"365677be16c82857952434a38a8eb1f58e3222e6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    The defaults are now moved to config. Default value for"},{"line_number":6,"context_line":"    ``ram_allocation_ratio`` is 1.5, ``disk_allocation_ratio`` is 1.0 and"},{"line_number":7,"context_line":"    ``cpu_allocation_ratio`` is 16.0. For all of those ratios minimum value"},{"line_number":8,"context_line":"    has been also defined as 0.1."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_5795163f","line":8,"range":{"start_line":8,"start_character":13,"end_line":8,"end_character":18},"updated":"2018-01-24 10:22:25.000000000","message":"you can leave out the \"also\"","commit_id":"af8121f49ca2fa6045ece7a76209e93549802e4e"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"a91c0434921b4356b01409584578222d9c0b178a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    The defaults are now moved to config. Default value for"},{"line_number":6,"context_line":"    ``ram_allocation_ratio`` is 1.5, ``disk_allocation_ratio`` is 1.0 and"},{"line_number":7,"context_line":"    ``cpu_allocation_ratio`` is 16.0. For all of those ratios minimum value"},{"line_number":8,"context_line":"    has been also defined as 0.1."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f93b717_ca832456","line":8,"range":{"start_line":8,"start_character":13,"end_line":8,"end_character":18},"in_reply_to":"7f96bb07_5795163f","updated":"2018-01-25 08:35:17.000000000","message":"Ok, done","commit_id":"af8121f49ca2fa6045ece7a76209e93549802e4e"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"c6a46cd35711bcaef3a666ad3b4828247b274786","unresolved":false,"context_lines":[{"line_number":1,"context_line":"upgrade:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    For backport compatibility reasons, allocation ratio default values"},{"line_number":4,"context_line":"    were previously normalized if they were not set in configuration files."},{"line_number":5,"context_line":"    The defaults are now moved to config. Default value for"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa0c359_89a11049","line":2,"updated":"2018-02-12 08:37:28.000000000","message":"Good to update to let readers know the following points.\n- Before the change, what value was the default and minimum value in the configuration?\n- Before the change, when and to what value were allocation_ratios overwritten if the value had been set to 0?","commit_id":"15f156e44246c4bf90734242566f10c1b04dc16d"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"975af888ab564857e87070be227a8125156d890d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"upgrade:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    For backport compatibility reasons, allocation ratio default values"},{"line_number":4,"context_line":"    were previously normalized if they were not set in configuration files."},{"line_number":5,"context_line":"    The defaults are now moved to config. Default value for"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f9dbf25_47b5e1ed","line":2,"in_reply_to":"3fa0c359_89a11049","updated":"2018-02-27 16:38:02.000000000","message":"* Previous parameter values: added, thanks!\n\n* What if parameter is 0.0 - its explained in doc reference, so I think its not needed to mention it also here. Information about normalization is enough (my opinion).","commit_id":"15f156e44246c4bf90734242566f10c1b04dc16d"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"c6a46cd35711bcaef3a666ad3b4828247b274786","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    The defaults are now moved to config. Default value for"},{"line_number":6,"context_line":"    ``ram_allocation_ratio`` is 1.5, ``disk_allocation_ratio`` is 1.0 and"},{"line_number":7,"context_line":"    ``cpu_allocation_ratio`` is 16.0. For all of those ratios minimum value"},{"line_number":8,"context_line":"    has been defined as 0.1."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa0c359_69e4c4e0","line":8,"updated":"2018-02-12 08:37:28.000000000","message":"A link reference to \"Configuration Options\"[1] in configuration guide might help readers.\n\n[1] https://docs.openstack.org/nova/latest/configuration/config.html","commit_id":"15f156e44246c4bf90734242566f10c1b04dc16d"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"975af888ab564857e87070be227a8125156d890d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    The defaults are now moved to config. Default value for"},{"line_number":6,"context_line":"    ``ram_allocation_ratio`` is 1.5, ``disk_allocation_ratio`` is 1.0 and"},{"line_number":7,"context_line":"    ``cpu_allocation_ratio`` is 16.0. For all of those ratios minimum value"},{"line_number":8,"context_line":"    has been defined as 0.1."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f9dbf25_e7174ded","line":8,"in_reply_to":"3fa0c359_69e4c4e0","updated":"2018-02-27 16:38:02.000000000","message":"Link added. Thanks for pointing that because its kind a mess here.","commit_id":"15f156e44246c4bf90734242566f10c1b04dc16d"}]}