)]}'
{".zuul.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0420a619d70670594c7f5c5faa3bcdba03dd993c","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- job:"},{"line_number":30,"context_line":"    name: nova-tox-functional"},{"line_number":31,"context_line":"    parent: openstack-tox-functional"},{"line_number":32,"context_line":"    description: |"},{"line_number":33,"context_line":"      Run tox-based functional tests for an OpenStack Nova project with Nova"},{"line_number":34,"context_line":"      specific irrelevant-files list. Uses tox with the ``functional``"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f96bb07_9906b786","line":31,"updated":"2018-01-12 15:35:12.000000000","message":"Question is, will this mean that zuul doesn\u0027t also run openstack-tox-functional on nova changes, because that would be redundant.","commit_id":"65485480bc37fae86873d2619bd9eebb0063553f"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"ad39edbf9c9ec7c10d2a9b301d6a644acdc44923","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- job:"},{"line_number":30,"context_line":"    name: nova-tox-functional"},{"line_number":31,"context_line":"    parent: openstack-tox-functional"},{"line_number":32,"context_line":"    description: |"},{"line_number":33,"context_line":"      Run tox-based functional tests for an OpenStack Nova project with Nova"},{"line_number":34,"context_line":"      specific irrelevant-files list. Uses tox with the ``functional``"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f96bb07_19db87ed","line":31,"in_reply_to":"7f96bb07_9906b786","updated":"2018-01-12 15:41:00.000000000","message":"It will run it since openstack-tox-functional is defined in project-config. parent is inheritance.\n\nso, if you merge this, remove the openstack-tox-functional from project-config...","commit_id":"65485480bc37fae86873d2619bd9eebb0063553f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0420a619d70670594c7f5c5faa3bcdba03dd993c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      Run tox-based functional tests for an OpenStack Nova project with Nova"},{"line_number":34,"context_line":"      specific irrelevant-files list. Uses tox with the ``functional``"},{"line_number":35,"context_line":"      environment."},{"line_number":36,"context_line":"    irrelevant-files:"},{"line_number":37,"context_line":"      - ^.*\\.rst$"},{"line_number":38,"context_line":"      - ^api-.*$"},{"line_number":39,"context_line":"      - ^doc/source/.*$"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f96bb07_19faa774","line":36,"updated":"2018-01-12 15:35:12.000000000","message":"yup, matches project-config:\n\nhttps://github.com/openstack-infra/project-config/blob/5017c2ba472bd0439392f037036dbf198e00c137/zuul.d/projects.yaml#L10601","commit_id":"65485480bc37fae86873d2619bd9eebb0063553f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0420a619d70670594c7f5c5faa3bcdba03dd993c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    experimental:"},{"line_number":49,"context_line":"      jobs:"},{"line_number":50,"context_line":"        - nova-lvm"},{"line_number":51,"context_line":"    check:"},{"line_number":52,"context_line":"      jobs:"},{"line_number":53,"context_line":"        - nova-tox-functional"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7f96bb07_f9eedbb2","line":51,"updated":"2018-01-12 15:35:12.000000000","message":"You need the same thing for the gate queue.","commit_id":"65485480bc37fae86873d2619bd9eebb0063553f"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"efae1149fa201469fd7bdcf230c0a57f03ea2a06","unresolved":false,"context_lines":[{"line_number":25,"context_line":"      - ^tests-py3.txt$"},{"line_number":26,"context_line":"      - ^tools/.*$"},{"line_number":27,"context_line":"      - ^tox.ini$"},{"line_number":28,"context_line":"- job:"},{"line_number":29,"context_line":"    name: nova-tox-functional"},{"line_number":30,"context_line":"    parent: openstack-tox"},{"line_number":31,"context_line":"    description: |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f96bb07_bf87d361","line":28,"updated":"2018-01-12 16:30:19.000000000","message":"nit: I would add an empty line before \"-job\", also before line 44.","commit_id":"45aaac5dabd6a600ced21ed8e5f34be08f97295a"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"46bf3d93bede56fca249917c67ab4c0736a28870","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      - ^tools/.*$"},{"line_number":27,"context_line":"      - ^tox.ini$"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- job:"},{"line_number":30,"context_line":"    name: nova-tox-functional"},{"line_number":31,"context_line":"    parent: openstack-tox"},{"line_number":32,"context_line":"    description: |"},{"line_number":33,"context_line":"      Run tox-based functional tests for the OpenStack Nova project with Nova"},{"line_number":34,"context_line":"      specific irrelevant-files list. Uses tox with the ``functional``"},{"line_number":35,"context_line":"      environment."},{"line_number":36,"context_line":"    irrelevant-files:"},{"line_number":37,"context_line":"      - ^.*\\.rst$"},{"line_number":38,"context_line":"      - ^api-.*$"},{"line_number":39,"context_line":"      - ^doc/source/.*$"},{"line_number":40,"context_line":"      - ^nova/locale/.*$"},{"line_number":41,"context_line":"      - ^placement-api-ref/.*$"},{"line_number":42,"context_line":"      - ^releasenotes/.*$"},{"line_number":43,"context_line":"    vars:"},{"line_number":44,"context_line":"      tox_envlist: functional"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- job:"},{"line_number":47,"context_line":"    name: nova-tox-functional-py35"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_41bc8dba","line":44,"range":{"start_line":29,"start_character":0,"end_line":44,"end_character":29},"updated":"2018-01-15 12:13:00.000000000","message":"note: You need to backport this to other branches to use it there.","commit_id":"3f7028b154fd123b6f40fb53ebb247bd8873181d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"59ad5c93029a7e65999c966e7d016b0ae5b4c256","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      - ^tools/.*$"},{"line_number":27,"context_line":"      - ^tox.ini$"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- job:"},{"line_number":30,"context_line":"    name: nova-tox-functional"},{"line_number":31,"context_line":"    parent: openstack-tox"},{"line_number":32,"context_line":"    description: |"},{"line_number":33,"context_line":"      Run tox-based functional tests for the OpenStack Nova project with Nova"},{"line_number":34,"context_line":"      specific irrelevant-files list. Uses tox with the ``functional``"},{"line_number":35,"context_line":"      environment."},{"line_number":36,"context_line":"    irrelevant-files:"},{"line_number":37,"context_line":"      - ^.*\\.rst$"},{"line_number":38,"context_line":"      - ^api-.*$"},{"line_number":39,"context_line":"      - ^doc/source/.*$"},{"line_number":40,"context_line":"      - ^nova/locale/.*$"},{"line_number":41,"context_line":"      - ^placement-api-ref/.*$"},{"line_number":42,"context_line":"      - ^releasenotes/.*$"},{"line_number":43,"context_line":"    vars:"},{"line_number":44,"context_line":"      tox_envlist: functional"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- job:"},{"line_number":47,"context_line":"    name: nova-tox-functional-py35"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_571d2f64","line":44,"range":{"start_line":29,"start_character":0,"end_line":44,"end_character":29},"in_reply_to":"7f96bb07_41bc8dba","updated":"2018-01-15 13:03:55.000000000","message":"OK, I will do the backports as soon as this got merged. Does the project-config need to be modified per branch as well?","commit_id":"3f7028b154fd123b6f40fb53ebb247bd8873181d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"bafddbeeb5b5a6c3b2fa2f10f2c5294fca4e00d7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      - ^tools/.*$"},{"line_number":27,"context_line":"      - ^tox.ini$"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- job:"},{"line_number":30,"context_line":"    name: nova-tox-functional"},{"line_number":31,"context_line":"    parent: openstack-tox"},{"line_number":32,"context_line":"    description: |"},{"line_number":33,"context_line":"      Run tox-based functional tests for the OpenStack Nova project with Nova"},{"line_number":34,"context_line":"      specific irrelevant-files list. Uses tox with the ``functional``"},{"line_number":35,"context_line":"      environment."},{"line_number":36,"context_line":"    irrelevant-files:"},{"line_number":37,"context_line":"      - ^.*\\.rst$"},{"line_number":38,"context_line":"      - ^api-.*$"},{"line_number":39,"context_line":"      - ^doc/source/.*$"},{"line_number":40,"context_line":"      - ^nova/locale/.*$"},{"line_number":41,"context_line":"      - ^placement-api-ref/.*$"},{"line_number":42,"context_line":"      - ^releasenotes/.*$"},{"line_number":43,"context_line":"    vars:"},{"line_number":44,"context_line":"      tox_envlist: functional"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- job:"},{"line_number":47,"context_line":"    name: nova-tox-functional-py35"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_3788a36f","line":44,"range":{"start_line":29,"start_character":0,"end_line":44,"end_character":29},"in_reply_to":"7f96bb07_571d2f64","updated":"2018-01-15 13:05:15.000000000","message":"project-config is branchless.","commit_id":"3f7028b154fd123b6f40fb53ebb247bd8873181d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"46bf3d93bede56fca249917c67ab4c0736a28870","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      Run tox-based functional tests for the OpenStack Nova project"},{"line_number":51,"context_line":"      under cPython version 3.5. with Nova specific irrelevant-files list."},{"line_number":52,"context_line":"      Uses tox with the ``functional-py35`` environment."},{"line_number":53,"context_line":"    branches: master"},{"line_number":54,"context_line":"    irrelevant-files:"},{"line_number":55,"context_line":"      - ^.*\\.rst$"},{"line_number":56,"context_line":"      - ^api-.*$"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_21de2111","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":20},"updated":"2018-01-15 12:13:00.000000000","message":"this is implicit for nova, you can remove it. To run it on older branches, you would need to backport it.\n\nLet\u0027s remove so that it runs once queens get branched.","commit_id":"3f7028b154fd123b6f40fb53ebb247bd8873181d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"59ad5c93029a7e65999c966e7d016b0ae5b4c256","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      Run tox-based functional tests for the OpenStack Nova project"},{"line_number":51,"context_line":"      under cPython version 3.5. with Nova specific irrelevant-files list."},{"line_number":52,"context_line":"      Uses tox with the ``functional-py35`` environment."},{"line_number":53,"context_line":"    branches: master"},{"line_number":54,"context_line":"    irrelevant-files:"},{"line_number":55,"context_line":"      - ^.*\\.rst$"},{"line_number":56,"context_line":"      - ^api-.*$"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_372c2398","line":53,"range":{"start_line":53,"start_character":2,"end_line":53,"end_character":20},"in_reply_to":"7f96bb07_21de2111","updated":"2018-01-15 13:03:55.000000000","message":"Sure. Done.","commit_id":"3f7028b154fd123b6f40fb53ebb247bd8873181d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"03cf65fefb65aae41b396449482cb2a2d299def1","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- job:"},{"line_number":30,"context_line":"    name: nova-tox-functional"},{"line_number":31,"context_line":"    parent: openstack-tox"},{"line_number":32,"context_line":"    description: |"},{"line_number":33,"context_line":"      Run tox-based functional tests for the OpenStack Nova project with Nova"},{"line_number":34,"context_line":"      specific irrelevant-files list. Uses tox with the ``functional``"},{"line_number":35,"context_line":"      environment."},{"line_number":36,"context_line":"    irrelevant-files:"},{"line_number":37,"context_line":"      - ^.*\\.rst$"},{"line_number":38,"context_line":"      - ^api-.*$"},{"line_number":39,"context_line":"      - ^doc/source/.*$"},{"line_number":40,"context_line":"      - ^nova/locale/.*$"},{"line_number":41,"context_line":"      - ^placement-api-ref/.*$"},{"line_number":42,"context_line":"      - ^releasenotes/.*$"},{"line_number":43,"context_line":"    vars:"},{"line_number":44,"context_line":"      tox_envlist: functional"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f96bb07_4b548a21","line":42,"range":{"start_line":31,"start_character":0,"end_line":42,"end_character":25},"updated":"2018-01-16 08:55:02.000000000","message":"you can define this as base job and share between this and \nnova-tox-functional-py35","commit_id":"109c81c77ffb32d2f0dc676b3242d75982e41b9e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c388981b0c06bbe540c1449b7a9f836cdb2ca70f","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- job:"},{"line_number":30,"context_line":"    name: nova-tox-functional"},{"line_number":31,"context_line":"    parent: openstack-tox"},{"line_number":32,"context_line":"    description: |"},{"line_number":33,"context_line":"      Run tox-based functional tests for the OpenStack Nova project with Nova"},{"line_number":34,"context_line":"      specific irrelevant-files list. Uses tox with the ``functional``"},{"line_number":35,"context_line":"      environment."},{"line_number":36,"context_line":"    irrelevant-files:"},{"line_number":37,"context_line":"      - ^.*\\.rst$"},{"line_number":38,"context_line":"      - ^api-.*$"},{"line_number":39,"context_line":"      - ^doc/source/.*$"},{"line_number":40,"context_line":"      - ^nova/locale/.*$"},{"line_number":41,"context_line":"      - ^placement-api-ref/.*$"},{"line_number":42,"context_line":"      - ^releasenotes/.*$"},{"line_number":43,"context_line":"    vars:"},{"line_number":44,"context_line":"      tox_envlist: functional"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7f96bb07_2ebd8c01","line":42,"range":{"start_line":31,"start_character":0,"end_line":42,"end_character":25},"in_reply_to":"7f96bb07_4b548a21","updated":"2018-01-16 09:03:45.000000000","message":"I like the idea. But then later when we somebody wants to have different irrelevant-files for functional and functional-py35 he will try to override the irrelevant-files in the specific job and will reproduce the problem we try to fix in this patch. As overrides are not possible through job inheritance I try to avoid situation when somebody (wrongly) tries to override things.","commit_id":"109c81c77ffb32d2f0dc676b3242d75982e41b9e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ff63160c9d598182d1c72ae13fbf2c8ecfd62d2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    irrelevant-files:"},{"line_number":37,"context_line":"      - ^.*\\.rst$"},{"line_number":38,"context_line":"      - ^api-.*$"},{"line_number":39,"context_line":"      - ^doc/source/.*$"},{"line_number":40,"context_line":"      - ^nova/locale/.*$"},{"line_number":41,"context_line":"      - ^placement-api-ref/.*$"},{"line_number":42,"context_line":"      - ^releasenotes/.*$"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_1ac7ce14","line":39,"updated":"2018-01-23 19:12:16.000000000","message":"OK so https://review.openstack.org/#/c/531381/ was the patch that broke things, and it was because we didn\u0027t run the changes which were just under doc/notification_samples.\n\nLooking at the project-config change is misleading because it didn\u0027t catch this, because openstack-tox-functional is defined in openstack-zuul-jobs and child jobs can\u0027t override attributes of their parent, and the parent job definition excludes all doc changes:\n\nhttp://git.openstack.org/cgit/openstack-infra/openstack-zuul-jobs/tree/zuul.d/jobs.yaml#n352\n\nSo in this change, we are basically redefining the openstack-tox-functional job and making it nova-specific.","commit_id":"d4377c2d537ea998ed96cc8d7071877eefab994f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"de941c70689b6dfc5d7642516cd492328d8530a5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    irrelevant-files:"},{"line_number":37,"context_line":"      - ^.*\\.rst$"},{"line_number":38,"context_line":"      - ^api-.*$"},{"line_number":39,"context_line":"      - ^doc/source/.*$"},{"line_number":40,"context_line":"      - ^nova/locale/.*$"},{"line_number":41,"context_line":"      - ^placement-api-ref/.*$"},{"line_number":42,"context_line":"      - ^releasenotes/.*$"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_f5f0d769","line":39,"in_reply_to":"7f96bb07_1ac7ce14","updated":"2018-01-24 13:35:43.000000000","message":"Exactly.","commit_id":"d4377c2d537ea998ed96cc8d7071877eefab994f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8ff63160c9d598182d1c72ae13fbf2c8ecfd62d2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      tox_envlist: functional"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- job:"},{"line_number":47,"context_line":"    name: nova-tox-functional-py35"},{"line_number":48,"context_line":"    parent: openstack-tox"},{"line_number":49,"context_line":"    description: |"},{"line_number":50,"context_line":"      Run tox-based functional tests for the OpenStack Nova project"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_fa02226f","line":47,"updated":"2018-01-23 19:12:16.000000000","message":"The project-config definition of this says to only run this on master branch changes:\n\nhttps://review.openstack.org/#/c/533608/2/zuul.d/projects.yaml@a10658\n\nThat\u0027s likely from pike when py35 was fully supported in the functional tests. We should can probably preserve that here, but just make sure we don\u0027t run on anything older than stable/pike (so exclude stable/ocata specifically I guess).\n\n\u003clater\u003e\n\nOh but nevermind, because with zuulv3 the job definitions are branch-specific, so we won\u0027t run this job on stable branches because it\u0027s only defined in master now.\n\nI guess this means we\u0027ll have to also backport this change to stable/pike and stable/ocata...","commit_id":"d4377c2d537ea998ed96cc8d7071877eefab994f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"de941c70689b6dfc5d7642516cd492328d8530a5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      tox_envlist: functional"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- job:"},{"line_number":47,"context_line":"    name: nova-tox-functional-py35"},{"line_number":48,"context_line":"    parent: openstack-tox"},{"line_number":49,"context_line":"    description: |"},{"line_number":50,"context_line":"      Run tox-based functional tests for the OpenStack Nova project"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f96bb07_35fabf42","line":47,"in_reply_to":"7f96bb07_fa02226f","updated":"2018-01-24 13:35:43.000000000","message":"Yes. We have to backport this patch to stable branches and after then remove the definition from the project-config as project config is branchless.","commit_id":"d4377c2d537ea998ed96cc8d7071877eefab994f"}]}