)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"5cb413f63eb696b0d5125e5d614cbf48727610b6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"aggregations associated to the compute node."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"To fix the bug, this patch changes the function of"},{"line_number":16,"context_line":"_alloc_candidates_with_shared() to add non-sharing-provider to the"},{"line_number":17,"context_line":"provider summaries if it can provide the resource with sharing"},{"line_number":18,"context_line":"providers and to extract allocation request from non-sharing provider"},{"line_number":19,"context_line":"only when it can supply requested resources."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I332fa33c320a697136d6f0994fbad573a31eda1b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_8462b13d","line":18,"range":{"start_line":16,"start_character":35,"end_line":18,"end_character":9},"updated":"2018-01-15 01:31:23.000000000","message":"Not done yet.","commit_id":"f1ea4bd8f6d84a3581c1b445a3c080eefec0daea"}],"nova/api/openstack/placement/objects/resource_provider.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0634ed5bea0a9153151671d29b76b1b880feba70","unresolved":false,"context_lines":[{"line_number":3318,"context_line":"            if has_none:"},{"line_number":3319,"context_line":"                # This resource provider doesn\u0027t actually provide any requested"},{"line_number":3320,"context_line":"                # resource. It only has requested resources shared *with* it."},{"line_number":3321,"context_line":"                # We do not list this provider in allocation_requests but do"},{"line_number":3322,"context_line":"                # list it in provider_summaries."},{"line_number":3323,"context_line":"                continue"},{"line_number":3324,"context_line":""},{"line_number":3325,"context_line":"            # Get AllocationRequestResource(s) from the non-sharing provider"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_2a26bdcf","line":3322,"range":{"start_line":3321,"start_character":74,"end_line":3322,"end_character":48},"updated":"2018-03-30 23:14:02.000000000","message":"Well, no, we don\u0027t, as shown by [1].  But we should.  Please update this comment accordingly, with a big TODO.\n\n[1] https://review.openstack.org/#/c/533437/6/nova/tests/functional/api/openstack/placement/db/test_allocation_candidates.py@1402","commit_id":"4e2ccac4ba5cba4d6f33e72ec8019f846ead796b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0634ed5bea0a9153151671d29b76b1b880feba70","unresolved":false,"context_lines":[{"line_number":3320,"context_line":"                # resource. It only has requested resources shared *with* it."},{"line_number":3321,"context_line":"                # We do not list this provider in allocation_requests but do"},{"line_number":3322,"context_line":"                # list it in provider_summaries."},{"line_number":3323,"context_line":"                continue"},{"line_number":3324,"context_line":""},{"line_number":3325,"context_line":"            # Get AllocationRequestResource(s) from the non-sharing provider"},{"line_number":3326,"context_line":"            for rc_id, amount in requested_resources.items():"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_852a5a29","line":3323,"range":{"start_line":3323,"start_character":16,"end_line":3323,"end_character":24},"updated":"2018-03-30 23:14:02.000000000","message":"So we\u0027re still jumping to the next non-sharing provider, and skipping the code below.  That being the case, I cannot for the life of me see how this code is producing the result at [1].  Help.\n\n[Later] Okay, it\u0027s because `summaries` doesn\u0027t contain providers that don\u0027t provide any of the resources in question.  So the check on L3308 fails and we skip L3309-L3323 entirely.\n\n[1] https://review.openstack.org/#/c/533437/6/nova/tests/functional/api/openstack/placement/db/test_allocation_candidates.py@1391","commit_id":"4e2ccac4ba5cba4d6f33e72ec8019f846ead796b"}],"nova/tests/functional/api/openstack/placement/db/test_allocation_candidates.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"0634ed5bea0a9153151671d29b76b1b880feba70","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"        # Bug #1724633: It might be better if we could show the \"anchor\""},{"line_number":1399,"context_line":"        # point of cn1 in the provider summaries. However, the way how we"},{"line_number":1400,"context_line":"        # should support it depends on use cases. Once we face this bug with"},{"line_number":1401,"context_line":"        # a specific use case, we can re-open this bug."},{"line_number":1402,"context_line":"        expected \u003d {"},{"line_number":1403,"context_line":"            \u0027ss1\u0027: set(["},{"line_number":1404,"context_line":"                (fields.ResourceClass.DISK_GB, 1600, 0),"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_8a482987","line":1401,"updated":"2018-03-30 23:14:02.000000000","message":"A specific use case is that nova can\u0027t land this request on a host otherwise.","commit_id":"4e2ccac4ba5cba4d6f33e72ec8019f846ead796b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f578f5a566bead5cb69c19f2c751e10bcea1336c","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"        # Bug #1724633: It might be better if we could show the \"anchor\""},{"line_number":1399,"context_line":"        # point of cn1 in the provider summaries. However, the way how we"},{"line_number":1400,"context_line":"        # should support it depends on use cases. Once we face this bug with"},{"line_number":1401,"context_line":"        # a specific use case, we can re-open this bug."},{"line_number":1402,"context_line":"        expected \u003d {"},{"line_number":1403,"context_line":"            \u0027ss1\u0027: set(["},{"line_number":1404,"context_line":"                (fields.ResourceClass.DISK_GB, 1600, 0),"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_30786ac2","line":1401,"in_reply_to":"bf659307_8a482987","updated":"2018-03-31 00:33:57.000000000","message":"I played with this and made a decent start:\n\nhttps://review.openstack.org/#/c/558014/","commit_id":"4e2ccac4ba5cba4d6f33e72ec8019f846ead796b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7e5a8b602bea165a8c868692eb04cac320495d06","unresolved":false,"context_lines":[{"line_number":1404,"context_line":"                (fields.ResourceClass.DISK_GB, 1600, 0),"},{"line_number":1405,"context_line":"            ]),"},{"line_number":1406,"context_line":"            \u0027ss2\u0027: set(["},{"line_number":1407,"context_line":"                (fields.ResourceClass.IPV4_ADDRESS, 24, 0),"},{"line_number":1408,"context_line":"                (fields.ResourceClass.SRIOV_NET_VF, 16, 0),"},{"line_number":1409,"context_line":"            ]),"},{"line_number":1410,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_d0e32ed8","line":1407,"range":{"start_line":1407,"start_character":0,"end_line":1407,"end_character":59},"updated":"2018-03-30 23:54:16.000000000","message":"So it turns out that if you remove IPV4_ADDRESS from the request, this line doesn\u0027t show up in the provider summary.  Which is another wrinkle we need to iron out.  Because we agreed the provider_summary should show *all* the inventories for *all* the resource classes in all the providers associated with the request (as well as the \"anchor RPs\", which are also missing as noted).","commit_id":"4e2ccac4ba5cba4d6f33e72ec8019f846ead796b"}],"nova/tests/functional/db/test_allocation_candidates.py":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"5cb413f63eb696b0d5125e5d614cbf48727610b6","unresolved":false,"context_lines":[{"line_number":1559,"context_line":"        # the summaries? _validate_provider_summary_resources() should"},{"line_number":1560,"context_line":"        # be added to this test."},{"line_number":1561,"context_line":"        expected \u003d ["},{"line_number":1562,"context_line":"            [(\u0027ss1\u0027, fields.ResourceClass.DISK_GB, 1500),"},{"line_number":1563,"context_line":"             (\u0027ss2\u0027, fields.ResourceClass.IPV4_ADDRESS, 2),"},{"line_number":1564,"context_line":"             (\u0027ss2\u0027, fields.ResourceClass.SRIOV_NET_VF, 1)],"},{"line_number":1565,"context_line":"        ]"},{"line_number":1566,"context_line":"        self._validate_allocation_requests(expected, alloc_cands)"},{"line_number":1567,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_04db01ed","line":1564,"range":{"start_line":1562,"start_character":13,"end_line":1564,"end_character":58},"updated":"2018-01-15 01:31:23.000000000","message":"Should cn1 be here with no-resource-resource-request? ...Yup, I think that\u0027s better if the response can be re-used to post allocation. To do so, I need more time to look into this deeply.","commit_id":"f1ea4bd8f6d84a3581c1b445a3c080eefec0daea"}]}