)]}'
{"nova/scheduler/client/report.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"bc3e634fc6ff0d9cea5c3d05250361a63b05d9ee","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"        resp \u003d self.put(url, aggregates, version\u003d\u00271.1\u0027)"},{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"        if resp.status_code \u003d\u003d 200:"},{"line_number":1122,"context_line":"            json \u003d resp.json()"},{"line_number":1123,"context_line":"            self._provider_tree.update_aggregates(rp_uuid, json[\u0027aggregates\u0027])"},{"line_number":1124,"context_line":"            return"},{"line_number":1125,"context_line":""},{"line_number":1126,"context_line":"        # Some error occurred; log it"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_bb02b508","line":1123,"range":{"start_line":1122,"start_character":12,"end_line":1123,"end_character":78},"updated":"2018-01-19 20:33:41.000000000","message":"how about:\n\n placement_aggs \u003d resp.json()[\u0027aggregates\u0027]\n self._provider_tree.update_aggregates(rp_uuid, placement_aggs)","commit_id":"4437cb91d8fafc5373c9a5f7fd6e47f8dd55fb91"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"49c0bb72f169f8eff1527100a5d2233fee902e73","unresolved":false,"context_lines":[{"line_number":1119,"context_line":"        resp \u003d self.put(url, aggregates, version\u003d\u00271.1\u0027)"},{"line_number":1120,"context_line":""},{"line_number":1121,"context_line":"        if resp.status_code \u003d\u003d 200:"},{"line_number":1122,"context_line":"            json \u003d resp.json()"},{"line_number":1123,"context_line":"            self._provider_tree.update_aggregates(rp_uuid, json[\u0027aggregates\u0027])"},{"line_number":1124,"context_line":"            return"},{"line_number":1125,"context_line":""},{"line_number":1126,"context_line":"        # Some error occurred; log it"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_f365c146","line":1123,"range":{"start_line":1122,"start_character":12,"end_line":1123,"end_character":78},"in_reply_to":"7f96bb07_bb02b508","updated":"2018-01-19 23:27:26.000000000","message":"Okay..","commit_id":"4437cb91d8fafc5373c9a5f7fd6e47f8dd55fb91"}],"nova/tests/unit/scheduler/client/test_report.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"bc3e634fc6ff0d9cea5c3d05250361a63b05d9ee","unresolved":false,"context_lines":[{"line_number":1870,"context_line":"        self.ks_adap_mock.put.assert_called_once_with("},{"line_number":1871,"context_line":"            \u0027/resource_providers/%s/aggregates\u0027 % uuids.rp, json\u003daggs,"},{"line_number":1872,"context_line":"            raise_exc\u003dFalse, microversion\u003d\u00271.1\u0027)"},{"line_number":1873,"context_line":"        self.assertFalse("},{"line_number":1874,"context_line":"            self.client._provider_tree.have_aggregates_changed(uuids.rp, aggs))"},{"line_number":1875,"context_line":""},{"line_number":1876,"context_line":"    def test_set_aggregates_for_provider_fail(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_db48e15d","line":1873,"range":{"start_line":1873,"start_character":19,"end_line":1873,"end_character":24},"updated":"2018-01-19 20:33:41.000000000","message":"shouldn\u0027t this be True?","commit_id":"4437cb91d8fafc5373c9a5f7fd6e47f8dd55fb91"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"506ef9db6d1ce7368b4f32c312b2710df73d4610","unresolved":false,"context_lines":[{"line_number":1870,"context_line":"        self.ks_adap_mock.put.assert_called_once_with("},{"line_number":1871,"context_line":"            \u0027/resource_providers/%s/aggregates\u0027 % uuids.rp, json\u003daggs,"},{"line_number":1872,"context_line":"            raise_exc\u003dFalse, microversion\u003d\u00271.1\u0027)"},{"line_number":1873,"context_line":"        self.assertFalse("},{"line_number":1874,"context_line":"            self.client._provider_tree.have_aggregates_changed(uuids.rp, aggs))"},{"line_number":1875,"context_line":""},{"line_number":1876,"context_line":"    def test_set_aggregates_for_provider_fail(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_eb55a4fb","line":1873,"range":{"start_line":1873,"start_character":19,"end_line":1873,"end_character":24},"in_reply_to":"7f96bb07_53d915f2","updated":"2018-01-22 15:41:54.000000000","message":"ah, gotcha","commit_id":"4437cb91d8fafc5373c9a5f7fd6e47f8dd55fb91"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"49c0bb72f169f8eff1527100a5d2233fee902e73","unresolved":false,"context_lines":[{"line_number":1870,"context_line":"        self.ks_adap_mock.put.assert_called_once_with("},{"line_number":1871,"context_line":"            \u0027/resource_providers/%s/aggregates\u0027 % uuids.rp, json\u003daggs,"},{"line_number":1872,"context_line":"            raise_exc\u003dFalse, microversion\u003d\u00271.1\u0027)"},{"line_number":1873,"context_line":"        self.assertFalse("},{"line_number":1874,"context_line":"            self.client._provider_tree.have_aggregates_changed(uuids.rp, aggs))"},{"line_number":1875,"context_line":""},{"line_number":1876,"context_line":"    def test_set_aggregates_for_provider_fail(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f96bb07_53d915f2","line":1873,"range":{"start_line":1873,"start_character":19,"end_line":1873,"end_character":24},"in_reply_to":"7f96bb07_db48e15d","updated":"2018-01-19 23:27:26.000000000","message":"No, at this point we\u0027re checking that set_aggregates_for_provider updated the cache properly.  So it be like:\n\n self.assertEqual(set(aggs), self.client._provider_tree.data(uuids.rp).aggregates)\n\n...which wasn\u0027t possible when I first wrote this, but is now, and is a bit clearer, so I\u0027ll change it to that.","commit_id":"4437cb91d8fafc5373c9a5f7fd6e47f8dd55fb91"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e32d80dd4895dfcf14ed724ae0ee7b2ed72d1280","unresolved":false,"context_lines":[{"line_number":1879,"context_line":"        self.ks_adap_mock.put.return_value \u003d mock.Mock(status_code\u003d503)"},{"line_number":1880,"context_line":"        self.assertRaises("},{"line_number":1881,"context_line":"            exception.ResourceProviderUpdateFailed,"},{"line_number":1882,"context_line":"            self.client.set_aggregates_for_provider, uuids.rp, [])"},{"line_number":1883,"context_line":""},{"line_number":1884,"context_line":""},{"line_number":1885,"context_line":"class TestAggregates(SchedulerReportClientTestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f96bb07_d0d657c4","line":1882,"updated":"2018-01-22 15:33:47.000000000","message":"I might also check that the cache was not changed.","commit_id":"463c02168c2c2e1ddf59e48a5d505caa31707830"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c5c991db984b35d66c0e7c8e4924ef757a3686a4","unresolved":false,"context_lines":[{"line_number":1879,"context_line":"        self.ks_adap_mock.put.return_value \u003d mock.Mock(status_code\u003d503)"},{"line_number":1880,"context_line":"        self.assertRaises("},{"line_number":1881,"context_line":"            exception.ResourceProviderUpdateFailed,"},{"line_number":1882,"context_line":"            self.client.set_aggregates_for_provider, uuids.rp, [])"},{"line_number":1883,"context_line":""},{"line_number":1884,"context_line":""},{"line_number":1885,"context_line":"class TestAggregates(SchedulerReportClientTestCase):"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f93b717_35ef29b1","line":1882,"in_reply_to":"7f96bb07_d0d657c4","updated":"2018-01-30 00:06:30.000000000","message":"Done in https://review.openstack.org/#/c/531260/","commit_id":"463c02168c2c2e1ddf59e48a5d505caa31707830"}]}