)]}'
{"nova/volume/api.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"bead92152a5508440831416f0bedfd187c6c7abe","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            # NOTE(vish): scheduling failed, so delete it"},{"line_number":134,"context_line":"            self.db.volume_delete(context, volume_id)"},{"line_number":135,"context_line":"        if volume[\u0027status\u0027] not in [\"available\", \"error\"]:"},{"line_number":136,"context_line":"            msg \u003d _(\"Volume status must be available\")"},{"line_number":137,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":138,"context_line":"        now \u003d utils.utcnow()"},{"line_number":139,"context_line":"        self.db.volume_update(context, volume_id, {\u0027status\u0027: \u0027deleting\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAE3%2F%2F%2BfI%3D","line":136,"updated":"2012-03-14 17:17:41.000000000","message":"Nit: Should this message be updated to save potential confusion?","commit_id":"9087ae4d9b41bdc6422fa83cbbf99dc3835ce886"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"901a0619f249b5a6ae00d8e7ac449b573edc816f","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            # NOTE(vish): scheduling failed, so delete it"},{"line_number":134,"context_line":"            self.db.volume_destroy(context, volume_id)"},{"line_number":135,"context_line":"        if volume[\u0027status\u0027] not in [\"available\", \"error\"]:"},{"line_number":136,"context_line":"            msg \u003d _(\"Volume status must be available\")"},{"line_number":137,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":138,"context_line":"        now \u003d utils.utcnow()"},{"line_number":139,"context_line":"        self.db.volume_update(context, volume_id, {\u0027status\u0027: \u0027deleting\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAE3%2F%2F%2BbE%3D","line":136,"updated":"2012-03-14 17:50:19.000000000","message":"Still would be better to update this message to include \"error\" as an allowed state...","commit_id":"c54a89e199ee58b264a1c83a48f174b9300837ef"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"8c94935e658dee883f204771f352e5b810f791e1","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        volume_id \u003d volume[\u0027id\u0027]"},{"line_number":132,"context_line":"        if not volume[\u0027host\u0027]:"},{"line_number":133,"context_line":"            # NOTE(vish): scheduling failed, so delete it"},{"line_number":134,"context_line":"            self.db.volume_destroy(context, volume_id)"},{"line_number":135,"context_line":"        if volume[\u0027status\u0027] not in [\"available\", \"error\"]:"},{"line_number":136,"context_line":"            msg \u003d _(\"Volume status must be available or error\")"},{"line_number":137,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAE3%2F%2F%2BY4%3D","line":134,"updated":"2012-03-14 18:14:35.000000000","message":"Don\u0027t you want a \u0027return\u0027 here?  Below, a self.db.volume_update() would fail if you\u0027ve destroyed the volume.\n\nAlso, should the status checking come first... or do you figure you want to allow a destroy no matter what if there\u0027s no host set?  Note you can have a race with scheduling... where you could try to destroy the volume while scheduling has not quite picked a host yet... but I think that\u0027s okay.","commit_id":"93a77b1b276459647dcf2aa120d30ed5259a257d"}]}