)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"29cd1dbaa649eecf829f2c348bb764d8c67e17d9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle IpAddressAlreadyAllocated exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: Ie1d4581d334e1ec491e56371c62978945ae24a44"},{"line_number":10,"context_line":"Change-Id: I5bee9ae18764b6f285ecc5e8d7148a1019c74701"},{"line_number":11,"context_line":"Closes-Bug: #1744103"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f93b717_f5bb01c1","line":9,"updated":"2018-01-29 23:59:03.000000000","message":"We need a g-r bump for this:\n\nhttps://github.com/openstack/requirements/blob/master/global-requirements.txt#L261","commit_id":"5f28161a7760bcadb2c2badfa232be381de43458"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"39d4cef21d7e2b53d8af86bf1acb1426b3754bba","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle IpAddressAlreadyAllocated exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: Ie1d4581d334e1ec491e56371c62978945ae24a44"},{"line_number":10,"context_line":"Change-Id: I5bee9ae18764b6f285ecc5e8d7148a1019c74701"},{"line_number":11,"context_line":"Closes-Bug: #1744103"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa0c359_d62bbd2d","line":9,"in_reply_to":"5f93b717_f5bb01c1","updated":"2018-02-15 23:04:33.000000000","message":"Done: https://review.openstack.org/#/c/539241/","commit_id":"5f28161a7760bcadb2c2badfa232be381de43458"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"fbcbc4d9b3d4b5462d69e3933e6bdf5e79108446","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle IpAddressAlreadyAllocated exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-On: Ie1d4581d334e1ec491e56371c62978945ae24a44"},{"line_number":10,"context_line":"Change-Id: I5bee9ae18764b6f285ecc5e8d7148a1019c74701"},{"line_number":11,"context_line":"Closes-Bug: #1744103"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f93b717_4435528e","line":9,"in_reply_to":"5f93b717_f5bb01c1","updated":"2018-01-30 15:53:24.000000000","message":"Proposed it: https://review.openstack.org/#/c/535532/","commit_id":"5f28161a7760bcadb2c2badfa232be381de43458"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8d549989884595083b676b5fc61aec6b7346ce66","unresolved":false,"context_lines":[{"line_number":444,"context_line":"                   {\u0027ip\u0027: fixed_ip, \u0027network_id\u0027: network_id})"},{"line_number":445,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":446,"context_line":"        except (neutron_client_exc.IpAddressInUseClient,"},{"line_number":447,"context_line":"                neutron_client_exc.IpAddressAlreadyAllocatedClient):"},{"line_number":448,"context_line":"            LOG.warning(\u0027Neutron error: Fixed IP %s is \u0027"},{"line_number":449,"context_line":"                        \u0027already in use.\u0027, fixed_ip, instance\u003dinstance)"},{"line_number":450,"context_line":"            msg \u003d _(\"Fixed IP %s is already in use.\") % fixed_ip"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff6b8bd7_60553f50","line":447,"range":{"start_line":447,"start_character":35,"end_line":447,"end_character":66},"updated":"2018-03-06 21:35:33.000000000","message":"OK this was added in https://review.openstack.org/#/c/535530/ which was released in python-neutronclient 6.7.0 which is the minimum required version in global-requirements now:\n\nhttps://github.com/openstack/requirements/blob/master/global-requirements.txt#L259\n\nSo this is OK from a requirements perspective.\n\nWe should have a simple unit test for this scenario though to assert that when IpAddressAlreadyAllocatedClient is handled, we raise FixedIpAlreadyInUse rather than IpAddressAlreadyAllocatedClient which results in a 500 error during interface attach in the API.","commit_id":"d5cb4b37273541aad59b08383485360daafc6714"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"92c9bc28b7b05ed505f6f4280a56ddf96d31baf8","unresolved":false,"context_lines":[{"line_number":444,"context_line":"                   {\u0027ip\u0027: fixed_ip, \u0027network_id\u0027: network_id})"},{"line_number":445,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":446,"context_line":"        except (neutron_client_exc.IpAddressInUseClient,"},{"line_number":447,"context_line":"                neutron_client_exc.IpAddressAlreadyAllocatedClient):"},{"line_number":448,"context_line":"            LOG.warning(\u0027Neutron error: Fixed IP %s is \u0027"},{"line_number":449,"context_line":"                        \u0027already in use.\u0027, fixed_ip, instance\u003dinstance)"},{"line_number":450,"context_line":"            msg \u003d _(\"Fixed IP %s is already in use.\") % fixed_ip"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_9c34a9e0","line":447,"range":{"start_line":447,"start_character":35,"end_line":447,"end_character":66},"in_reply_to":"ff6b8bd7_40e11b9a","updated":"2018-03-06 23:39:06.000000000","message":"Done","commit_id":"d5cb4b37273541aad59b08383485360daafc6714"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6fe2aa0864e83505363c2ffbc20bfaf0a891c563","unresolved":false,"context_lines":[{"line_number":444,"context_line":"                   {\u0027ip\u0027: fixed_ip, \u0027network_id\u0027: network_id})"},{"line_number":445,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":446,"context_line":"        except (neutron_client_exc.IpAddressInUseClient,"},{"line_number":447,"context_line":"                neutron_client_exc.IpAddressAlreadyAllocatedClient):"},{"line_number":448,"context_line":"            LOG.warning(\u0027Neutron error: Fixed IP %s is \u0027"},{"line_number":449,"context_line":"                        \u0027already in use.\u0027, fixed_ip, instance\u003dinstance)"},{"line_number":450,"context_line":"            msg \u003d _(\"Fixed IP %s is already in use.\") % fixed_ip"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff6b8bd7_40e11b9a","line":447,"range":{"start_line":447,"start_character":35,"end_line":447,"end_character":66},"in_reply_to":"ff6b8bd7_60553f50","updated":"2018-03-06 21:36:09.000000000","message":"You can write a test based on test_create_port_minimal_raise_ip_in_use.","commit_id":"d5cb4b37273541aad59b08383485360daafc6714"}]}