)]}'
{"nova/objects/resource_provider.py":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"41b38d415a7687a9763196de5925d0eac7c4df2d","unresolved":false,"context_lines":[{"line_number":3567,"context_line":"        # needing to mess with the complex sql above or add additional"},{"line_number":3568,"context_line":"        # columns to the DB."},{"line_number":3569,"context_line":""},{"line_number":3570,"context_line":"        if limit and limit \u003c\u003d len(alloc_request_objs):"},{"line_number":3571,"context_line":"            if CONF.placement.randomize_allocation_candidates:"},{"line_number":3572,"context_line":"                alloc_request_objs \u003d random.sample(alloc_request_objs, limit)"},{"line_number":3573,"context_line":"            else:"},{"line_number":3574,"context_line":"                alloc_request_objs \u003d alloc_request_objs[:limit]"},{"line_number":3575,"context_line":"        elif CONF.placement.randomize_allocation_candidates:"},{"line_number":3576,"context_line":"            random.shuffle(alloc_request_objs)"},{"line_number":3577,"context_line":""},{"line_number":3578,"context_line":"        # Limit summaries to only those mentioned in the allocation requests."},{"line_number":3579,"context_line":"        if limit and limit \u003c\u003d len(alloc_request_objs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_1077a6a2","line":3576,"range":{"start_line":3570,"start_character":0,"end_line":3576,"end_character":46},"updated":"2018-02-08 12:20:11.000000000","message":"This might be a nit, but can\u0027t we just shrink this part like the following?\n\n  if CONF.placement.randomize_allocation_candidates:\n      random.shuffle(alloc_request_objs)\n  if limit and limit \u003c\u003d len(alloc_request_objs):\n      alloc_request_objs \u003d alloc_request_objs[:limit]","commit_id":"7f1dee530238f2f19e9423e4fc192564325a0b82"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"63dd4d5180c96b9637f2a3036805eb004fc43930","unresolved":false,"context_lines":[{"line_number":3567,"context_line":"        # needing to mess with the complex sql above or add additional"},{"line_number":3568,"context_line":"        # columns to the DB."},{"line_number":3569,"context_line":""},{"line_number":3570,"context_line":"        if limit and limit \u003c\u003d len(alloc_request_objs):"},{"line_number":3571,"context_line":"            if CONF.placement.randomize_allocation_candidates:"},{"line_number":3572,"context_line":"                alloc_request_objs \u003d random.sample(alloc_request_objs, limit)"},{"line_number":3573,"context_line":"            else:"},{"line_number":3574,"context_line":"                alloc_request_objs \u003d alloc_request_objs[:limit]"},{"line_number":3575,"context_line":"        elif CONF.placement.randomize_allocation_candidates:"},{"line_number":3576,"context_line":"            random.shuffle(alloc_request_objs)"},{"line_number":3577,"context_line":""},{"line_number":3578,"context_line":"        # Limit summaries to only those mentioned in the allocation requests."},{"line_number":3579,"context_line":"        if limit and limit \u003c\u003d len(alloc_request_objs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_506e8e95","line":3576,"range":{"start_line":3570,"start_character":0,"end_line":3576,"end_character":46},"in_reply_to":"3fa0c359_1077a6a2","updated":"2018-02-08 12:27:59.000000000","message":"later: Ah, this maybe for optimization purpose?","commit_id":"7f1dee530238f2f19e9423e4fc192564325a0b82"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a62a8bde22ba7e7d86050ee89f1fbb190930ea5b","unresolved":false,"context_lines":[{"line_number":3567,"context_line":"        # needing to mess with the complex sql above or add additional"},{"line_number":3568,"context_line":"        # columns to the DB."},{"line_number":3569,"context_line":""},{"line_number":3570,"context_line":"        if limit and limit \u003c\u003d len(alloc_request_objs):"},{"line_number":3571,"context_line":"            if CONF.placement.randomize_allocation_candidates:"},{"line_number":3572,"context_line":"                alloc_request_objs \u003d random.sample(alloc_request_objs, limit)"},{"line_number":3573,"context_line":"            else:"},{"line_number":3574,"context_line":"                alloc_request_objs \u003d alloc_request_objs[:limit]"},{"line_number":3575,"context_line":"        elif CONF.placement.randomize_allocation_candidates:"},{"line_number":3576,"context_line":"            random.shuffle(alloc_request_objs)"},{"line_number":3577,"context_line":""},{"line_number":3578,"context_line":"        # Limit summaries to only those mentioned in the allocation requests."},{"line_number":3579,"context_line":"        if limit and limit \u003c\u003d len(alloc_request_objs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_f46f1125","line":3576,"range":{"start_line":3570,"start_character":0,"end_line":3576,"end_character":46},"in_reply_to":"3fa0c359_506e8e95","updated":"2018-02-14 00:05:55.000000000","message":"Yes, random.sample doesn\u0027t recopy the whole alloc_request_objs list in memory, only the entries it samples.","commit_id":"7f1dee530238f2f19e9423e4fc192564325a0b82"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"9ef28677a6267e723d8ae884136418380cc91076","unresolved":false,"context_lines":[{"line_number":3567,"context_line":"        # needing to mess with the complex sql above or add additional"},{"line_number":3568,"context_line":"        # columns to the DB."},{"line_number":3569,"context_line":""},{"line_number":3570,"context_line":"        if limit and limit \u003c\u003d len(alloc_request_objs):"},{"line_number":3571,"context_line":"            if CONF.placement.randomize_allocation_candidates:"},{"line_number":3572,"context_line":"                alloc_request_objs \u003d random.sample(alloc_request_objs, limit)"},{"line_number":3573,"context_line":"            else:"},{"line_number":3574,"context_line":"                alloc_request_objs \u003d alloc_request_objs[:limit]"},{"line_number":3575,"context_line":"        elif CONF.placement.randomize_allocation_candidates:"},{"line_number":3576,"context_line":"            random.shuffle(alloc_request_objs)"},{"line_number":3577,"context_line":""},{"line_number":3578,"context_line":"        # Limit summaries to only those mentioned in the allocation requests."},{"line_number":3579,"context_line":"        if limit and limit \u003c\u003d len(alloc_request_objs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_5a5b8ff4","line":3576,"range":{"start_line":3570,"start_character":0,"end_line":3576,"end_character":46},"in_reply_to":"3fa0c359_f46f1125","updated":"2018-02-14 00:59:49.000000000","message":"Thanks. Sounds cool.","commit_id":"7f1dee530238f2f19e9423e4fc192564325a0b82"}]}