)]}'
{"gate/post_test_hook.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7f3673c9709998530499d99daa9ea76576f62608","unresolved":false,"context_lines":[{"line_number":21,"context_line":"archive_deleted_rows"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Check for orphaned instance allocations in Placement which could mean"},{"line_number":25,"context_line":"# something failed during a test run and isn\u0027t getting cleaned up properly."},{"line_number":26,"context_line":"LEAKED_ALLOCATIONS\u003d0"},{"line_number":27,"context_line":"for provider in $(openstack resource provider list -c uuid -f value); do"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f93b717_706aa7b3","line":24,"updated":"2018-01-29 18:15:14.000000000","message":"We might want to build in some wait logic to make sure that any ACTIVE instances are removed before we do this check. Also, we could list any instances in ERROR state and if there are, we don\u0027t really need to check this because we know something failed and allocations likely aren\u0027t removed in that case.","commit_id":"b980b43ef8e70d937795794c31698d431540a3d0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9968ca6b12359c2dea547e6ecca14f39846002ad","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# Check for orphaned instance allocations in Placement which could mean"},{"line_number":25,"context_line":"# something failed during a test run and isn\u0027t getting cleaned up properly."},{"line_number":26,"context_line":"LEAKED_ALLOCATIONS\u003d0"},{"line_number":27,"context_line":"for provider in $(openstack resource provider list -c uuid -f value); do"},{"line_number":28,"context_line":"    echo \"Looking for allocations for provider $provider\""},{"line_number":29,"context_line":"    allocations\u003d$(openstack resource provider show --allocations $provider | \\"},{"line_number":30,"context_line":"                  grep allocations | awk \u0027{print $4}\u0027)"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5f93b717_f5c1c1e5","line":27,"updated":"2018-01-30 00:17:21.000000000","message":"Hmm, no providers for some reason...\n\nhttp://logs.openstack.org/10/538510/2/check/legacy-tempest-dsvm-neutron-nova-next-full/8e2b424/logs/devstack-gate-post_test_hook.txt.gz#_2018-01-29_20_25_46_395\n\n2018-01-29 20:25:46.395 | + /opt/stack/new/nova/tools/hooks/post_test_hook.sh:main:L26:   LEAKED_ALLOCATIONS\u003d0\n2018-01-29 20:25:46.397 | ++ /opt/stack/new/nova/tools/hooks/post_test_hook.sh:main:L27:   openstack resource provider list -c uuid -f value\n2018-01-29 20:25:47.857 | Missing value auth-url required for auth plugin password\n2018-01-29 20:25:47.911 | + /opt/stack/new/nova/tools/hooks/post_test_hook.sh:main:L39:   [[ 0 -eq 1 ]]","commit_id":"b980b43ef8e70d937795794c31698d431540a3d0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2e5877484804f15ff10f4cb8d32ae7b8b0f94e7b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"archive_deleted_rows"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"set -e"},{"line_number":24,"context_line":"source $BASE/new/devstack/openrc admin"},{"line_number":25,"context_line":"# Check for orphaned instance allocations in Placement which could mean"},{"line_number":26,"context_line":"# something failed during a test run and isn\u0027t getting cleaned up properly."},{"line_number":27,"context_line":"LEAKED_ALLOCATIONS\u003d0"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f93b717_34814afc","line":24,"updated":"2018-01-31 02:13:43.000000000","message":"set +x before doing this?\n\nhttp://logs.openstack.org/10/538510/3/check/legacy-tempest-dsvm-neutron-nova-next-full/0aa5dac/logs/devstack-gate-post_test_hook.txt.gz#_2018-01-30_23_04_14_409","commit_id":"b1bb4e280121ae3edb499b5669e252dda32dc252"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2e5877484804f15ff10f4cb8d32ae7b8b0f94e7b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"source $BASE/new/devstack/openrc admin"},{"line_number":25,"context_line":"# Check for orphaned instance allocations in Placement which could mean"},{"line_number":26,"context_line":"# something failed during a test run and isn\u0027t getting cleaned up properly."},{"line_number":27,"context_line":"LEAKED_ALLOCATIONS\u003d0"},{"line_number":28,"context_line":"for provider in $(openstack resource provider list -c uuid -f value); do"},{"line_number":29,"context_line":"    echo \"Looking for allocations for provider $provider\""},{"line_number":30,"context_line":"    allocations\u003d$(openstack resource provider show --allocations $provider | \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f93b717_74903244","line":27,"updated":"2018-01-31 02:13:43.000000000","message":"Looks good:\n\nlogs.openstack.org/10/538510/3/check/legacy-tempest-dsvm-neutron-nova-next-full/0aa5dac/logs/devstack-gate-post_test_hook.txt.gz#_2018-01-30_23_04_14_409","commit_id":"b1bb4e280121ae3edb499b5669e252dda32dc252"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"0fd88860e598d484d022b98a46a46b6628d490f0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# TODO(mriedem): Consider checking for instances in ERROR state because"},{"line_number":31,"context_line":"# if there are any, we would expect them to retain allocations in Placement"},{"line_number":32,"context_line":"# and therefore we don\u0027t really need to check for leaked allocations."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Check for orphaned instance allocations in Placement which could mean"},{"line_number":35,"context_line":"# something failed during a test run and isn\u0027t getting cleaned up properly."},{"line_number":36,"context_line":"LEAKED_ALLOCATIONS\u003d0"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3fa0c359_7de9dab4","line":33,"updated":"2018-02-12 11:02:48.000000000","message":"You might consider added an echo that basically says \"going to look for allocations\" before you enter any of the conditionals and then another at the end saying \"yay, there weren\u0027t any\" if there weren\u0027t.\n\nThat level of verbosity is usually pretty annoying, except when grepping CI logs :(","commit_id":"bb419db6f649592e4c9eed69d443ef160447bedc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6c07d26aeb7af4fe8f5251cee840021793131cdb","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# TODO(mriedem): Consider checking for instances in ERROR state because"},{"line_number":31,"context_line":"# if there are any, we would expect them to retain allocations in Placement"},{"line_number":32,"context_line":"# and therefore we don\u0027t really need to check for leaked allocations."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# Check for orphaned instance allocations in Placement which could mean"},{"line_number":35,"context_line":"# something failed during a test run and isn\u0027t getting cleaned up properly."},{"line_number":36,"context_line":"LEAKED_ALLOCATIONS\u003d0"}],"source_content_type":"text/x-sh","patch_set":7,"id":"3fa0c359_dacd8285","line":33,"in_reply_to":"3fa0c359_7de9dab4","updated":"2018-02-12 22:16:22.000000000","message":"Done","commit_id":"bb419db6f649592e4c9eed69d443ef160447bedc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"15e503ddc7d3a410b6f40781036fdb95e91a3a92","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"archive_deleted_rows"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"./verify_placement.sh"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3fa0c359_7ccf7528","line":23,"updated":"2018-02-13 16:15:29.000000000","message":"Apparently this can\u0027t go in it\u0027s own file unless we have a symlink in nova/tools/hooks, but that\u0027s the old way of doing this which we\u0027re removing with the nova-next job definition in-tree.\n\n/opt/stack/new/nova/tools/hooks/post_test_hook.sh: line 23: ./verify_placement.sh: No such file or directory","commit_id":"559f8db73a610b1287531c864ff30cd5f922dfaa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"60aee0ea1dc522cf308e4817346a42f9b641399a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# We need to get the admin credentials to run the OSC CLIs for Placement."},{"line_number":25,"context_line":"BASE\u003d${BASE:-/opt/stack}"},{"line_number":26,"context_line":"source $BASE/new/devstack/openrc admin"},{"line_number":27,"context_line":"set -x"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# TODO(mriedem): Consider checking for instances in ERROR state because"},{"line_number":30,"context_line":"# if there are any, we would expect them to retain allocations in Placement"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3fa0c359_d290c9f0","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":6},"updated":"2018-02-14 22:51:43.000000000","message":"This is redundant. I think I wanted to set +x before sourcing openrc since it\u0027s pretty verbose.","commit_id":"2f7dcb39af4fb9f1af5bb30b11a1e86e0967fe00"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e96b13ff2f99a48fbb459eca45a5f4a5ba9cac27","unresolved":false,"context_lines":[{"line_number":37,"context_line":"LEAKED_ALLOCATIONS\u003d0"},{"line_number":38,"context_line":"for provider in $(openstack resource provider list -c uuid -f value); do"},{"line_number":39,"context_line":"    echo \"Looking for allocations for provider $provider\""},{"line_number":40,"context_line":"    allocations\u003d$(openstack resource provider show --allocations $provider | \\"},{"line_number":41,"context_line":"                  grep allocations | awk \u0027{print $4}\u0027)"},{"line_number":42,"context_line":"    if [[ \"$allocations\" !\u003d \"{}\" ]]; then"},{"line_number":43,"context_line":"        echo \"Resource provider has allocations:\""}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa0c359_493ac4cd","line":40,"updated":"2018-02-15 12:51:34.000000000","message":"just curious: is there not a convenient \"-f value\" you can do here to avoid the awk?","commit_id":"1d88cd85b8fac155c9696338ebb16409682e753d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"98b63379a9e9347d4300443c0cb071671cade3a8","unresolved":false,"context_lines":[{"line_number":37,"context_line":"LEAKED_ALLOCATIONS\u003d0"},{"line_number":38,"context_line":"for provider in $(openstack resource provider list -c uuid -f value); do"},{"line_number":39,"context_line":"    echo \"Looking for allocations for provider $provider\""},{"line_number":40,"context_line":"    allocations\u003d$(openstack resource provider show --allocations $provider | \\"},{"line_number":41,"context_line":"                  grep allocations | awk \u0027{print $4}\u0027)"},{"line_number":42,"context_line":"    if [[ \"$allocations\" !\u003d \"{}\" ]]; then"},{"line_number":43,"context_line":"        echo \"Resource provider has allocations:\""}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa0c359_31f11d96","line":40,"in_reply_to":"3fa0c359_11942136","updated":"2018-02-24 02:26:40.000000000","message":"Bingo, excellent point:\n\n$ openstack resource provider show --allocations f84c9e04-6728-4a0d-8940-80fd96a1c119 -c allocations -f value\n{u\u002769142a2b-cd99-4b78-9d14-c6d879f270b8\u0027: {u\u0027resources\u0027: {u\u0027VCPU\u0027: 1, u\u0027MEMORY_MB\u0027: 2048, u\u0027DISK_GB\u0027: 20}}}\n\nI\u0027ll remove the awk.","commit_id":"1d88cd85b8fac155c9696338ebb16409682e753d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3b9ae8e2063a03ecbf2c9e0933d87490adf3cb78","unresolved":false,"context_lines":[{"line_number":37,"context_line":"LEAKED_ALLOCATIONS\u003d0"},{"line_number":38,"context_line":"for provider in $(openstack resource provider list -c uuid -f value); do"},{"line_number":39,"context_line":"    echo \"Looking for allocations for provider $provider\""},{"line_number":40,"context_line":"    allocations\u003d$(openstack resource provider show --allocations $provider | \\"},{"line_number":41,"context_line":"                  grep allocations | awk \u0027{print $4}\u0027)"},{"line_number":42,"context_line":"    if [[ \"$allocations\" !\u003d \"{}\" ]]; then"},{"line_number":43,"context_line":"        echo \"Resource provider has allocations:\""}],"source_content_type":"text/x-sh","patch_set":11,"id":"3fa0c359_11942136","line":40,"in_reply_to":"3fa0c359_493ac4cd","updated":"2018-02-24 02:14:30.000000000","message":"Good question, I didn\u0027t even think about the nice -c and -f options to OSC CLIs, I\u0027ll take a look when I get a chance.","commit_id":"1d88cd85b8fac155c9696338ebb16409682e753d"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"f9024cba6840b781716f021d17c61a14e90fc23e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"for provider in $(openstack resource provider list -c uuid -f value); do"},{"line_number":39,"context_line":"    echo \"Looking for allocations for provider $provider\""},{"line_number":40,"context_line":"    allocations\u003d$(openstack resource provider show --allocations $provider \\"},{"line_number":41,"context_line":"                  -c allocations -f value)"},{"line_number":42,"context_line":"    if [[ \"$allocations\" !\u003d \"{}\" ]]; then"},{"line_number":43,"context_line":"        echo \"Resource provider has allocations:\""},{"line_number":44,"context_line":"        openstack resource provider show --allocations $provider"}],"source_content_type":"text/x-sh","patch_set":12,"id":"3fa0c359_9de111d3","line":41,"updated":"2018-02-26 11:09:50.000000000","message":"huzzah","commit_id":"e8e8941d25dadf78e27ae0f93fe4c07ace44378c"}]}