)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fd3578a317fcee04f0d89ec28d09dbd5dd63862f","unresolved":false,"context_lines":[{"line_number":2382,"context_line":""},{"line_number":2383,"context_line":"        # Skip get BuildRequest if filtering by IP address, as building"},{"line_number":2384,"context_line":"        # instances will not have IP addresses."},{"line_number":2385,"context_line":"        if not skip_build_request:"},{"line_number":2386,"context_line":"            # The ordering of instances will be"},{"line_number":2387,"context_line":"            # [sorted instances with no host] + [sorted instances with host]."},{"line_number":2388,"context_line":"            # This means BuildRequest and cell0 instances first, then cell"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_16408da4","line":2385,"range":{"start_line":2385,"start_character":8,"end_line":2385,"end_character":34},"updated":"2018-04-14 12:11:28.000000000","message":"nit: my style preference would be to do this instead:\n\nif skip_build_request:\n    build_requests \u003d objects.BuildRequestList()\nelse:\n    ...\n\nSomething about the negative logic...","commit_id":"b7b15b8ea48fb65de3c49ea350490cf7ffb9b7d1"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"81405348596307f24118002a227c2edcd3f8723b","unresolved":false,"context_lines":[{"line_number":2382,"context_line":""},{"line_number":2383,"context_line":"        # Skip get BuildRequest if filtering by IP address, as building"},{"line_number":2384,"context_line":"        # instances will not have IP addresses."},{"line_number":2385,"context_line":"        if not skip_build_request:"},{"line_number":2386,"context_line":"            # The ordering of instances will be"},{"line_number":2387,"context_line":"            # [sorted instances with no host] + [sorted instances with host]."},{"line_number":2388,"context_line":"            # This means BuildRequest and cell0 instances first, then cell"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_b588771f","line":2385,"range":{"start_line":2385,"start_character":8,"end_line":2385,"end_character":34},"in_reply_to":"bf659307_16408da4","updated":"2018-04-17 08:55:36.000000000","message":"Done","commit_id":"b7b15b8ea48fb65de3c49ea350490cf7ffb9b7d1"}],"nova/tests/unit/compute/test_compute_api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fd3578a317fcee04f0d89ec28d09dbd5dd63862f","unresolved":false,"context_lines":[{"line_number":5629,"context_line":""},{"line_number":5630,"context_line":"    @mock.patch.object(neutron_api.API, \u0027has_substr_port_filtering_extension\u0027)"},{"line_number":5631,"context_line":"    @mock.patch.object(neutron_api.API, \u0027list_ports\u0027)"},{"line_number":5632,"context_line":"    @mock.patch.object(objects.BuildRequestList, \u0027get_by_filters\u0027)"},{"line_number":5633,"context_line":"    def test_get_all_ip_filter_use_neutron(self, mock_buildreq_get,"},{"line_number":5634,"context_line":"                                           mock_list_port, mock_check_ext):"},{"line_number":5635,"context_line":"        mock_check_ext.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_f64079a4","side":"PARENT","line":5632,"updated":"2018-04-14 12:11:28.000000000","message":"Rather than remove this, change it to this:\n\n@mock.patch.object(objects.BuildRequestList, \u0027get_by_filters\u0027,\n                   new_callable\u003dmock.NonCallableMock)\n\nYou can remove the assert_called_once_with call below, and this will also enforce that BuildRequestList.get_By_filters is not called, which you\u0027re not doing in these tests.","commit_id":"1a762d00e21597e2766b0209f05390c9cd316c1f"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"81405348596307f24118002a227c2edcd3f8723b","unresolved":false,"context_lines":[{"line_number":5629,"context_line":""},{"line_number":5630,"context_line":"    @mock.patch.object(neutron_api.API, \u0027has_substr_port_filtering_extension\u0027)"},{"line_number":5631,"context_line":"    @mock.patch.object(neutron_api.API, \u0027list_ports\u0027)"},{"line_number":5632,"context_line":"    @mock.patch.object(objects.BuildRequestList, \u0027get_by_filters\u0027)"},{"line_number":5633,"context_line":"    def test_get_all_ip_filter_use_neutron(self, mock_buildreq_get,"},{"line_number":5634,"context_line":"                                           mock_list_port, mock_check_ext):"},{"line_number":5635,"context_line":"        mock_check_ext.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_757adf24","side":"PARENT","line":5632,"in_reply_to":"bf659307_f64079a4","updated":"2018-04-17 08:55:36.000000000","message":"Done","commit_id":"1a762d00e21597e2766b0209f05390c9cd316c1f"}]}