)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5549e9b98f46da58392e787c7db46dcaff2b0a2","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] https://review.openstack.org/#/c/532290/8/nova/virt/driver.py"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"blueprint ironic-driver-traits"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ib879f29c4a8f5001510296b3053b5bff0d10e31e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa0c359_f36c8b09","line":15,"updated":"2018-02-19 22:24:38.000000000","message":"This blueprint is technically closed now so we could remove this, but it\u0027s not a big deal.","commit_id":"d18936470f9ac45b59cc2579f3206ab8c93e11b5"}],"nova/virt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d5549e9b98f46da58392e787c7db46dcaff2b0a2","unresolved":false,"context_lines":[{"line_number":840,"context_line":"        \"\"\"Get the traits for a given node."},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"        Any custom traits returned are not required to exist in the placement"},{"line_number":843,"context_line":"        service - the caller will ensure their existence."},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"        :param nodename: the name of the node."},{"line_number":846,"context_line":"        :returns: an iterable of string trait names for the supplied node."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_53345ffb","line":843,"range":{"start_line":843,"start_character":29,"end_line":843,"end_character":33},"updated":"2018-02-19 22:24:38.000000000","message":"nit: s/will/must/\n\nThis is really just coupling how things work today, which is OK I guess, but this kind of stuff tends to change over time and we forget to update the docstrings.\n\nBut I don\u0027t expect the virt drivers to have to create the custom traits ever, so this is fine.","commit_id":"d18936470f9ac45b59cc2579f3206ab8c93e11b5"}]}
