)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"6ecd6c92fcb869aa95caae01433931699fbe786b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"deallocate_port_for_instance to just _build_instance_nw_info which"},{"line_number":17,"context_line":"is called in all these cases instead."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Fixes bug: 1223859"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I66eb0c0ab926e0a8d1e2c9cfe1f7fd579ea3aa27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FylA%3D","line":19,"updated":"2013-10-29 01:11:14.000000000","message":"The correct syntax is Closes-Bug: #","commit_id":"0fa70b5638986a29c6550c9538a6c5368e6a4857"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"dd881a38c50f215d720a9a2486283cc3465a133d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"deallocate_port_for_instance to just _build_instance_nw_info which"},{"line_number":17,"context_line":"is called in all these cases instead."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Fixes bug: 1223859"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I66eb0c0ab926e0a8d1e2c9cfe1f7fd579ea3aa27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FyYY%3D","line":19,"in_reply_to":"AAAATn%2F%2Fybc%3D","updated":"2013-10-29 03:12:22.000000000","message":"K I\u0027ll start using the new syntax","commit_id":"0fa70b5638986a29c6550c9538a6c5368e6a4857"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"2974761abc32a8cf8fd630ad7b55edfc89d16bd6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"deallocate_port_for_instance to just _build_instance_nw_info which"},{"line_number":17,"context_line":"is called in all these cases instead."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Fixes bug: 1223859"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I66eb0c0ab926e0a8d1e2c9cfe1f7fd579ea3aa27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2Fybc%3D","line":19,"in_reply_to":"AAAATn%2F%2Fyeg%3D","updated":"2013-10-29 02:46:44.000000000","message":"I don\u0027t know whether it is compelling enough but We are start to using new syntax and the best practice suggest to do so, see the link https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references  and as I said it is not the blocker.","commit_id":"0fa70b5638986a29c6550c9538a6c5368e6a4857"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"d21a01d1fc9b70fdda549614857d6642bb6e7143","unresolved":false,"context_lines":[{"line_number":16,"context_line":"deallocate_port_for_instance to just _build_instance_nw_info which"},{"line_number":17,"context_line":"is called in all these cases instead."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Fixes bug: 1223859"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I66eb0c0ab926e0a8d1e2c9cfe1f7fd579ea3aa27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2Fyeg%3D","line":19,"in_reply_to":"AAAATn%2F%2FyfI%3D","updated":"2013-10-29 02:10:44.000000000","message":"I\u0027ve just never switched but can if there is a compelling reason to.","commit_id":"0fa70b5638986a29c6550c9538a6c5368e6a4857"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"608612422910620ee0ffeaa8bf5512274a28c0a4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"deallocate_port_for_instance to just _build_instance_nw_info which"},{"line_number":17,"context_line":"is called in all these cases instead."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Fixes bug: 1223859"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I66eb0c0ab926e0a8d1e2c9cfe1f7fd579ea3aa27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FyfI%3D","line":19,"in_reply_to":"AAAATn%2F%2Fyjc%3D","updated":"2013-10-29 02:07:08.000000000","message":"But that\u0027s not the reason we still use it, right? although it is not a big deal.","commit_id":"0fa70b5638986a29c6550c9538a6c5368e6a4857"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"17ffbca2b8588995e56bdf135c123300ba1846f4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"deallocate_port_for_instance to just _build_instance_nw_info which"},{"line_number":17,"context_line":"is called in all these cases instead."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Fixes bug: 1223859"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I66eb0c0ab926e0a8d1e2c9cfe1f7fd579ea3aa27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2Fyjc%3D","line":19,"in_reply_to":"AAAATn%2F%2FylA%3D","updated":"2013-10-29 01:49:24.000000000","message":"Fixes bug still works and links to the bug report.","commit_id":"0fa70b5638986a29c6550c9538a6c5368e6a4857"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0912138da2a5e4a841bdf9a760228a3528827196","unresolved":false,"context_lines":[{"line_number":16,"context_line":"deallocate_port_for_instance to just _build_instance_nw_info which"},{"line_number":17,"context_line":"is called in all these cases instead."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"closes-bug: #1223859"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I66eb0c0ab926e0a8d1e2c9cfe1f7fd579ea3aa27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2FuhE%3D","line":19,"updated":"2013-10-29 20:24:26.000000000","message":"This needs to be Closes-bug and not have a blank space below it.","commit_id":"b7b25644b8a9c91e7646285e9adab90bbfbe8f66"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"dfc8eb3521b05eeb00532858a295c9b73aff734a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"deallocate_port_for_instance to just _build_instance_nw_info which"},{"line_number":17,"context_line":"is called in all these cases instead."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"closes-bug: #1223859"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I66eb0c0ab926e0a8d1e2c9cfe1f7fd579ea3aa27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2FtVY%3D","line":19,"in_reply_to":"AAAATn%2F%2FuhE%3D","updated":"2013-10-30 06:15:49.000000000","message":"Done","commit_id":"b7b25644b8a9c91e7646285e9adab90bbfbe8f66"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0cf08239a1b2d153d3bd2cbd6771be70886050f7","unresolved":false,"context_lines":[{"line_number":989,"context_line":"        # those not attached to one of the provided list of networks"},{"line_number":990,"context_line":"        else:"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"            # Unfortinately, this is sometimes in unicode and sometimes not"},{"line_number":993,"context_line":"            if isinstance(instance[\u0027info_cache\u0027][\u0027network_info\u0027], unicode):"},{"line_number":994,"context_line":"                ifaces \u003d jsonutils.loads("},{"line_number":995,"context_line":"                    instance[\u0027info_cache\u0027][\u0027network_info\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FvFA%3D","line":992,"updated":"2013-10-29 18:20:25.000000000","message":"Unfortunately is misspelled.","commit_id":"0fa70b5638986a29c6550c9538a6c5368e6a4857"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b8d8efff626c020e871e01b2fa67630252df472e","unresolved":false,"context_lines":[{"line_number":989,"context_line":"        # those not attached to one of the provided list of networks"},{"line_number":990,"context_line":"        else:"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"            # Unfortinately, this is sometimes in unicode and sometimes not"},{"line_number":993,"context_line":"            if isinstance(instance[\u0027info_cache\u0027][\u0027network_info\u0027], unicode):"},{"line_number":994,"context_line":"                ifaces \u003d jsonutils.loads("},{"line_number":995,"context_line":"                    instance[\u0027info_cache\u0027][\u0027network_info\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FulM%3D","line":992,"in_reply_to":"AAAATn%2F%2FvFA%3D","updated":"2013-10-29 20:05:44.000000000","message":"that\u0027s unfortunate","commit_id":"0fa70b5638986a29c6550c9538a6c5368e6a4857"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"6ecd6c92fcb869aa95caae01433931699fbe786b","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        else:"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"            # Unfortinately, this is sometimes in unicode and sometimes not"},{"line_number":993,"context_line":"            if isinstance(instance[\u0027info_cache\u0027][\u0027network_info\u0027], unicode):"},{"line_number":994,"context_line":"                ifaces \u003d jsonutils.loads("},{"line_number":995,"context_line":"                    instance[\u0027info_cache\u0027][\u0027network_info\u0027])"},{"line_number":996,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FylQ%3D","line":993,"updated":"2013-10-29 01:11:14.000000000","message":"well, since unicode no longer exist in python3, we\u0027d better to use six.text_types rather than unicode for python3 compatibility.","commit_id":"0fa70b5638986a29c6550c9538a6c5368e6a4857"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"de6fc0faa68bea4280056cca07e705aaf8d7c08d","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        else:"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"            # Unfortinately, this is sometimes in unicode and sometimes not"},{"line_number":993,"context_line":"            if isinstance(instance[\u0027info_cache\u0027][\u0027network_info\u0027], unicode):"},{"line_number":994,"context_line":"                ifaces \u003d jsonutils.loads("},{"line_number":995,"context_line":"                    instance[\u0027info_cache\u0027][\u0027network_info\u0027])"},{"line_number":996,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fyfs%3D","line":993,"in_reply_to":"AAAATn%2F%2FyjE%3D","updated":"2013-10-29 02:04:42.000000000","message":"Yes we can replace it in *future* in case we unintentionally wrote the codes doesn\u0027t compatible, I can\u0027t see the point we already know it but decide to leave it in future  find and replace, we should brought the attention on such issue like compatility as earlier as possible to everyone, and it will definitely help us to reduce the find and replace effort as well as review effort IMHO.","commit_id":"0fa70b5638986a29c6550c9538a6c5368e6a4857"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"df6126a39642cd8397061dd7c20ea7a647860f05","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        else:"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"            # Unfortinately, this is sometimes in unicode and sometimes not"},{"line_number":993,"context_line":"            if isinstance(instance[\u0027info_cache\u0027][\u0027network_info\u0027], unicode):"},{"line_number":994,"context_line":"                ifaces \u003d jsonutils.loads("},{"line_number":995,"context_line":"                    instance[\u0027info_cache\u0027][\u0027network_info\u0027])"},{"line_number":996,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FyjE%3D","line":993,"in_reply_to":"AAAATn%2F%2Fyks%3D","updated":"2013-10-29 01:28:48.000000000","message":"I believe this wouldn\u0027t be a blocker. Py3 compat is only being done in Oslo for now so this can be cleaned up sometime later in the future.\n\nhttps://wiki.openstack.org/wiki/Python3Deps","commit_id":"0fa70b5638986a29c6550c9538a6c5368e6a4857"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"21f9c2236c28c72aca2927787e7e74de6b9cbb65","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        else:"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"            # Unfortinately, this is sometimes in unicode and sometimes not"},{"line_number":993,"context_line":"            if isinstance(instance[\u0027info_cache\u0027][\u0027network_info\u0027], unicode):"},{"line_number":994,"context_line":"                ifaces \u003d jsonutils.loads("},{"line_number":995,"context_line":"                    instance[\u0027info_cache\u0027][\u0027network_info\u0027])"},{"line_number":996,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fyks%3D","line":993,"in_reply_to":"AAAATn%2F%2FylQ%3D","updated":"2013-10-29 01:12:08.000000000","message":"sorry, it should be six.text_type","commit_id":"0fa70b5638986a29c6550c9538a6c5368e6a4857"}],"nova/tests/network/test_neutronv2.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"4cd76f64ed928d59f003b7482c95a0a305964c5d","unresolved":false,"context_lines":[{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    def test_get_instance_nw_info_with_nets_and_info_cache(self):"},{"line_number":522,"context_line":"        # This tests that adding an interface to an instance does not"},{"line_number":523,"context_line":"        # remove the first instance from the instance."},{"line_number":524,"context_line":"        api \u003d neutronapi.API()"},{"line_number":525,"context_line":"        self.mox.StubOutWithMock(api.db, \u0027instance_info_cache_update\u0027)"},{"line_number":526,"context_line":"        api.db.instance_info_cache_update("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FH6o%3D","line":523,"updated":"2013-11-14 05:53:43.000000000","message":"the first interface?","commit_id":"1957339df302e2da75e0dbe78b5d566194ab2c08"}]}