)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"213008609689c50dd3a624cdd18e63bf8d272d6a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Added the missing \"context\" argument in nova/virt/driver.py"},{"line_number":10,"context_line":"* Added the missing argument in the test_virt_drivers.destroy() as well so it"},{"line_number":11,"context_line":"will make sure none of the other drivers will miss it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I083b935da95c28ad4f9879036ef2bf7c1fbbb58e"},{"line_number":14,"context_line":"Closes-Bug: #1244829"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2F1Wc%3D","line":11,"updated":"2013-10-28 09:23:08.000000000","message":"Please mention that this was a regression caused by\n\n commit 8c0673d3102478ef34ef1b11c1db156db4b68f62\n Author: Joel Coffman \u003cjoel.coffman@jhuapl.edu\u003e\n Date:   Wed Sep 11 12:15:43 2013 -0400\n\n    Add encryption support for volumes to libvirt","commit_id":"3056f6413d01d8f6067294d56529c389c58bf0fc"}],"nova/tests/virt/docker/test_driver.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"63c591803545fecba785f89ea93ee04b8a0761e2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                       \u0027_get_registry_port\u0027,"},{"line_number":50,"context_line":"                       fake_get_registry_port)"},{"line_number":51,"context_line":"        self.test_container \u003d {\u0027id\u0027: \u0027fake_id\u0027, \u0027name\u0027: \u0027fake_name\u0027}"},{"line_number":52,"context_line":"        self.test_image \u003d {\u0027name\u0027: \u0027busybox\u0027, \u0027container_format\u0027: \u0027docker\u0027}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    #NOTE(bcwaldon): This exists only because _get_running_instance on the"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FlE0%3D","line":52,"updated":"2013-11-01 00:33:01.000000000","message":"Can we reuse utils.get_test_instance() and utils.get_test_image_info to create fake instance and image? Just make the instance and image info as self variable to make sure every test case can use it?\n\nPlease refer to line 58 \u0026 62 in this file.","commit_id":"788eb5cb024d1841a5144d5836626ee6051a273a"},{"author":{"_account_id":7838,"name":"Sam Alba","email":"sam.alba@gmail.com","username":"samalba"},"change_message_id":"1638c2f735ba5df10b1eacef2546635cd5a5d706","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                       \u0027_get_registry_port\u0027,"},{"line_number":50,"context_line":"                       fake_get_registry_port)"},{"line_number":51,"context_line":"        self.test_container \u003d {\u0027id\u0027: \u0027fake_id\u0027, \u0027name\u0027: \u0027fake_name\u0027}"},{"line_number":52,"context_line":"        self.test_image \u003d {\u0027name\u0027: \u0027busybox\u0027, \u0027container_format\u0027: \u0027docker\u0027}"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    #NOTE(bcwaldon): This exists only because _get_running_instance on the"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FlEQ%3D","line":52,"in_reply_to":"AAAATn%2F%2FlE0%3D","updated":"2013-11-01 00:35:30.000000000","message":"Makes sense, I\u0027ll do that.","commit_id":"788eb5cb024d1841a5144d5836626ee6051a273a"}],"nova/virt/driver.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"22aaa82ca420f427cc01b2e4bee5bd771c01ece3","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        raise NotImplementedError()"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def destroy(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":245,"context_line":"                destroy_disks\u003dTrue, context\u003dNone):"},{"line_number":246,"context_line":"        \"\"\"Destroy (shutdown and delete) the specified instance."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        If the instance is not found (for example if networking failed), this"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FvfY%3D","line":245,"updated":"2013-10-29 16:39:59.000000000","message":"Can we make context as a required parameter?","commit_id":"3056f6413d01d8f6067294d56529c389c58bf0fc"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c6ec8d3aa384e13971ec2d472b91f331f93c52e4","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        raise NotImplementedError()"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def destroy(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":245,"context_line":"                destroy_disks\u003dTrue, context\u003dNone):"},{"line_number":246,"context_line":"        \"\"\"Destroy (shutdown and delete) the specified instance."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        If the instance is not found (for example if networking failed), this"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FutI%3D","line":245,"in_reply_to":"AAAATn%2F%2FvfY%3D","updated":"2013-10-29 19:30:08.000000000","message":"Not without changing all of the callers.  I would like to see that happen, in another patch potentially, and have context move up before instance to match other methods.","commit_id":"3056f6413d01d8f6067294d56529c389c58bf0fc"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"91ca4286edfd893267e9e96c4ecef406cfccc3bd","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        :param destroy_disks: Indicates if disks should be destroyed"},{"line_number":258,"context_line":"        :param context: security context"},{"line_number":259,"context_line":"        \"\"\""},{"line_number":260,"context_line":"        # TODO(Vek): Need to pass context in for access to auth_token"},{"line_number":261,"context_line":"        raise NotImplementedError()"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def reboot(self, context, instance, network_info, reboot_type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2F1Kw%3D","line":260,"updated":"2013-10-28 10:16:47.000000000","message":"Can we remove this comments?","commit_id":"3056f6413d01d8f6067294d56529c389c58bf0fc"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"63c591803545fecba785f89ea93ee04b8a0761e2","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        raise NotImplementedError()"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def destroy(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":245,"context_line":"                destroy_disks\u003dTrue, context\u003dNone):"},{"line_number":246,"context_line":"        \"\"\"Destroy (shutdown and delete) the specified instance."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        If the instance is not found (for example if networking failed), this"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FlEs%3D","line":245,"updated":"2013-11-01 00:33:01.000000000","message":"Suggest take context as a required variable and put it as first parameter to keep consistent with other functions.","commit_id":"788eb5cb024d1841a5144d5836626ee6051a273a"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"601839f844f1683e49b0889da8bb1efcc79cfad0","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        raise NotImplementedError()"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def destroy(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":245,"context_line":"                destroy_disks\u003dTrue, context\u003dNone):"},{"line_number":246,"context_line":"        \"\"\"Destroy (shutdown and delete) the specified instance."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        If the instance is not found (for example if networking failed), this"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2Fk9k%3D","line":245,"in_reply_to":"AAAATn%2F%2FlD0%3D","updated":"2013-11-01 01:58:18.000000000","message":"OK, but we may need other\u0027s coments. ;-)","commit_id":"788eb5cb024d1841a5144d5836626ee6051a273a"},{"author":{"_account_id":7838,"name":"Sam Alba","email":"sam.alba@gmail.com","username":"samalba"},"change_message_id":"1638c2f735ba5df10b1eacef2546635cd5a5d706","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        raise NotImplementedError()"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def destroy(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":245,"context_line":"                destroy_disks\u003dTrue, context\u003dNone):"},{"line_number":246,"context_line":"        \"\"\"Destroy (shutdown and delete) the specified instance."},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        If the instance is not found (for example if networking failed), this"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FlD0%3D","line":245,"in_reply_to":"AAAATn%2F%2FlEs%3D","updated":"2013-11-01 00:35:30.000000000","message":"Well, it won\u0027t be consistent with the other drivers then, right? It makes sense to have that but I do think it should go in another review. What do you think?","commit_id":"788eb5cb024d1841a5144d5836626ee6051a273a"}]}