)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17ad3476cedd54a6ede606723cf868ce86c0cc67","unresolved":false,"context_lines":[{"line_number":10,"context_line":"and attach_status right above, so this is doing nothing other than"},{"line_number":11,"context_line":"changing it to the incorrect value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Co-Authored-By: melanie witt \u003cmelwittt@gmail.com\u003e"},{"line_number":14,"context_line":"Change-Id: Iea0c1ea0a699b9519f66977391202956f17aac66"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa0c359_c8b6dc3f","line":13,"range":{"start_line":13,"start_character":16,"end_line":13,"end_character":49},"updated":"2018-02-15 00:22:20.000000000","message":"nit: this would be Mohammed Naser \u003cmnaser@vexxhost.com\u003e since melwitt is the author.","commit_id":"3d586dea6e59538a0d84e06cc7970ed4b922285b"}],"nova/tests/fixtures.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fd2c49c6dd21ee0abbb240977ab973b951b296a3","unresolved":false,"context_lines":[{"line_number":1381,"context_line":"                volume \u003d {"},{"line_number":1382,"context_line":"                    \u0027status\u0027: \u0027available\u0027,"},{"line_number":1383,"context_line":"                    \u0027display_name\u0027: \u0027TEST2\u0027,"},{"line_number":1384,"context_line":"                    \u0027attach_status\u0027: \u0027detached\u0027,"},{"line_number":1385,"context_line":"                    \u0027id\u0027: volume_id,"},{"line_number":1386,"context_line":"                    \u0027multiattach\u0027: False,"},{"line_number":1387,"context_line":"                    \u0027size\u0027: 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_0bcac919","line":1384,"updated":"2018-02-01 01:31:28.000000000","message":"Odd, I was going off of these here.","commit_id":"a007a3f4277e24e0f55ab74f7987145bc2840698"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"68d70a283c71afea6ade44cb10b918d29921189f","unresolved":false,"context_lines":[{"line_number":1381,"context_line":"                volume \u003d {"},{"line_number":1382,"context_line":"                    \u0027status\u0027: \u0027available\u0027,"},{"line_number":1383,"context_line":"                    \u0027display_name\u0027: \u0027TEST2\u0027,"},{"line_number":1384,"context_line":"                    \u0027attach_status\u0027: \u0027detached\u0027,"},{"line_number":1385,"context_line":"                    \u0027id\u0027: volume_id,"},{"line_number":1386,"context_line":"                    \u0027multiattach\u0027: False,"},{"line_number":1387,"context_line":"                    \u0027size\u0027: 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_6e16fb4b","line":1384,"in_reply_to":"5f93b717_0bcac919","updated":"2018-02-01 01:45:18.000000000","message":"It\u0027s part of the Volume object ... still looking for the response schemas in the code.\n\nhttps://github.com/openstack/cinder/blob/7ee765c/cinder/objects/volume.py#L87","commit_id":"a007a3f4277e24e0f55ab74f7987145bc2840698"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f67e4c6f7d58a27c22401f4dead58fb3034944c5","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"            has_attachment \u003d any("},{"line_number":1392,"context_line":"                [volume[\u0027id\u0027] in attachments"},{"line_number":1393,"context_line":"                 for attachments in self.attachments.values()])"},{"line_number":1394,"context_line":"            volume[\u0027attach_status\u0027] \u003d (\u0027attached\u0027 if has_attachment"},{"line_number":1395,"context_line":"                                       else \u0027detached\u0027"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"            # Check for our special image-backed volume."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_eb019d6b","line":1394,"range":{"start_line":1394,"start_character":20,"end_line":1394,"end_character":33},"updated":"2018-02-01 01:22:04.000000000","message":"The volume resource doesn\u0027t have an attach_status key:\n\nhttps://developer.openstack.org/api-ref/block-storage/v3/#show-a-volume-s-details","commit_id":"a007a3f4277e24e0f55ab74f7987145bc2840698"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8697be0ae7a9d94e0868da581c872f7d5336ab40","unresolved":false,"context_lines":[{"line_number":1392,"context_line":"                [volume[\u0027id\u0027] in attachments"},{"line_number":1393,"context_line":"                 for attachments in self.attachments.values()])"},{"line_number":1394,"context_line":"            volume[\u0027attach_status\u0027] \u003d (\u0027attached\u0027 if has_attachment"},{"line_number":1395,"context_line":"                                       else \u0027detached\u0027"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"            # Check for our special image-backed volume."},{"line_number":1398,"context_line":"            if volume_id \u003d\u003d self.IMAGE_BACKED_VOL:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_b9676fe9","line":1395,"updated":"2018-02-01 02:34:29.000000000","message":"Argh, I missed a paren too.","commit_id":"a007a3f4277e24e0f55ab74f7987145bc2840698"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"10877d45ae4c30ea3268b26ca3d52ca00670e92e","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"            has_attachment \u003d any("},{"line_number":1392,"context_line":"                [volume[\u0027id\u0027] in attachments"},{"line_number":1393,"context_line":"                 for attachments in self.attachments.values()])"},{"line_number":1394,"context_line":"            volume[\u0027attach_status\u0027] \u003d (\u0027attached\u0027 if has_attachment"},{"line_number":1395,"context_line":"                                       else \u0027detached\u0027)"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"            # Check for our special image-backed volume."}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_d930f4eb","line":1394,"updated":"2018-02-14 20:10:43.000000000","message":"Why not also set volume[\u0027status\u0027] to in-use if there are attachments, and \u0027available\u0027 if there aren\u0027t?","commit_id":"701d2525875084b2e755234b8c1389834f84b770"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2970a9bf86dcd6b904d0784dbcb2345489520b2c","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"            has_attachment \u003d any("},{"line_number":1392,"context_line":"                [volume[\u0027id\u0027] in attachments"},{"line_number":1393,"context_line":"                 for attachments in self.attachments.values()])"},{"line_number":1394,"context_line":"            volume[\u0027attach_status\u0027] \u003d (\u0027attached\u0027 if has_attachment"},{"line_number":1395,"context_line":"                                       else \u0027detached\u0027)"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"            # Check for our special image-backed volume."}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_19e2dc02","line":1394,"in_reply_to":"3fa0c359_999eecb6","updated":"2018-02-14 20:22:50.000000000","message":"Yeah ... seems like we could try just removing it instead of updating it.","commit_id":"701d2525875084b2e755234b8c1389834f84b770"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3fb6e6ba90b24ef2be983caf2798ad2f3ace2af0","unresolved":false,"context_lines":[{"line_number":1391,"context_line":"            has_attachment \u003d any("},{"line_number":1392,"context_line":"                [volume[\u0027id\u0027] in attachments"},{"line_number":1393,"context_line":"                 for attachments in self.attachments.values()])"},{"line_number":1394,"context_line":"            volume[\u0027attach_status\u0027] \u003d (\u0027attached\u0027 if has_attachment"},{"line_number":1395,"context_line":"                                       else \u0027detached\u0027)"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"            # Check for our special image-backed volume."}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_999eecb6","line":1394,"in_reply_to":"3fa0c359_d930f4eb","updated":"2018-02-14 20:14:12.000000000","message":"Actually the for loop above deals with status so we\u0027re likely OK. Given that, I\u0027m not sure why we even have this block of code.","commit_id":"701d2525875084b2e755234b8c1389834f84b770"}]}