)]}'
{"nova/tests/fixtures.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"d84f16f22e499ecf29c6d5209d1b5b7db059eb45","unresolved":false,"context_lines":[{"line_number":750,"context_line":"        # NOTE(gibi): The UUIDFields emits a warning if the value is not a"},{"line_number":751,"context_line":"        # valid UUID. Let\u0027s escalate that to an exception in the test to"},{"line_number":752,"context_line":"        # prevent adding violations."},{"line_number":753,"context_line":"        warnings.filterwarnings(\u0027error\u0027, message\u003d\".*invalid UUID.*\")"},{"line_number":754,"context_line":""},{"line_number":755,"context_line":"        self.addCleanup(warnings.resetwarnings)"},{"line_number":756,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f93b717_da279fc6","line":753,"updated":"2018-02-02 15:27:50.000000000","message":"This doesn\u0027t raise an exception. I\u0027m adding a unit test that shows that the warning is still emitted, but the test passes.","commit_id":"2f43d11c27bb79d88764d127cac2cd454bd70a77"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0bfae6d15ab681a59e6f6faa0dab6fcdff66a015","unresolved":false,"context_lines":[{"line_number":728,"context_line":"        # this gets kind of crazy given the way that upstream python libs use"},{"line_number":729,"context_line":"        # this."},{"line_number":730,"context_line":"        warnings.simplefilter(\"once\", DeprecationWarning)"},{"line_number":731,"context_line":"        warnings.filterwarnings(\u0027ignore\u0027,"},{"line_number":732,"context_line":"                                message\u003d\u0027With-statements now directly support\u0027"},{"line_number":733,"context_line":"                                        \u0027 multiple context managers\u0027)"},{"line_number":734,"context_line":"        # NOTE(sdague): nova does not use pkg_resources directly, this"},{"line_number":735,"context_line":"        # is all very long standing deprecations about other tools"},{"line_number":736,"context_line":"        # using it. None of this is useful to Nova development."}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_141e1aba","line":733,"range":{"start_line":731,"start_character":0,"end_line":733,"end_character":69},"updated":"2018-02-05 14:04:18.000000000","message":"Not related to this, but I think we can remove this.","commit_id":"9a0a95b871b4e83b005080e2ec91f92427578606"}],"nova/tests/unit/test_fixtures.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9237cb0a071bc9b28fe20c39175da9bfda97f9de","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        self.assertEqual(401, resp.status_code)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"class TestWarningsFixture(testtools.TestCase):"},{"line_number":496,"context_line":"    def test_invalid_uuid_errors(self):"},{"line_number":497,"context_line":"        \"\"\"Creating an oslo.versionedobject with an invalid UUID value for a"},{"line_number":498,"context_line":"        UUIDField should raise an exception."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f93b717_00d35605","line":495,"updated":"2018-02-02 16:19:29.000000000","message":"This test class missing a \n\n        self.useFixture(fixtures.WarningsFixture())\n\ncall in the setUp() to actually use the modified Warning fixture it tests.","commit_id":"02b6d164af1bf9ec3d3904927087af4e6731d63f"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"e049fd9f050f7ed8fb6ab0cbf35e7550ccec716c","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        self.assertEqual(401, resp.status_code)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"class TestWarningsFixture(testtools.TestCase):"},{"line_number":496,"context_line":"    def test_invalid_uuid_errors(self):"},{"line_number":497,"context_line":"        \"\"\"Creating an oslo.versionedobject with an invalid UUID value for a"},{"line_number":498,"context_line":"        UUIDField should raise an exception."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f93b717_80c0c6e2","line":495,"in_reply_to":"5f93b717_00d35605","updated":"2018-02-02 16:31:06.000000000","message":"It inherits from TestCase, which uses the fixture.\nhttps://github.com/openstack/nova/blob/master/nova/test.py#L302","commit_id":"02b6d164af1bf9ec3d3904927087af4e6731d63f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"66069a250df085f6457acd49614400ee8ba14c0b","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        self.assertEqual(401, resp.status_code)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"class TestWarningsFixture(testtools.TestCase):"},{"line_number":496,"context_line":"    def test_invalid_uuid_errors(self):"},{"line_number":497,"context_line":"        \"\"\"Creating an oslo.versionedobject with an invalid UUID value for a"},{"line_number":498,"context_line":"        UUIDField should raise an exception."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f93b717_cb14afeb","line":495,"in_reply_to":"5f93b717_80c0c6e2","updated":"2018-02-02 16:49:02.000000000","message":"This now inherits from testtools.TestCase and not from nova.test.TestCase. They are not the same.","commit_id":"02b6d164af1bf9ec3d3904927087af4e6731d63f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8edc7710e2b11fb08afbd48ba1492bd65cdea23c","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        self.assertEqual(401, resp.status_code)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"class TestWarningsFixture(testtools.TestCase):"},{"line_number":496,"context_line":"    def test_invalid_uuid_errors(self):"},{"line_number":497,"context_line":"        \"\"\"Creating an oslo.versionedobject with an invalid UUID value for a"},{"line_number":498,"context_line":"        UUIDField should raise an exception."}],"source_content_type":"text/x-python","patch_set":3,"id":"5f93b717_2b8193c3","line":495,"in_reply_to":"5f93b717_cb14afeb","updated":"2018-02-02 17:01:05.000000000","message":"I PS5 I changed it to test.TestCase therefore it don\u0027t need the explicity fixture setup as that test.TestCase do that automatically.","commit_id":"02b6d164af1bf9ec3d3904927087af4e6731d63f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"06a2cbc251757f7c17eb04f116c8b61fe67b5e46","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                \"dest_host\": \"host-dest\","},{"line_number":523,"context_line":"                \"old_instance_type_id\": 42,"},{"line_number":524,"context_line":"                \"new_instance_type_id\": 84,"},{"line_number":525,"context_line":"                \"instance_uuid\": \"fake-uuid\","},{"line_number":526,"context_line":"                \"status\": \"migrating\","},{"line_number":527,"context_line":"                \"migration_type\": \"resize\","},{"line_number":528,"context_line":"                \"hidden\": False,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_f5cf8625","line":525,"range":{"start_line":525,"start_character":16,"end_line":525,"end_character":45},"updated":"2018-07-16 13:41:25.000000000","message":"Boo. Cause my very first thought was, \"why doesn\u0027t THIS fail?\"\n\n \u0027instance_uuid\u0027: fields.StringField(nullable\u003dTrue),\n\nPerhaps a comment that this is (unexpectedly?) a StringField rather than a UUIDField.","commit_id":"bf76253261a35f3af04342c4b726bbf4b639de58"}]}