)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c4bc06717174f9639ca5cef707cffe3f3191899e","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The first phase of blueprint vmware-image-cache-management."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DocImpact"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I4f3ee90ae866583e8df782ff89d2b11bbebf9c39"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"AAAAUH%2F%2Fdh8%3D","line":26,"updated":"2014-01-13 16:58:21.000000000","message":"Might be good to move this tag to *above* \"A new configuration variable has been added\"","commit_id":"65d7320587e484e628e31f061498b8b6c20a0c19"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d7ebb0174eae8cc18cc669647017d56e10deb399","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The first phase of blueprint vmware-image-cache-management."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DocImpact"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I4f3ee90ae866583e8df782ff89d2b11bbebf9c39"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"AAAAUH%2F%2FdMA%3D","line":26,"in_reply_to":"AAAAUH%2F%2Fdh8%3D","updated":"2014-01-13 17:54:06.000000000","message":"Done","commit_id":"65d7320587e484e628e31f061498b8b6c20a0c19"}],"etc/nova/nova.conf.sample":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"d1d6616db56e0eea0283edfc178aec373c97ef15","unresolved":false,"context_lines":[{"line_number":1951,"context_line":"#image_cache_subdirectory_name\u003d_base"},{"line_number":1952,"context_line":""},{"line_number":1953,"context_line":"# Where temporary images are stored on the datastore. This is"},{"line_number":1954,"context_line":"# NOT the full path - just a folder name. The is used for"},{"line_number":1955,"context_line":"# downloading images and image snapshots. (string value)"},{"line_number":1956,"context_line":"#image_temp_subdirectory_name\u003d_temp"},{"line_number":1957,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"AAAATn%2F9EPY%3D","line":1954,"updated":"2013-12-17 05:41:02.000000000","message":"The is? typo?","commit_id":"6e0034069062b3edbd267528764033e2da459e17"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7ff1b6c33dc09670c41720645436822a53ca43fe","unresolved":false,"context_lines":[{"line_number":1951,"context_line":"#image_cache_subdirectory_name\u003d_base"},{"line_number":1952,"context_line":""},{"line_number":1953,"context_line":"# Where temporary images are stored on the datastore. This is"},{"line_number":1954,"context_line":"# NOT the full path - just a folder name. The is used for"},{"line_number":1955,"context_line":"# downloading images and image snapshots. (string value)"},{"line_number":1956,"context_line":"#image_temp_subdirectory_name\u003d_temp"},{"line_number":1957,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":15,"id":"AAAATn%2F9DSk%3D","line":1954,"in_reply_to":"AAAATn%2F9EPY%3D","updated":"2013-12-17 09:26:34.000000000","message":"Correct. It is a typo. I\u0027ll fix when I rebase.","commit_id":"6e0034069062b3edbd267528764033e2da459e17"}],"nova/tests/virt/vmwareapi/test_vmwareapi_vm_util.py":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c4bc06717174f9639ca5cef707cffe3f3191899e","unresolved":false,"context_lines":[{"line_number":254,"context_line":"                \u0027backing\u0027: {"},{"line_number":255,"context_line":"                    \u0027datastore\u0027: {"},{"line_number":256,"context_line":"                        \"summary.type\": \"VMFS\","},{"line_number":257,"context_line":"                        \"summary.freeSpace\": 536870912000,"},{"line_number":258,"context_line":"                        \"summary.capacity\": 1099511627776,"},{"line_number":259,"context_line":"                        \"summary.accessible\":true,"},{"line_number":260,"context_line":"                        \"summary.name\": \"fake-ds\""}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAUH%2F%2FdjE%3D","side":"PARENT","line":257,"updated":"2014-01-13 16:58:21.000000000","message":"same on both sides? this seems silly to change","commit_id":"21963e715b13390b2fe8018e0777040023d37579"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c4bc06717174f9639ca5cef707cffe3f3191899e","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                        \"summary.name\": \"fake-ds\","},{"line_number":259,"context_line":"                        \"summary.capacity\": 1099511627776,"},{"line_number":260,"context_line":"                        \"summary.freeSpace\": 536870912000,"},{"line_number":261,"context_line":"                        \"browser\": \"\""},{"line_number":262,"context_line":"                    },"},{"line_number":263,"context_line":"                    \u0027fileName\u0027: \u0027/tmp/foo.iso\u0027,"},{"line_number":264,"context_line":"                    \u0027obj_name\u0027: \u0027ns0: VirtualCdromIsoBackingInfo\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAUH%2F%2Fdi4%3D","line":261,"updated":"2014-01-13 16:58:21.000000000","message":"this line looks like the only real addition... why are you altering the other lines?","commit_id":"65d7320587e484e628e31f061498b8b6c20a0c19"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d7ebb0174eae8cc18cc669647017d56e10deb399","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                        \"summary.name\": \"fake-ds\","},{"line_number":259,"context_line":"                        \"summary.capacity\": 1099511627776,"},{"line_number":260,"context_line":"                        \"summary.freeSpace\": 536870912000,"},{"line_number":261,"context_line":"                        \"browser\": \"\""},{"line_number":262,"context_line":"                    },"},{"line_number":263,"context_line":"                    \u0027fileName\u0027: \u0027/tmp/foo.iso\u0027,"},{"line_number":264,"context_line":"                    \u0027obj_name\u0027: \u0027ns0: VirtualCdromIsoBackingInfo\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAUH%2F%2FdMs%3D","line":261,"in_reply_to":"AAAAUH%2F%2Fdi4%3D","updated":"2014-01-13 17:54:06.000000000","message":"for some reason the addition of the new field caused the change in the order","commit_id":"65d7320587e484e628e31f061498b8b6c20a0c19"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"c57fdc349bfcfc684e98c7780e27407a4857d4c9","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            # Here we assume thick provisioning and lsiLogic for the adapter"},{"line_number":310,"context_line":"            # type"},{"line_number":311,"context_line":"            LOG.debug(_(\"Creating temporary folder for %(folder)s on \""},{"line_number":312,"context_line":"                        \"datastore %(datastore).\"),"},{"line_number":313,"context_line":"                      {\u0027folder\u0027: folder, \u0027datastore\u0027: data_store_name})"},{"line_number":314,"context_line":"            self._mkdir(vm_util.build_datastore_path(data_store_name,"},{"line_number":315,"context_line":"                                                     folder))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fz68%3D","line":312,"updated":"2013-10-28 17:03:43.000000000","message":"%(datastore)s","commit_id":"749d959efb2004b8dad31ba9861b072cddf811b5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"667fcb5c6e1619523634e7aed120d06649bebcaf","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            # Here we assume thick provisioning and lsiLogic for the adapter"},{"line_number":310,"context_line":"            # type"},{"line_number":311,"context_line":"            LOG.debug(_(\"Creating temporary folder for %(folder)s on \""},{"line_number":312,"context_line":"                        \"datastore %(datastore).\"),"},{"line_number":313,"context_line":"                      {\u0027folder\u0027: folder, \u0027datastore\u0027: data_store_name})"},{"line_number":314,"context_line":"            self._mkdir(vm_util.build_datastore_path(data_store_name,"},{"line_number":315,"context_line":"                                                     folder))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fz58%3D","line":312,"in_reply_to":"AAAATn%2F%2Fz68%3D","updated":"2013-10-28 17:07:06.000000000","message":"Done","commit_id":"749d959efb2004b8dad31ba9861b072cddf811b5"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"72e2c6b1d1601665f4888eae5b4c6ee3e008399e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"               help\u003d\u0027Where temporary images are stored on the datastore. \u0027"},{"line_number":72,"context_line":"                    \u0027This is NOT the full path - just a folder name. The \u0027"},{"line_number":73,"context_line":"                    \u0027is used for downloading images and image snapshots.\u0027),"},{"line_number":74,"context_line":"]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"vmware_group \u003d cfg.OptGroup(name\u003d\u0027vmware\u0027,"},{"line_number":77,"context_line":"                            title\u003d\u0027VMware Options\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2FCL4%3D","line":74,"updated":"2013-11-15 11:31:18.000000000","message":"Your indentation is a little odd here. The indented lines should all be indented by two more characters.\n\nNot a big deal, but please tweak if this goes another round of patching.","commit_id":"7cfeb39659f0b66f0a52d0d7134d21fca0969328"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"198207d3527c3e89ad31c81cebe39a5b94c3e266","unresolved":false,"context_lines":[{"line_number":71,"context_line":"               help\u003d\u0027Where temporary images are stored on the datastore. \u0027"},{"line_number":72,"context_line":"                    \u0027This is NOT the full path - just a folder name. The \u0027"},{"line_number":73,"context_line":"                    \u0027is used for downloading images and image snapshots.\u0027),"},{"line_number":74,"context_line":"]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"vmware_group \u003d cfg.OptGroup(name\u003d\u0027vmware\u0027,"},{"line_number":77,"context_line":"                            title\u003d\u0027VMware Options\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2B%2FaI%3D","line":74,"in_reply_to":"AAAATn%2F%2FCL4%3D","updated":"2013-11-16 05:59:49.000000000","message":"I think that this is a jenkins display issue. The indentations are as you have requested.","commit_id":"7cfeb39659f0b66f0a52d0d7134d21fca0969328"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"5e4698564fdb4ee19b27b4a28ebe7792a4f23383","unresolved":false,"context_lines":[{"line_number":560,"context_line":"                                                     vmdk_copy_task)"},{"line_number":561,"context_line":"                    except Exception as e:"},{"line_number":562,"context_line":"                        LOG.warning(_(\"Root disk file creation \""},{"line_number":563,"context_line":"                                      \"failed - %s\"), e)"},{"line_number":564,"context_line":"                    if root_gb_in_kb \u003e vmdk_file_size_in_kb:"},{"line_number":565,"context_line":"                        self._extend_virtual_disk(instance, root_gb_in_kb,"},{"line_number":566,"context_line":"                                                  root_vmdk_path,"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F8vpE%3D","line":563,"updated":"2013-12-20 19:02:13.000000000","message":"at this point should you re-throw the exception to let the upper layers handle the failure?  AFAIK this failure is fatal...","commit_id":"cbe643b4821d7c782db7cd9cc0b8fdab16d3e507"},{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"5e4698564fdb4ee19b27b4a28ebe7792a4f23383","unresolved":false,"context_lines":[{"line_number":1627,"context_line":"        if not folder_exists:"},{"line_number":1628,"context_line":"            self._mkdir(vm_util.build_datastore_path(ds_name,"},{"line_number":1629,"context_line":"                                                     self._base_folder),"},{"line_number":1630,"context_line":"                        ds_ref)"},{"line_number":1631,"context_line":""},{"line_number":1632,"context_line":"        return file_exists"},{"line_number":1633,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAATn%2F8vpA%3D","line":1630,"updated":"2013-12-20 19:02:13.000000000","message":"weird indent here","commit_id":"cbe643b4821d7c782db7cd9cc0b8fdab16d3e507"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"c4bc06717174f9639ca5cef707cffe3f3191899e","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                         \"data_store_name\": data_store_name},"},{"line_number":355,"context_line":"                      instance\u003dinstance)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        def _move_image_to_cache_folder(tmp_folder, base_folder):"},{"line_number":358,"context_line":"            LOG.debug(_(\"Moving temporary folder %(tmp)s to cache \""},{"line_number":359,"context_line":"                        \"folder %(cache)s.\"),"},{"line_number":360,"context_line":"                      {\u0027tmp\u0027: tmp_folder, \u0027cache\u0027: base_folder})"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAUH%2F%2FdhA%3D","line":357,"updated":"2014-01-13 16:58:21.000000000","message":"Is there *really* no way you could have done this *outside* of \"def spawn\" ... ??? ... this keeps propagating that bad practice we were talking about where you get all kinds of inner methods that clutter up a method.\n\nIs there *no way* way to write this as a separate (and separately testable) method? What is the argument for continuing what we agreed was bad practice here?","commit_id":"65d7320587e484e628e31f061498b8b6c20a0c19"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d7ebb0174eae8cc18cc669647017d56e10deb399","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                         \"data_store_name\": data_store_name},"},{"line_number":355,"context_line":"                      instance\u003dinstance)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        def _move_image_to_cache_folder(tmp_folder, base_folder):"},{"line_number":358,"context_line":"            LOG.debug(_(\"Moving temporary folder %(tmp)s to cache \""},{"line_number":359,"context_line":"                        \"folder %(cache)s.\"),"},{"line_number":360,"context_line":"                      {\u0027tmp\u0027: tmp_folder, \u0027cache\u0027: base_folder})"}],"source_content_type":"text/x-python","patch_set":21,"id":"AAAAUH%2F%2FdMY%3D","line":357,"in_reply_to":"AAAAUH%2F%2FdhA%3D","updated":"2014-01-13 17:54:06.000000000","message":"this has been done in a patch based on this one. please see - https://review.openstack.org/#/c/63933/","commit_id":"65d7320587e484e628e31f061498b8b6c20a0c19"}]}