)]}'
{"nova/service.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"94a114dd184378ca229904e7cb8df0b322218e10","unresolved":false,"context_lines":[{"line_number":61,"context_line":"}"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def _create_service_ref(this_service, context):"},{"line_number":65,"context_line":"    service \u003d objects.Service(context)"},{"line_number":66,"context_line":"    service.host \u003d this_service.host"},{"line_number":67,"context_line":"    service.binary \u003d this_service.binary"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_70368e54","line":64,"updated":"2019-11-06 22:27:25.000000000","message":"Note we also have this:\n\nhttps://github.com/openstack/nova/blob/e79a0effc686f0d1bd2edca24ee50c10c5d6dc0a/nova/api/openstack/wsgi_app.py#L57\n\nBut I don\u0027t think it applies since it\u0027s only for creating an API service which would be ignored here anyway:\n\nhttps://github.com/openstack/nova/blob/e79a0effc686f0d1bd2edca24ee50c10c5d6dc0a/nova/api/openstack/compute/wsgi.py#L16\n\nhttps://github.com/openstack/nova/blob/e79a0effc686f0d1bd2edca24ee50c10c5d6dc0a/nova/api/metadata/wsgi.py#L16","commit_id":"3521abdc3e999ed853b54553ad56f6541174a23e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cccbab0903ae7a526b501e9eab2ea961d0861607","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    # the only ones where being disabled means anything. It does"},{"line_number":73,"context_line":"    # not make sense to be able to disable non-compute services like"},{"line_number":74,"context_line":"    # nova-scheduler or nova-osapi_compute since that does nothing."},{"line_number":75,"context_line":"    if not CONF.enable_new_services and service.binary \u003d\u003d \u0027nova-compute\u0027:"},{"line_number":76,"context_line":"        msg \u003d _(\"New compute service disabled due to config option.\")"},{"line_number":77,"context_line":"        service.disabled \u003d True"},{"line_number":78,"context_line":"        service.disabled_reason \u003d msg"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1024fa0d","line":75,"updated":"2019-11-06 22:32:49.000000000","message":"As a follow up it might not be a bad idea to move this option to the [compute] group so it\u0027s bit more clear where this is used.","commit_id":"3521abdc3e999ed853b54553ad56f6541174a23e"}],"nova/tests/unit/test_service.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"6b322fe6f8fe7a10307d042c74db97db0b3dab49","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_service_with_min_down_time(self):"},{"line_number":78,"context_line":"        # TODO(hanlind): This really tests code in the servicegroup api."},{"line_number":79,"context_line":"        self.flags(service_down_time\u003d10, report_interval\u003d10)"},{"line_number":80,"context_line":"        service.Service(\u0027test\u0027,"},{"line_number":81,"context_line":"                        \u0027test\u0027,"},{"line_number":82,"context_line":"                        \u0027test\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e0479776","line":79,"updated":"2019-10-10 02:35:54.000000000","message":"Here","commit_id":"3521abdc3e999ed853b54553ad56f6541174a23e"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"6b322fe6f8fe7a10307d042c74db97db0b3dab49","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        mock_Service.return_value \u003d mock_service_obj"},{"line_number":278,"context_line":"        mock_Service.get_by_host_and_binary.return_value \u003d None"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        CONF.set_override(\u0027enable_new_services\u0027, False)"},{"line_number":281,"context_line":"        serv \u003d service.Service(self.host,"},{"line_number":282,"context_line":"                               self.binary,"},{"line_number":283,"context_line":"                               self.topic,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_2037ef01","line":280,"updated":"2019-10-10 02:35:54.000000000","message":"It should be as follows:\n\n  self.flags(enable_new_services\u003dFalse)\n\nSee line 79.","commit_id":"3521abdc3e999ed853b54553ad56f6541174a23e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d54de9b7a6bef878cbd73b0b3c481745cf3c494e","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        mock_Service.return_value \u003d mock_service_obj"},{"line_number":278,"context_line":"        mock_Service.get_by_host_and_binary.return_value \u003d None"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        CONF.set_override(\u0027enable_new_services\u0027, False)"},{"line_number":281,"context_line":"        serv \u003d service.Service(self.host,"},{"line_number":282,"context_line":"                               self.binary,"},{"line_number":283,"context_line":"                               self.topic,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_10c87a54","line":280,"in_reply_to":"3fa7e38b_2037ef01","updated":"2019-11-06 22:23:22.000000000","message":"They do the same thing under the covers. It\u0027s not really worth -1ing this over for a casual contributor, especially if it bothers you you can provide a patch on top which changes this.","commit_id":"3521abdc3e999ed853b54553ad56f6541174a23e"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"6b322fe6f8fe7a10307d042c74db97db0b3dab49","unresolved":false,"context_lines":[{"line_number":296,"context_line":"        mock_Service.return_value \u003d mock_service_obj"},{"line_number":297,"context_line":"        mock_Service.get_by_host_and_binary.return_value \u003d None"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        CONF.set_override(\u0027enable_new_services\u0027, False)"},{"line_number":300,"context_line":"        serv \u003d service.Service(self.host,"},{"line_number":301,"context_line":"                               \"nova-scheduler\", self.topic,"},{"line_number":302,"context_line":"                               \u0027nova.tests.unit.test_service.FakeManager\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e03c77e2","line":299,"range":{"start_line":299,"start_character":8,"end_line":299,"end_character":55},"updated":"2019-10-10 02:35:54.000000000","message":"ditto","commit_id":"3521abdc3e999ed853b54553ad56f6541174a23e"}]}