)]}'
{"nova/compute/rpcapi.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d155f67f545abcde5587c46e7ac57fd73265ac7f","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        for Pike compatibility. All new changes should go against 5.x."},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        * 5.0  - Remove 4.x compatibility"},{"line_number":351,"context_line":"\u003e\u003e\u003e\u003e\u003e\u003e\u003e Compute RPC client bump to 5.0"},{"line_number":352,"context_line":"    \u0027\u0027\u0027"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    VERSION_ALIASES \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_bb86cada","line":351,"range":{"start_line":351,"start_character":0,"end_line":351,"end_character":38},"updated":"2018-02-08 19:33:27.000000000","message":"oops","commit_id":"90b01a0941bb57d1ec35751eb05af6c194d6b631"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d155f67f545abcde5587c46e7ac57fd73265ac7f","unresolved":false,"context_lines":[{"line_number":558,"context_line":"    def confirm_resize(self, ctxt, instance, migration, host,"},{"line_number":559,"context_line":"            cast\u003dTrue):"},{"line_number":560,"context_line":"        client \u003d self.router.client(ctxt)"},{"line_number":561,"context_line":"        # NOTE(danms): We had a deprecations in 5.0, which means we need to"},{"line_number":562,"context_line":"        # try to send that, as 4.max is not equivalent for us"},{"line_number":563,"context_line":"        version \u003d \u00275.0\u0027"},{"line_number":564,"context_line":"        msg_args \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_fb3452fd","line":561,"range":{"start_line":561,"start_character":30,"end_line":561,"end_character":44},"updated":"2018-02-08 19:33:27.000000000","message":"Depending on how anal you want to be, here and below, it would be either \"a deprecation\" or \"deprecations\".","commit_id":"90b01a0941bb57d1ec35751eb05af6c194d6b631"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d155f67f545abcde5587c46e7ac57fd73265ac7f","unresolved":false,"context_lines":[{"line_number":749,"context_line":"                   dest\u003ddest, block_migration\u003dblock_migration,"},{"line_number":750,"context_line":"                   migrate_data\u003dmigrate_data, **args)"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def live_migration_force_complete(self, ctxt, instance, migration):"},{"line_number":753,"context_line":"        version \u003d self._ver(ctxt, \u00274.12\u0027)"},{"line_number":754,"context_line":"        kwargs \u003d {}"},{"line_number":755,"context_line":"        client \u003d self.router.client(ctxt)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_161d5365","line":752,"range":{"start_line":752,"start_character":60,"end_line":752,"end_character":69},"updated":"2018-02-08 19:33:27.000000000","message":"We don\u0027t actually care about this anymore right?","commit_id":"90b01a0941bb57d1ec35751eb05af6c194d6b631"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"19cfd358def5bd46ce2c48a7f5548f01a12a6d92","unresolved":false,"context_lines":[{"line_number":749,"context_line":"                   dest\u003ddest, block_migration\u003dblock_migration,"},{"line_number":750,"context_line":"                   migrate_data\u003dmigrate_data, **args)"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def live_migration_force_complete(self, ctxt, instance, migration):"},{"line_number":753,"context_line":"        version \u003d self._ver(ctxt, \u00274.12\u0027)"},{"line_number":754,"context_line":"        kwargs \u003d {}"},{"line_number":755,"context_line":"        client \u003d self.router.client(ctxt)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_766ff791","line":752,"range":{"start_line":752,"start_character":60,"end_line":752,"end_character":69},"in_reply_to":"3fa0c359_161d5365","updated":"2018-02-08 19:38:43.000000000","message":"We still have to use it below if we need to send 4.9","commit_id":"90b01a0941bb57d1ec35751eb05af6c194d6b631"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"899970032ea703a470af6e18c801537b84483d6c","unresolved":false,"context_lines":[{"line_number":749,"context_line":"                   dest\u003ddest, block_migration\u003dblock_migration,"},{"line_number":750,"context_line":"                   migrate_data\u003dmigrate_data, **args)"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def live_migration_force_complete(self, ctxt, instance, migration):"},{"line_number":753,"context_line":"        version \u003d self._ver(ctxt, \u00274.12\u0027)"},{"line_number":754,"context_line":"        kwargs \u003d {}"},{"line_number":755,"context_line":"        client \u003d self.router.client(ctxt)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_eca7bbbc","line":752,"range":{"start_line":752,"start_character":60,"end_line":752,"end_character":69},"in_reply_to":"3fa0c359_766ff791","updated":"2018-02-08 20:16:07.000000000","message":"But we could just send None, like we do for reservations, but the compute manager proxy code doesn\u0027t actually try to pass this along.","commit_id":"90b01a0941bb57d1ec35751eb05af6c194d6b631"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"eb6596a318babf00096e1ce10379d578e594d903","unresolved":false,"context_lines":[{"line_number":749,"context_line":"                   dest\u003ddest, block_migration\u003dblock_migration,"},{"line_number":750,"context_line":"                   migrate_data\u003dmigrate_data, **args)"},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"    def live_migration_force_complete(self, ctxt, instance, migration):"},{"line_number":753,"context_line":"        version \u003d self._ver(ctxt, \u00274.12\u0027)"},{"line_number":754,"context_line":"        kwargs \u003d {}"},{"line_number":755,"context_line":"        client \u003d self.router.client(ctxt)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_cc8bdf1c","line":752,"range":{"start_line":752,"start_character":60,"end_line":752,"end_character":69},"in_reply_to":"3fa0c359_eca7bbbc","updated":"2018-02-08 20:17:14.000000000","message":"But then we wouldn\u0027t be compatible with older computes during an upgrade. If we\u0027re pinned to \u003c\u003d4.9 then we need to pass a migration id in the call. If we don\u0027t then we\u0027re not compatible.","commit_id":"90b01a0941bb57d1ec35751eb05af6c194d6b631"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d155f67f545abcde5587c46e7ac57fd73265ac7f","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"                # but the compute isn\u0027t new enough to handle that value so we"},{"line_number":1044,"context_line":"                # need to fail since the compute is too old to support it."},{"line_number":1045,"context_line":"                raise exception.MultiattachSupportNotYetAvailable()"},{"line_number":1046,"context_line":"            version \u003d self._ver(ctxt, \u00274.15\u0027)"},{"line_number":1047,"context_line":"            kw.pop(\u0027multiattach\u0027)"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"        if not client.can_send_version(version):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_1b5a5e4e","line":1046,"range":{"start_line":1046,"start_character":22,"end_line":1046,"end_character":45},"updated":"2018-02-08 19:33:27.000000000","message":"This looks out of place. If we couldn\u0027t send 5.0 above we got 4.20 and if we can\u0027t send 4.20 we send 4.15 (or try to). If we could send 5.0 above, then we won\u0027t get here.","commit_id":"90b01a0941bb57d1ec35751eb05af6c194d6b631"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"19cfd358def5bd46ce2c48a7f5548f01a12a6d92","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"                # but the compute isn\u0027t new enough to handle that value so we"},{"line_number":1044,"context_line":"                # need to fail since the compute is too old to support it."},{"line_number":1045,"context_line":"                raise exception.MultiattachSupportNotYetAvailable()"},{"line_number":1046,"context_line":"            version \u003d self._ver(ctxt, \u00274.15\u0027)"},{"line_number":1047,"context_line":"            kw.pop(\u0027multiattach\u0027)"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"        if not client.can_send_version(version):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_f608e7d9","line":1046,"range":{"start_line":1046,"start_character":22,"end_line":1046,"end_character":45},"in_reply_to":"3fa0c359_1b5a5e4e","updated":"2018-02-08 19:38:43.000000000","message":"Right, this should be just version\u003d4.15. This would return the same thing, but for clarity, it should just be explicit.","commit_id":"90b01a0941bb57d1ec35751eb05af6c194d6b631"}],"nova/conductor/tasks/migrate.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d155f67f545abcde5587c46e7ac57fd73265ac7f","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        super(MigrationTask, self).__init__(context, instance)"},{"line_number":116,"context_line":"        self.clean_shutdown \u003d clean_shutdown"},{"line_number":117,"context_line":"        self.request_spec \u003d request_spec"},{"line_number":118,"context_line":"        self.reservations \u003d reservations"},{"line_number":119,"context_line":"        self.flavor \u003d flavor"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        self.compute_rpcapi \u003d compute_rpcapi"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_967e4369","line":118,"range":{"start_line":118,"start_character":8,"end_line":118,"end_character":40},"updated":"2018-02-08 19:33:27.000000000","message":"We can remove this too now yeah?","commit_id":"90b01a0941bb57d1ec35751eb05af6c194d6b631"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"19cfd358def5bd46ce2c48a7f5548f01a12a6d92","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        super(MigrationTask, self).__init__(context, instance)"},{"line_number":116,"context_line":"        self.clean_shutdown \u003d clean_shutdown"},{"line_number":117,"context_line":"        self.request_spec \u003d request_spec"},{"line_number":118,"context_line":"        self.reservations \u003d reservations"},{"line_number":119,"context_line":"        self.flavor \u003d flavor"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        self.compute_rpcapi \u003d compute_rpcapi"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa0c359_36172ff0","line":118,"range":{"start_line":118,"start_character":8,"end_line":118,"end_character":40},"in_reply_to":"3fa0c359_967e4369","updated":"2018-02-08 19:38:43.000000000","message":"Yep.","commit_id":"90b01a0941bb57d1ec35751eb05af6c194d6b631"}]}