)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"df7c84b4b69b6de493e581bc24056881cdf4479f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"catch and handle the exception and it leads to backtrace in compute log."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic6d0ac894fbbbf03fe967ee4f9ec93b2491cf073"},{"line_number":15,"context_line":"Closes-Bug: 1737024"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf659307_3500c067","line":15,"updated":"2018-03-27 13:41:17.000000000","message":"This isn\u0027t what this bug is describing, which is failing to handle InstanceNotFound here:\n\nhttps://github.com/openstack/nova/blob/81544829d14aebaaa717ffbe6ec33c67a2f11b7f/nova/virt/libvirt/driver.py#L1772","commit_id":"03e7cd2fcd44f3dc4e476c0df1cfe67517d2728c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4492562c5d6191fb66e9485e8c3e8e06b80a2d29","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid raise InstanceNotRunning exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when instance is being snapshot, it\u0027s possible that the instance"},{"line_number":10,"context_line":"is deleted by another thread concurrently, libvirt driver translate"},{"line_number":11,"context_line":"this InstanceNotFound exception into InstanceNotRunning and we didn\u0027t"},{"line_number":12,"context_line":"catch and handle the exception and it leads to backtrace in compute log."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3fa7e38b_13b7e488","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":4},"updated":"2019-10-07 14:29:38.000000000","message":"When","commit_id":"ad78f24812df8e83c188b100d05b1c5a577c8f84"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4492562c5d6191fb66e9485e8c3e8e06b80a2d29","unresolved":false,"context_lines":[{"line_number":11,"context_line":"this InstanceNotFound exception into InstanceNotRunning and we didn\u0027t"},{"line_number":12,"context_line":"catch and handle the exception and it leads to backtrace in compute log."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also, fixes to catch the Exception and return a debug info"},{"line_number":15,"context_line":"as the instance is anyway deleted already."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ic6d0ac894fbbbf03fe967ee4f9ec93b2491cf073"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"3fa7e38b_73c098e1","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":4},"updated":"2019-10-07 14:29:38.000000000","message":"This seems either confusing or redundant so I\u0027d probably remove it.","commit_id":"ad78f24812df8e83c188b100d05b1c5a577c8f84"}],"nova/compute/manager.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1dc96d4bfe89afa2046505ecffcbb4fb5cea59c3","unresolved":false,"context_lines":[{"line_number":3338,"context_line":"            compute_utils.notify_about_instance_snapshot(context, instance,"},{"line_number":3339,"context_line":"                self.host, phase\u003dfields.NotificationPhase.END,"},{"line_number":3340,"context_line":"                snapshot_image_id\u003dimage_id)"},{"line_number":3341,"context_line":"        except (exception.InstanceNotFound,"},{"line_number":3342,"context_line":"                exception.UnexpectedDeletingTaskStateError):"},{"line_number":3343,"context_line":"            # the instance got deleted during the snapshot"},{"line_number":3344,"context_line":"            # Quickly bail out of here"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_79f092ca","line":3341,"range":{"start_line":3341,"start_character":16,"end_line":3341,"end_character":43},"updated":"2018-02-06 18:33:29.000000000","message":"This except can catch the above case also, so I am not sure the following commit message we can see backtrace actually.\n\n that can lead to exception and a backtrace in compute log\n\nDo you have any actual log and can you submit it as a bug report?\n\nOne more thing is that the corresponding unit test can be helpful.","commit_id":"99954f0f2ecf3767aae96c7ea01042d7c1ea117d"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"690bf37a7dbd23c602f04d0e9ad978b21d041526","unresolved":false,"context_lines":[{"line_number":3388,"context_line":"                                               create_info)"},{"line_number":3389,"context_line":"        except exception.InstanceNotRunning:"},{"line_number":3390,"context_line":"            # Libvirt driver can raise this exception"},{"line_number":3391,"context_line":"            LOG.debug(\u0027instance disappeared during volume snapshot\u0027,"},{"line_number":3392,"context_line":"                      instance\u003dinstance)"},{"line_number":3393,"context_line":""},{"line_number":3394,"context_line":"    @messaging.expected_exceptions(NotImplementedError)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_521c7a12","line":3391,"range":{"start_line":3391,"start_character":23,"end_line":3391,"end_character":31},"updated":"2018-05-21 07:18:03.000000000","message":"Should we capitalize this?","commit_id":"973d54b2b255d54af6d21d9cc2ccd72294e8042d"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"273816e996f68a704d2d5bf60290819d0c1ac892","unresolved":false,"context_lines":[{"line_number":3388,"context_line":"                                               create_info)"},{"line_number":3389,"context_line":"        except exception.InstanceNotRunning:"},{"line_number":3390,"context_line":"            # Libvirt driver can raise this exception"},{"line_number":3391,"context_line":"            LOG.debug(\u0027instance disappeared during volume snapshot\u0027,"},{"line_number":3392,"context_line":"                      instance\u003dinstance)"},{"line_number":3393,"context_line":""},{"line_number":3394,"context_line":"    @messaging.expected_exceptions(NotImplementedError)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_252168a0","line":3391,"range":{"start_line":3391,"start_character":23,"end_line":3391,"end_character":31},"in_reply_to":"5f7c97a3_521c7a12","updated":"2018-05-22 05:14:27.000000000","message":"Done","commit_id":"973d54b2b255d54af6d21d9cc2ccd72294e8042d"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"690bf37a7dbd23c602f04d0e9ad978b21d041526","unresolved":false,"context_lines":[{"line_number":3400,"context_line":"                                               snapshot_id, delete_info)"},{"line_number":3401,"context_line":"        except exception.InstanceNotRunning:"},{"line_number":3402,"context_line":"            # Libvirt driver can raise this exception"},{"line_number":3403,"context_line":"            LOG.debug(\u0027instance disappeared during volume snapshot\u0027,"},{"line_number":3404,"context_line":"                      instance\u003dinstance)"},{"line_number":3405,"context_line":""},{"line_number":3406,"context_line":"    @wrap_instance_fault"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_f21a6615","line":3403,"range":{"start_line":3403,"start_character":23,"end_line":3403,"end_character":31},"updated":"2018-05-21 07:18:03.000000000","message":"ditto, and the message seems not correct for this particular action? as you are delete here.","commit_id":"973d54b2b255d54af6d21d9cc2ccd72294e8042d"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"273816e996f68a704d2d5bf60290819d0c1ac892","unresolved":false,"context_lines":[{"line_number":3400,"context_line":"                                               snapshot_id, delete_info)"},{"line_number":3401,"context_line":"        except exception.InstanceNotRunning:"},{"line_number":3402,"context_line":"            # Libvirt driver can raise this exception"},{"line_number":3403,"context_line":"            LOG.debug(\u0027instance disappeared during volume snapshot\u0027,"},{"line_number":3404,"context_line":"                      instance\u003dinstance)"},{"line_number":3405,"context_line":""},{"line_number":3406,"context_line":"    @wrap_instance_fault"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_852abc7b","line":3403,"range":{"start_line":3403,"start_character":23,"end_line":3403,"end_character":31},"in_reply_to":"5f7c97a3_f21a6615","updated":"2018-05-22 05:14:27.000000000","message":"ok","commit_id":"973d54b2b255d54af6d21d9cc2ccd72294e8042d"},{"author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"change_message_id":"d6aa4caf4c32614211caf2565a911afa614cb263","unresolved":false,"context_lines":[{"line_number":3392,"context_line":"    def _post_interrupted_snapshot_cleanup(self, context, instance):"},{"line_number":3393,"context_line":"        self.driver.post_interrupted_snapshot_cleanup(context, instance)"},{"line_number":3394,"context_line":""},{"line_number":3395,"context_line":"    @messaging.expected_exceptions(NotImplementedError)"},{"line_number":3396,"context_line":"    @wrap_exception()"},{"line_number":3397,"context_line":"    def volume_snapshot_create(self, context, instance, volume_id,"},{"line_number":3398,"context_line":"                               create_info):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_808249fe","line":3395,"updated":"2018-07-06 10:11:23.000000000","message":"shouldn\u0027t we also add exception.InstanceNotRunning here?","commit_id":"209ef7e1715dea290b2b0338b9f30a525b2ca7ac"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a859e4ad39064e46925c7a50656b7838b8218953","unresolved":false,"context_lines":[{"line_number":3392,"context_line":"    def _post_interrupted_snapshot_cleanup(self, context, instance):"},{"line_number":3393,"context_line":"        self.driver.post_interrupted_snapshot_cleanup(context, instance)"},{"line_number":3394,"context_line":""},{"line_number":3395,"context_line":"    @messaging.expected_exceptions(NotImplementedError)"},{"line_number":3396,"context_line":"    @wrap_exception()"},{"line_number":3397,"context_line":"    def volume_snapshot_create(self, context, instance, volume_id,"},{"line_number":3398,"context_line":"                               create_info):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_83bce1b5","line":3395,"in_reply_to":"5f7c97a3_808249fe","updated":"2018-07-16 08:20:12.000000000","message":"no,, the exception is capatured and ignored","commit_id":"209ef7e1715dea290b2b0338b9f30a525b2ca7ac"},{"author":{"_account_id":25562,"name":"Chen","email":"dstbtgagt@foxmail.com","username":"chenn2"},"change_message_id":"d6aa4caf4c32614211caf2565a911afa614cb263","unresolved":false,"context_lines":[{"line_number":3404,"context_line":"            LOG.debug(\u0027Instance disappeared during volume snapshot create\u0027,"},{"line_number":3405,"context_line":"                      instance\u003dinstance)"},{"line_number":3406,"context_line":""},{"line_number":3407,"context_line":"    @messaging.expected_exceptions(NotImplementedError)"},{"line_number":3408,"context_line":"    @wrap_exception()"},{"line_number":3409,"context_line":"    def volume_snapshot_delete(self, context, instance, volume_id,"},{"line_number":3410,"context_line":"                               snapshot_id, delete_info):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_e070dd43","line":3407,"updated":"2018-07-06 10:11:23.000000000","message":"also exception.InstanceNotRunning here","commit_id":"209ef7e1715dea290b2b0338b9f30a525b2ca7ac"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a859e4ad39064e46925c7a50656b7838b8218953","unresolved":false,"context_lines":[{"line_number":3404,"context_line":"            LOG.debug(\u0027Instance disappeared during volume snapshot create\u0027,"},{"line_number":3405,"context_line":"                      instance\u003dinstance)"},{"line_number":3406,"context_line":""},{"line_number":3407,"context_line":"    @messaging.expected_exceptions(NotImplementedError)"},{"line_number":3408,"context_line":"    @wrap_exception()"},{"line_number":3409,"context_line":"    def volume_snapshot_delete(self, context, instance, volume_id,"},{"line_number":3410,"context_line":"                               snapshot_id, delete_info):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_43dc8916","line":3407,"in_reply_to":"5f7c97a3_e070dd43","updated":"2018-07-16 08:20:12.000000000","message":"ditto","commit_id":"209ef7e1715dea290b2b0338b9f30a525b2ca7ac"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"514e27155a13f65d27130aae157c38eec641089f","unresolved":false,"context_lines":[{"line_number":3564,"context_line":"        self.assertFalse(self.fake_image_delete_called)"},{"line_number":3565,"context_line":""},{"line_number":3566,"context_line":"    def test_snapshot_fails_with_instance_not_running(self):"},{"line_number":3567,"context_line":"        instance_not_found \u003d exception.InstanceNotRunning(instance_id\u003d\u0027uuid\u0027)"},{"line_number":3568,"context_line":"        self._test_snapshot_deletes_image_on_failure("},{"line_number":3569,"context_line":"            \u0027error\u0027, instance_not_found)"},{"line_number":3570,"context_line":"        self.assertTrue(self.fake_image_delete_called)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f6a8fd7_b879b0c8","line":3567,"range":{"start_line":3567,"start_character":8,"end_line":3567,"end_character":26},"updated":"2018-04-24 09:13:07.000000000","message":"make this to instance_not_running otherwise it is confusing,","commit_id":"7718a0fa61b89331a8e94dbc814de9d0c6718f88"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9da0b31cf33c19a28e8cc1030c8a2b58d34056cb","unresolved":false,"context_lines":[{"line_number":3564,"context_line":"        self.assertFalse(self.fake_image_delete_called)"},{"line_number":3565,"context_line":""},{"line_number":3566,"context_line":"    def test_snapshot_fails_with_instance_not_running(self):"},{"line_number":3567,"context_line":"        instance_not_found \u003d exception.InstanceNotRunning(instance_id\u003d\u0027uuid\u0027)"},{"line_number":3568,"context_line":"        self._test_snapshot_deletes_image_on_failure("},{"line_number":3569,"context_line":"            \u0027error\u0027, instance_not_found)"},{"line_number":3570,"context_line":"        self.assertTrue(self.fake_image_delete_called)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f6a8fd7_6b3a00ce","line":3567,"range":{"start_line":3567,"start_character":8,"end_line":3567,"end_character":26},"in_reply_to":"9f6a8fd7_b879b0c8","updated":"2018-04-28 06:54:48.000000000","message":"ok, will do","commit_id":"7718a0fa61b89331a8e94dbc814de9d0c6718f88"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"905e0f867f686223ebd32eda0eeaec694a91e6cd","unresolved":false,"context_lines":[{"line_number":1373,"context_line":"    def test_volume_snapshot_create_instance_not_running(self, mock_debug):"},{"line_number":1374,"context_line":"        with mock.patch.object(self.compute.driver,"},{"line_number":1375,"context_line":"                               \u0027volume_snapshot_create\u0027) as mock_create:"},{"line_number":1376,"context_line":"            exc \u003d exception.InstanceNotRunning(instace_id\u003d\u0027fake_id\u0027)"},{"line_number":1377,"context_line":"            mock_create.side_effect \u003d exc"},{"line_number":1378,"context_line":"            self.compute.volume_snapshot_create(self.context,"},{"line_number":1379,"context_line":"                self.instance_object, \u0027fake_id\u0027, {})"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_8ec94a7a","line":1376,"range":{"start_line":1376,"start_character":47,"end_line":1376,"end_character":57},"updated":"2018-07-17 06:55:50.000000000","message":"instance_id","commit_id":"354d1baef41c64e5a2731ec63c6f70e73dd9b180"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8a7b90a68fd324d348320a7681ecba047bca5e5f","unresolved":false,"context_lines":[{"line_number":1373,"context_line":"    def test_volume_snapshot_create_instance_not_running(self, mock_debug):"},{"line_number":1374,"context_line":"        with mock.patch.object(self.compute.driver,"},{"line_number":1375,"context_line":"                               \u0027volume_snapshot_create\u0027) as mock_create:"},{"line_number":1376,"context_line":"            exc \u003d exception.InstanceNotRunning(instace_id\u003d\u0027fake_id\u0027)"},{"line_number":1377,"context_line":"            mock_create.side_effect \u003d exc"},{"line_number":1378,"context_line":"            self.compute.volume_snapshot_create(self.context,"},{"line_number":1379,"context_line":"                self.instance_object, \u0027fake_id\u0027, {})"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_783957a1","line":1376,"range":{"start_line":1376,"start_character":47,"end_line":1376,"end_character":57},"in_reply_to":"5f7c97a3_8ec94a7a","updated":"2019-10-07 13:44:01.000000000","message":"Done","commit_id":"354d1baef41c64e5a2731ec63c6f70e73dd9b180"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"905e0f867f686223ebd32eda0eeaec694a91e6cd","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"    def test_volume_snapshot_delete_instance_not_running(self, mock_debug):"},{"line_number":1396,"context_line":"        with mock.patch.object(self.compute.driver,"},{"line_number":1397,"context_line":"                               \u0027volume_snapshot_delete\u0027) as mock_delete:"},{"line_number":1398,"context_line":"            exc \u003d exception.InstanceNotRunning(instace_id\u003d\u0027fake_id\u0027)"},{"line_number":1399,"context_line":"            mock_delete.side_effect \u003d exc"},{"line_number":1400,"context_line":"            self.compute.volume_snapshot_create(self.context,"},{"line_number":1401,"context_line":"                self.instance_object, \u0027fake_id\u0027, {})"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_2ec27655","line":1398,"range":{"start_line":1398,"start_character":47,"end_line":1398,"end_character":57},"updated":"2018-07-17 06:55:50.000000000","message":"ditto","commit_id":"354d1baef41c64e5a2731ec63c6f70e73dd9b180"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8a7b90a68fd324d348320a7681ecba047bca5e5f","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"    def test_volume_snapshot_delete_instance_not_running(self, mock_debug):"},{"line_number":1396,"context_line":"        with mock.patch.object(self.compute.driver,"},{"line_number":1397,"context_line":"                               \u0027volume_snapshot_delete\u0027) as mock_delete:"},{"line_number":1398,"context_line":"            exc \u003d exception.InstanceNotRunning(instace_id\u003d\u0027fake_id\u0027)"},{"line_number":1399,"context_line":"            mock_delete.side_effect \u003d exc"},{"line_number":1400,"context_line":"            self.compute.volume_snapshot_create(self.context,"},{"line_number":1401,"context_line":"                self.instance_object, \u0027fake_id\u0027, {})"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_5836dbb6","line":1398,"range":{"start_line":1398,"start_character":47,"end_line":1398,"end_character":57},"in_reply_to":"5f7c97a3_2ec27655","updated":"2019-10-07 13:44:01.000000000","message":"Done","commit_id":"354d1baef41c64e5a2731ec63c6f70e73dd9b180"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8a7b90a68fd324d348320a7681ecba047bca5e5f","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"                               \u0027volume_snapshot_delete\u0027) as mock_delete:"},{"line_number":1398,"context_line":"            exc \u003d exception.InstanceNotRunning(instace_id\u003d\u0027fake_id\u0027)"},{"line_number":1399,"context_line":"            mock_delete.side_effect \u003d exc"},{"line_number":1400,"context_line":"            self.compute.volume_snapshot_create(self.context,"},{"line_number":1401,"context_line":"                self.instance_object, \u0027fake_id\u0027, {})"},{"line_number":1402,"context_line":"            mock_debug.assert_called_once_with(\u0027Instance disappeared during \u0027"},{"line_number":1403,"context_line":"                \u0027volume snapshot delete\u0027, instance\u003dself.instance_object)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_18838306","line":1400,"range":{"start_line":1400,"start_character":41,"end_line":1400,"end_character":47},"updated":"2019-10-07 13:44:01.000000000","message":"delete","commit_id":"354d1baef41c64e5a2731ec63c6f70e73dd9b180"}]}