)]}'
{"nova/network/manager.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"07b70611c819550d8a8e315fa8f7d3baf44f46fd","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        \"\"\"Sits in between _allocate_fixed_ips and allocate_fixed_ip to"},{"line_number":222,"context_line":"        perform network lookup on the far side of rpc."},{"line_number":223,"context_line":"        \"\"\""},{"line_number":224,"context_line":"        context.update_store()"},{"line_number":225,"context_line":"        network \u003d self._get_network_by_id(context, network_id)"},{"line_number":226,"context_line":"        return self.allocate_fixed_ip(context, instance_id, network, **kwargs)"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAE3%2F%2F9ro%3D","line":224,"updated":"2012-03-15 20:20:40.000000000","message":"The spawn above actually calls rpc.call.   Since _rpc_allocate_fixed_ip is called on worker side, the context will be updated already in kombu\u0027s _process_data().  So, the update_store() here is redundant.\n\nI think maybe I\u0027d add something like this:\n\ndef _threaded_rpc_call(self, context, topic, message):\n    context.update_store()\n    rpc.call(context, topic, message)\n\nThen change the spawn_n() above to use this?   Or at least, some idea similar to this.\n\nI\u0027m not sure if rpc.call actually logs anything, so it may not be terribly important to worry about at all...","commit_id":"744342c598fe99c9d69a2617755c10c41ae9b438"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"398ce3b9c635873628e1798e8d623e59c3155368","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        \"\"\"Sits in between _allocate_fixed_ips and allocate_fixed_ip to"},{"line_number":222,"context_line":"        perform network lookup on the far side of rpc."},{"line_number":223,"context_line":"        \"\"\""},{"line_number":224,"context_line":"        context.update_store()"},{"line_number":225,"context_line":"        network \u003d self._get_network_by_id(context, network_id)"},{"line_number":226,"context_line":"        return self.allocate_fixed_ip(context, instance_id, network, **kwargs)"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAE3%2F%2F9rA%3D","line":224,"in_reply_to":"AAAAE3%2F%2F9ro%3D","updated":"2012-03-15 20:33:38.000000000","message":"good point i will remove these.  I think we can handle missing the potential logs on the calling side.","commit_id":"744342c598fe99c9d69a2617755c10c41ae9b438"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"07b70611c819550d8a8e315fa8f7d3baf44f46fd","unresolved":false,"context_lines":[{"line_number":1478,"context_line":"        green_pool.waitall()"},{"line_number":1479,"context_line":""},{"line_number":1480,"context_line":"    def rpc_setup_network_on_host(self, context, network_id, teardown):"},{"line_number":1481,"context_line":"        context.update_store()"},{"line_number":1482,"context_line":"        if teardown:"},{"line_number":1483,"context_line":"            call_func \u003d self._teardown_network_on_host"},{"line_number":1484,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAE3%2F%2F9rg%3D","line":1481,"updated":"2012-03-15 20:20:40.000000000","message":"Same thing as above.","commit_id":"744342c598fe99c9d69a2617755c10c41ae9b438"}]}