)]}'
{"nova/cmd/manage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff28372d87842e8c2e5852f8d81ec5436edf25a1","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"            print(_(\u0027There are instances on the host %s.\u0027) % host)"},{"line_number":1584,"context_line":"            return 4"},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"        for node in nodes:"},{"line_number":1587,"context_line":"            node.mapped \u003d 0"},{"line_number":1588,"context_line":"            node.save()"},{"line_number":1589,"context_line":""},{"line_number":1590,"context_line":"        host_mapping.destroy()"},{"line_number":1591,"context_line":"        return 0"}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_5cb95612","line":1588,"range":{"start_line":1586,"start_character":8,"end_line":1588,"end_character":23},"updated":"2018-03-15 16:41:35.000000000","message":"Doing the same thing as Takashi fixed in delete_host earlier.","commit_id":"2db015777d38fe382d6c3f58763cfb9c1bb8572d"}],"nova/tests/functional/test_nova_manage.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1a7444c16668328dd7da53e7ff416170f5575a46","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        self.assertEqual(1, len(cns))"},{"line_number":319,"context_line":"        self.assertEqual(0, cns[0].mapped)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def test_delete_cell(self):"},{"line_number":322,"context_line":"        cells \u003d objects.CellMappingList.get_all(self.context)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        self.commands.discover_hosts()"}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_b2272413","line":321,"updated":"2018-03-08 18:35:56.000000000","message":"This concerned me because it seems like we don\u0027t have other tests for delete_cell, which would mean the non-force cases aren\u0027t tested. However, we do under unit/ .. This could be named something like \"test_delete_cell_force_unmaps_computes\" or something, but not critical.","commit_id":"2db015777d38fe382d6c3f58763cfb9c1bb8572d"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"7a8ff5ffaaf4c959848a16e2b27dea9075e4c7c9","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        self.assertEqual(1, len(cns))"},{"line_number":319,"context_line":"        self.assertEqual(0, cns[0].mapped)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    def test_delete_cell(self):"},{"line_number":322,"context_line":"        cells \u003d objects.CellMappingList.get_all(self.context)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"        self.commands.discover_hosts()"}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_98bc7f06","line":321,"in_reply_to":"df7087c5_b2272413","updated":"2018-03-08 20:09:15.000000000","message":"Yes, will do this clean up in its follow up patch where we purge the compute node and resource provider records totally - https://review.openstack.org/#/c/546660/1/nova/tests/functional/test_nova_manage.py","commit_id":"2db015777d38fe382d6c3f58763cfb9c1bb8572d"}]}