)]}'
{"nova/cmd/baremetal_deploy_helper.py":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"7e24d4de5517f89e18910e61058e51dd250798d6","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"def work_on_disk("},{"line_number":188,"context_line":"        dev, root_mb, swap_mb, ephemeral_mb, image_path, preserve_ephemeral):"},{"line_number":189,"context_line":"    \"\"\"Creates partitions and write an image to the root partition."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    :param preserve_ephemeral: If True, no filesystem is written to the"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2B4EY%3D","line":188,"updated":"2013-11-19 03:16:21.000000000","message":"nit: the alignment here looks really odd, can we make it better?\nlike:\ndef work_on_disk(dev, root_mb, swap_mb, ephemeral_mb, image_path, \n                 preserve_ephemeral):","commit_id":"47a7b772246d74154a3fbefc6dca1548d4296049"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"b0a06e7f86f6ca03f2db41c908b216e29013eff4","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"def work_on_disk("},{"line_number":188,"context_line":"        dev, root_mb, swap_mb, ephemeral_mb, image_path, preserve_ephemeral):"},{"line_number":189,"context_line":"    \"\"\"Creates partitions and write an image to the root partition."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    :param preserve_ephemeral: If True, no filesystem is written to the"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BYpM%3D","line":188,"in_reply_to":"AAAATn%2F%2B4EY%3D","updated":"2013-11-26 16:49:25.000000000","message":"Done","commit_id":"47a7b772246d74154a3fbefc6dca1548d4296049"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"339e2e31e1526df7ca979174f8d49fd8397409bc","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        return"},{"line_number":213,"context_line":"    dd(image_path, root_part)"},{"line_number":214,"context_line":"    mkswap(swap_part)"},{"line_number":215,"context_line":"    if (ephemeral_mb and not preserve_ephemeral"},{"line_number":216,"context_line":"            and not is_block_device(ephemeral_part)):"},{"line_number":217,"context_line":"        LOG.warn(_(\"ephemeral device \u0027%s\u0027 not found\"), ephemeral_part)"},{"line_number":218,"context_line":"    elif ephemeral_mb and not preserve_ephemeral:"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAATn%2F9%2Flc%3D","line":215,"updated":"2013-12-03 17:22:54.000000000","message":"nit:\n\nif ephemeral_mb and not preserve_ephemeral:\n    if is_block_device(ephemeral_part):\n        mkfs_ephemeral(ephemeral_part)\n    else:\n        LOG.warn(...","commit_id":"a20eed1ed242d226a5cc591257e1743741f41a20"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"d848c5db2ba21fa27eea5ec01dd21ea142f7ee4a","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    if not is_block_device(dev):"},{"line_number":204,"context_line":"        LOG.warn(_(\"parent device \u0027%s\u0027 not found\"), dev)"},{"line_number":205,"context_line":"        return"},{"line_number":206,"context_line":"    make_partitions(dev, root_mb, swap_mb, ephemeral_mb)"},{"line_number":207,"context_line":"    if not is_block_device(root_part):"},{"line_number":208,"context_line":"        LOG.warn(_(\"root device \u0027%s\u0027 not found\"), root_part)"},{"line_number":209,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAATn%2F9Y%2B4%3D","line":206,"updated":"2013-12-12 00:07:14.000000000","message":"I believe we are assuming that the root_mb, swap_mb, and ephemeral_mb, have not changed. It is possible that the flavor itself has been modified. If they do change, we will torch the ephemeral_mb.\n\nI believe we have two choices then.\n\na. Document the fact\nb. Fail if preserve_ephemeral is true and we will change the size of the ephemeral partition.\n\nI think (a) is fine, but (b) would not be expensive and would be a more resilient response to the situation.","commit_id":"01a8a34dd2e9f86571e68c4f90a77bf94019a404"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"1cf01324b495974e04e16aa98310176ef98bf310","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            and not is_block_device(ephemeral_part)):"},{"line_number":217,"context_line":"        LOG.warn(_(\"ephemeral device \u0027%s\u0027 not found\"), ephemeral_part)"},{"line_number":218,"context_line":"    elif ephemeral_mb and not preserve_ephemeral:"},{"line_number":219,"context_line":"        mkfs_ephemeral(ephemeral_part)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    try:"},{"line_number":222,"context_line":"        root_uuid \u003d block_uuid(root_part)"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAATn%2F87zA%3D","line":219,"updated":"2013-12-18 16:20:21.000000000","message":"IMO more readable:\n\nif ephemeral_mb and not preserve_ephemeral:\n    if is_block_device(ephemeral_part):\n        mkfs_ephemeral(ephemeral_part)\n    else:\n        LOG.warn(_(\"ephemeral device \u0027%s\u0027 not found\"), ephemeral_part)","commit_id":"eb4badf1a73c16ee0530e4cefa065d51e394747a"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"8c817473c80bc412b20c447d1656215f72f844c4","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    :param preserve_ephemeral: If True, no filesystem is written to the"},{"line_number":196,"context_line":"        ephemeral block device, preserving whatever content it had (if the"},{"line_number":197,"context_line":"        partition table has not changed)."},{"line_number":198,"context_line":"    \"\"\""},{"line_number":199,"context_line":"    def raise_exception(msg):"},{"line_number":200,"context_line":"        LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":38,"id":"AAAAUH%2F%2FO8M%3D","line":197,"updated":"2014-01-16 04:24:42.000000000","message":"Wouldn\u0027t it be better to provide documentation for all params since we\u0027re adding documentation for the one we\u0027re adding?","commit_id":"7bc04b4ee708b442ecdb8a5e1af4a23484f86cda"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"a9049828c135c595e5523a5addba489df9adee02","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    :param preserve_ephemeral: If True, no filesystem is written to the"},{"line_number":196,"context_line":"        ephemeral block device, preserving whatever content it had (if the"},{"line_number":197,"context_line":"        partition table has not changed)."},{"line_number":198,"context_line":"    \"\"\""},{"line_number":199,"context_line":"    def raise_exception(msg):"},{"line_number":200,"context_line":"        LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":38,"id":"AAAAUH%2F%2FOeU%3D","line":197,"in_reply_to":"AAAAUH%2F%2FO8M%3D","updated":"2014-01-16 06:49:35.000000000","message":"That would be a different patch. You\u0027re most welcome to add it on top of this one :)","commit_id":"7bc04b4ee708b442ecdb8a5e1af4a23484f86cda"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"8c817473c80bc412b20c447d1656215f72f844c4","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    :param preserve_ephemeral: If True, no filesystem is written to the"},{"line_number":241,"context_line":"        ephemeral block device, preserving whatever content it had (if the"},{"line_number":242,"context_line":"        partition table has not changed)."},{"line_number":243,"context_line":"    \"\"\""},{"line_number":244,"context_line":"    dev \u003d get_dev(address, port, iqn, lun)"},{"line_number":245,"context_line":"    image_mb \u003d get_image_mb(image_path)"},{"line_number":246,"context_line":"    if image_mb \u003e root_mb:"}],"source_content_type":"text/x-python","patch_set":38,"id":"AAAAUH%2F%2FO7w%3D","line":243,"updated":"2014-01-16 04:24:42.000000000","message":"Wouldn\u0027t it be better to provide documentation for all params since we\u0027re adding documentation for the one we\u0027re adding?","commit_id":"7bc04b4ee708b442ecdb8a5e1af4a23484f86cda"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"a9049828c135c595e5523a5addba489df9adee02","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    :param preserve_ephemeral: If True, no filesystem is written to the"},{"line_number":241,"context_line":"        ephemeral block device, preserving whatever content it had (if the"},{"line_number":242,"context_line":"        partition table has not changed)."},{"line_number":243,"context_line":"    \"\"\""},{"line_number":244,"context_line":"    dev \u003d get_dev(address, port, iqn, lun)"},{"line_number":245,"context_line":"    image_mb \u003d get_image_mb(image_path)"},{"line_number":246,"context_line":"    if image_mb \u003e root_mb:"}],"source_content_type":"text/x-python","patch_set":38,"id":"AAAAUH%2F%2FOeQ%3D","line":243,"in_reply_to":"AAAAUH%2F%2FO7w%3D","updated":"2014-01-16 06:49:35.000000000","message":"Ditto.","commit_id":"7bc04b4ee708b442ecdb8a5e1af4a23484f86cda"}],"nova/tests/virt/baremetal/test_nova_baremetal_deploy_helper.py":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"7e24d4de5517f89e18910e61058e51dd250798d6","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        bmdh.discovery(address, port)"},{"line_number":303,"context_line":"        bmdh.login_iscsi(address, port, iqn)"},{"line_number":304,"context_line":"        bmdh.work_on_disk("},{"line_number":305,"context_line":"            dev, root_mb, swap_mb, ephemeral_mb, image_path, False). \\"},{"line_number":306,"context_line":"                AndRaise(TestException)"},{"line_number":307,"context_line":"        bmdh.logout_iscsi(address, port, iqn)"},{"line_number":308,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2B4EQ%3D","line":305,"updated":"2013-11-19 03:16:21.000000000","message":"ditto","commit_id":"47a7b772246d74154a3fbefc6dca1548d4296049"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"b0a06e7f86f6ca03f2db41c908b216e29013eff4","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        bmdh.discovery(address, port)"},{"line_number":303,"context_line":"        bmdh.login_iscsi(address, port, iqn)"},{"line_number":304,"context_line":"        bmdh.work_on_disk("},{"line_number":305,"context_line":"            dev, root_mb, swap_mb, ephemeral_mb, image_path, False). \\"},{"line_number":306,"context_line":"                AndRaise(TestException)"},{"line_number":307,"context_line":"        bmdh.logout_iscsi(address, port, iqn)"},{"line_number":308,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2BYpI%3D","line":305,"in_reply_to":"AAAATn%2F%2B4EQ%3D","updated":"2013-11-26 16:49:25.000000000","message":"Done","commit_id":"47a7b772246d74154a3fbefc6dca1548d4296049"}]}