)]}'
{"nova/tests/unit/virt/zvm/test_driver.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a5fcdd10e215c2336884ea562f8562d698e92b73","unresolved":false,"context_lines":[{"line_number":535,"context_line":"    def test_get_console_output(self, call):"},{"line_number":536,"context_line":"        call.return_value \u003d \u0027console output\u0027"},{"line_number":537,"context_line":"        outputs \u003d self.driver.get_console_output(None, self._instance)"},{"line_number":538,"context_line":"        call.test_assert_called_once_with(\u0027guest_get_console_output\u0027,"},{"line_number":539,"context_line":"                                          \u0027test0001\u0027)"},{"line_number":540,"context_line":"        self.assertEqual(\u0027console output\u0027, outputs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_5b19ed85","line":538,"range":{"start_line":538,"start_character":13,"end_line":538,"end_character":41},"updated":"2018-02-19 03:08:33.000000000","message":"It should be \u0027assert_called_once_with\u0027.","commit_id":"71a9edd84c20da7be6e29c5a8677ac4449a69022"},{"author":{"_account_id":5930,"name":"Huang Rui","email":"bjhuangr@cn.ibm.com","username":"bjhuangr"},"change_message_id":"b7640bcf9047b9ddc084c7e700f937feeb3ae1f3","unresolved":false,"context_lines":[{"line_number":535,"context_line":"    def test_get_console_output(self, call):"},{"line_number":536,"context_line":"        call.return_value \u003d \u0027console output\u0027"},{"line_number":537,"context_line":"        outputs \u003d self.driver.get_console_output(None, self._instance)"},{"line_number":538,"context_line":"        call.test_assert_called_once_with(\u0027guest_get_console_output\u0027,"},{"line_number":539,"context_line":"                                          \u0027test0001\u0027)"},{"line_number":540,"context_line":"        self.assertEqual(\u0027console output\u0027, outputs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_2bc9c224","line":538,"range":{"start_line":538,"start_character":13,"end_line":538,"end_character":41},"in_reply_to":"3fa0c359_5b19ed85","updated":"2018-02-23 05:44:08.000000000","message":"Done","commit_id":"71a9edd84c20da7be6e29c5a8677ac4449a69022"}],"nova/virt/zvm/driver.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"72728d5e6fc573320457380806852cfbaefdf99d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            self._guest_power_action(instance, \u0027guest_reset\u0027)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def get_console_output(self, context, instance):"},{"line_number":170,"context_line":"        return self._hypervisor.guest_get_console_output(instance.name)"}],"source_content_type":"text/x-python","patch_set":25,"id":"bf659307_cbff39ff","line":170,"updated":"2018-04-10 22:36:25.000000000","message":"So, I\u0027m a bit concerned about the uniqueness of instance names now that I think about it. What if I set my instance name template to something which gives every instance the same name by mistake? Shouldn\u0027t we be using the instance uuid, which is guaranteed to be unique to identify the instance?","commit_id":"2eae33dff0968945c08805ebe6bbd3482d8e9df2"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"cefa577857f2eacc21dfd6f86bcf779dba598617","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            self._guest_power_action(instance, \u0027guest_reset\u0027)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def get_console_output(self, context, instance):"},{"line_number":170,"context_line":"        return self._hypervisor.guest_get_console_output(instance.name)"}],"source_content_type":"text/x-python","patch_set":25,"id":"bf659307_eb331daa","line":170,"in_reply_to":"bf659307_cbff39ff","updated":"2018-04-10 22:50:48.000000000","message":"Instance names are guaranteed to be unique:\n\nhttps://review.openstack.org/#/c/527658/31/nova/virt/zvm/guest.py@72\nhttps://review.openstack.org/#/c/527658/31/nova/virt/zvm/hypervisor.py@70","commit_id":"2eae33dff0968945c08805ebe6bbd3482d8e9df2"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"8af0444862f06559608734c1ac5ef95f01b8a1ac","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            self._guest_power_action(instance, \u0027guest_reset\u0027)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def get_console_output(self, context, instance):"},{"line_number":170,"context_line":"        return self._hypervisor.guest_get_console_output(instance.name)"}],"source_content_type":"text/x-python","patch_set":25,"id":"bf659307_a86c40d0","line":170,"in_reply_to":"bf659307_eb331daa","updated":"2018-04-27 04:42:56.000000000","message":"the name will be generated by template, so as Eric mentioned, should be ok","commit_id":"2eae33dff0968945c08805ebe6bbd3482d8e9df2"}],"nova/virt/zvm/hypervisor.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0dbf2e873b136fe407de9213f0d2d7fad1b2195e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    def guest_reset(self, name):"},{"line_number":144,"context_line":"        self._reqh.call(\u0027guest_reset\u0027, name)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def guest_get_console_output(self, name):"},{"line_number":147,"context_line":"        return self._reqh.call(\u0027guest_get_console_output\u0027, name)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def image_query(self, imagename):"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_bb457872","line":146,"updated":"2018-05-24 11:48:05.000000000","message":"Please add dosctstring here with the return value for zVM","commit_id":"b82e8ac0720cf2537f92c8362e4228332cc2f469"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"29767b610f0c1ef0e5a594e61e31d144e8c03f71","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    def guest_reset(self, name):"},{"line_number":144,"context_line":"        self._reqh.call(\u0027guest_reset\u0027, name)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def guest_get_console_output(self, name):"},{"line_number":147,"context_line":"        return self._reqh.call(\u0027guest_get_console_output\u0027, name)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def image_query(self, imagename):"}],"source_content_type":"text/x-python","patch_set":46,"id":"5f7c97a3_b45b3ef4","line":146,"in_reply_to":"5f7c97a3_bb457872","updated":"2018-05-25 04:27:23.000000000","message":"Done, thanks, will do","commit_id":"b82e8ac0720cf2537f92c8362e4228332cc2f469"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c0d9d288b3a16bcab633e20b7eab5f21f221a644","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    def guest_reset(self, name):"},{"line_number":147,"context_line":"        self._reqh.call(\u0027guest_reset\u0027, name)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def guest_get_console_output(self, name):"},{"line_number":150,"context_line":"        \"\"\"get console out put of the given instance"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        :returns: The output of the console of the instace, in string format."}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_4a42f13f","line":149,"updated":"2018-05-31 10:55:11.000000000","message":"You need to add assertion here","commit_id":"704db4a0d65fc5d9462dede4f1223e8e8b779c4c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"cca26eb9e09d99f938f04851e575a3f2283854a2","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    def guest_reset(self, name):"},{"line_number":147,"context_line":"        self._reqh.call(\u0027guest_reset\u0027, name)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def guest_get_console_output(self, name):"},{"line_number":150,"context_line":"        \"\"\"get console out put of the given instance"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        :returns: The output of the console of the instace, in string format."}],"source_content_type":"text/x-python","patch_set":47,"id":"5f7c97a3_cbdef50f","line":149,"in_reply_to":"5f7c97a3_4a42f13f","updated":"2018-06-01 06:21:25.000000000","message":"Done","commit_id":"704db4a0d65fc5d9462dede4f1223e8e8b779c4c"}]}