)]}'
{"nova/api/openstack/placement/handlers/inventory.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"57b2671f5463e67aa90b8f15f5c21a09635ffcb5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from nova.api.openstack.placement.schemas import inventory as schema"},{"line_number":23,"context_line":"from nova.api.openstack.placement import util"},{"line_number":24,"context_line":"from nova.api.openstack.placement import wsgi_wrapper"},{"line_number":25,"context_line":"from nova.db import constants"},{"line_number":26,"context_line":"from nova import exception"},{"line_number":27,"context_line":"from nova.i18n import _"},{"line_number":28,"context_line":"from nova.objects import resource_provider as rp_obj"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_c59d9ebc","line":25,"updated":"2018-02-13 05:48:18.000000000","message":"db_const might be a more appropriate name","commit_id":"c88ffdce498b70cb7a59757017774ad7c7748a42"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"8d16fd25e987d288896e6810b9a7d71fae89e7fc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from nova.api.openstack.placement.schemas import inventory as schema"},{"line_number":23,"context_line":"from nova.api.openstack.placement import util"},{"line_number":24,"context_line":"from nova.api.openstack.placement import wsgi_wrapper"},{"line_number":25,"context_line":"from nova.db import constants"},{"line_number":26,"context_line":"from nova import exception"},{"line_number":27,"context_line":"from nova.i18n import _"},{"line_number":28,"context_line":"from nova.objects import resource_provider as rp_obj"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_ebf18196","line":25,"in_reply_to":"3fa0c359_1390a949","updated":"2018-02-13 14:41:03.000000000","message":"the latter...\n\nfrom nova.db import constants as db_const\n\nBasically, \"what is the best way to compress this nice long descriptive package name into something shorter but still descriptive\". As long as it\u0027s not misused, I\u0027ve always felt that improves readability.","commit_id":"c88ffdce498b70cb7a59757017774ad7c7748a42"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"0d49ef37a9534eeb2e498fe7303164e275f2b87a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from nova.api.openstack.placement.schemas import inventory as schema"},{"line_number":23,"context_line":"from nova.api.openstack.placement import util"},{"line_number":24,"context_line":"from nova.api.openstack.placement import wsgi_wrapper"},{"line_number":25,"context_line":"from nova.db import constants"},{"line_number":26,"context_line":"from nova import exception"},{"line_number":27,"context_line":"from nova.i18n import _"},{"line_number":28,"context_line":"from nova.objects import resource_provider as rp_obj"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_1390a949","line":25,"in_reply_to":"3fa0c359_c59d9ebc","updated":"2018-02-13 09:59:24.000000000","message":"Yeah, I prevaricated and eventually decided I couldn\u0027t decide so would let the review process help.\n\nI didn\u0027t want to name the actual file db_const because it was already in the nova.db package. And I\u0027ve never really like the \"import foo as bar\" construct.\n\nWhich are you suggesting?","commit_id":"c88ffdce498b70cb7a59757017774ad7c7748a42"}],"nova/api/openstack/placement/schemas/inventory.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"57b2671f5463e67aa90b8f15f5c21a09635ffcb5","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"import copy"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from nova.db import constants"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"RESOURCE_CLASS_IDENTIFIER \u003d \"^[A-Z0-9_]+$\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_c586fe66","line":16,"updated":"2018-02-13 05:48:18.000000000","message":"ditto","commit_id":"c88ffdce498b70cb7a59757017774ad7c7748a42"}],"nova/db/api.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"57b2671f5463e67aa90b8f15f5c21a09635ffcb5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from oslo_log import log as logging"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from nova.cells import rpcapi as cells_rpcapi"},{"line_number":34,"context_line":"from nova.db.constants import *  # noqa"},{"line_number":35,"context_line":"import nova.conf"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_e5d77a4a","line":34,"updated":"2018-02-13 05:48:18.000000000","message":"I\u0027m not a fan of import * and with only 2 const it would be easy to call them both out here explicitly. Then you\u0027re no longer importing other constants added in future by default.","commit_id":"c88ffdce498b70cb7a59757017774ad7c7748a42"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"0d49ef37a9534eeb2e498fe7303164e275f2b87a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from oslo_log import log as logging"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from nova.cells import rpcapi as cells_rpcapi"},{"line_number":34,"context_line":"from nova.db.constants import *  # noqa"},{"line_number":35,"context_line":"import nova.conf"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_f3917d48","line":34,"in_reply_to":"3fa0c359_e5d77a4a","updated":"2018-02-13 09:59:24.000000000","message":"Me neither, but this was done under the assumption that more constants will be added and people would like to continue to access them from \u0027db.\u0027\n\nThat\u0027s probably a lame excuse. I\u0027ll change it as you suggest.","commit_id":"c88ffdce498b70cb7a59757017774ad7c7748a42"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1c021540a5f62ed862ffafcd38e1eae2c7a1dd84","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from nova.cells import rpcapi as cells_rpcapi"},{"line_number":34,"context_line":"# NOTE(cdent): These constants are explicitly imported into this module"},{"line_number":35,"context_line":"# to preserve existing references to them."},{"line_number":36,"context_line":"from nova.db.constants import MAX_INT, SQL_SP_FLOAT_MAX  # noqa"},{"line_number":37,"context_line":"import nova.conf"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_d7252dc3","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":63},"updated":"2018-02-26 19:46:23.000000000","message":"It is better to avoid using noqa as possible, so how about\n\n from nova.db import constants\n\nand\n\n # NOTE(cdent): These constants ..\n MAX_INT \u003d constants.MAX_INT\n SQL_SP_FLOAT_MAX \u003d constants.SQL_SP_FLOAT_MAX\n\n?","commit_id":"0f6333187bef85c988137ce513f4aeeb086796d4"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"526d0c07c649b2b18c71a4ea7e70412e684ae6f5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from nova.cells import rpcapi as cells_rpcapi"},{"line_number":34,"context_line":"# NOTE(cdent): These constants are explicitly imported into this module"},{"line_number":35,"context_line":"# to preserve existing references to them."},{"line_number":36,"context_line":"from nova.db.constants import MAX_INT, SQL_SP_FLOAT_MAX  # noqa"},{"line_number":37,"context_line":"import nova.conf"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_220c4aeb","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":63},"in_reply_to":"3fa0c359_d7252dc3","updated":"2018-02-27 09:23:06.000000000","message":"Yeah, good idea, I\u0027ll fix that when I do the rebase.","commit_id":"0f6333187bef85c988137ce513f4aeeb086796d4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d792b33e188a85bc5ed100cc6e214f7241dca3d0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from oslo_log import log as logging"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from nova.cells import rpcapi as cells_rpcapi"},{"line_number":34,"context_line":"from nova.db import constants"},{"line_number":35,"context_line":"import nova.conf"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f9dbf25_c4bb340c","line":34,"updated":"2018-02-27 12:41:55.000000000","message":"We just need to put this line after nova.conf for the order:\n\nhttp://logs.openstack.org/69/543469/4/check/openstack-tox-pep8/5a82191/job-output.txt.gz#_2018-02-27_09_47_54_190204","commit_id":"297b85f328f025628572652bb9d9b1f0d2cd94ac"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"2e49b31567930bc1cb5039cda5737215b515110c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from oslo_log import log as logging"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from nova.cells import rpcapi as cells_rpcapi"},{"line_number":34,"context_line":"from nova.db import constants"},{"line_number":35,"context_line":"import nova.conf"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f9dbf25_4fa3bd50","line":34,"in_reply_to":"1f9dbf25_c4bb340c","updated":"2018-02-27 13:50:45.000000000","message":"Sigh, thanks, was rushing to push code before lunch. :)","commit_id":"297b85f328f025628572652bb9d9b1f0d2cd94ac"}]}