)]}'
{"nova/api/openstack/placement/wsgi.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a31da51ae40a835880dfc6821b7594ef64a8d344","unresolved":false,"context_lines":[{"line_number":73,"context_line":"def init_application():"},{"line_number":74,"context_line":"    # initialize the config system"},{"line_number":75,"context_line":"    conffile \u003d _get_config_file()"},{"line_number":76,"context_line":"    _parse_args([], default_config_files\u003d[conffile])"},{"line_number":77,"context_line":"    db_api.configure(conf.CONF)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # initialize the logging system"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_1f62f5d8","line":76,"range":{"start_line":76,"start_character":4,"end_line":76,"end_character":52},"updated":"2018-02-13 03:12:58.000000000","message":"guess it would be better to add a comment here","commit_id":"602b82a15fb37eb8bd2b2bee6e30b5f483b9a44a"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"bbaebf4291ca17000b7fcb87d8ac8dcff8019ad5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"def init_application():"},{"line_number":74,"context_line":"    # initialize the config system"},{"line_number":75,"context_line":"    conffile \u003d _get_config_file()"},{"line_number":76,"context_line":"    _parse_args([], default_config_files\u003d[conffile])"},{"line_number":77,"context_line":"    db_api.configure(conf.CONF)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # initialize the logging system"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_f3be5dd3","line":76,"range":{"start_line":76,"start_character":4,"end_line":76,"end_character":52},"in_reply_to":"3fa0c359_1f62f5d8","updated":"2018-02-13 09:53:33.000000000","message":"Do you mean to indicate that something different is being done, or something else?","commit_id":"602b82a15fb37eb8bd2b2bee6e30b5f483b9a44a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7c80656f437bc9b4f35d9754226bb88b044edd32","unresolved":false,"context_lines":[{"line_number":52,"context_line":"def init_application():"},{"line_number":53,"context_line":"    # initialize the config system"},{"line_number":54,"context_line":"    conffile \u003d _get_config_file()"},{"line_number":55,"context_line":"    config.parse_args([], default_config_files\u003d[conffile],"},{"line_number":56,"context_line":"                      configure_db\u003dFalse, init_rpc\u003dFalse)"},{"line_number":57,"context_line":"    db_api.configure(conf.CONF)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # initialize the logging system"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_ca2558ad","side":"PARENT","line":56,"range":{"start_line":55,"start_character":57,"end_line":56,"end_character":56},"updated":"2018-02-15 19:26:48.000000000","message":"I think this patch needs to be merged into https://review.openstack.org/#/c/541435 because the patch changes here to specify configure_db\u003dFalse, init_rpc\u003dFalse.\n\nBut actually that doesn\u0027t avoid to import db and rpc modules, then this patch adds separated method(local _parse_args) to avoid calling config.parse_args(). So to reach the first purpose directly, the merger is necessary.","commit_id":"3a2546fd5e1273bfed55fea65556a7f0b3556f51"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"16128fe40272821988888f1f7cfca9ad9de2b917","unresolved":false,"context_lines":[{"line_number":52,"context_line":"def init_application():"},{"line_number":53,"context_line":"    # initialize the config system"},{"line_number":54,"context_line":"    conffile \u003d _get_config_file()"},{"line_number":55,"context_line":"    config.parse_args([], default_config_files\u003d[conffile],"},{"line_number":56,"context_line":"                      configure_db\u003dFalse, init_rpc\u003dFalse)"},{"line_number":57,"context_line":"    db_api.configure(conf.CONF)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    # initialize the logging system"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_e04ab381","side":"PARENT","line":56,"range":{"start_line":55,"start_character":57,"end_line":56,"end_character":56},"in_reply_to":"3fa0c359_ca2558ad","updated":"2018-02-15 21:59:58.000000000","message":"Yes, this was the result of a second discovery (in the blog work linked above). I agree that it could make more sense merged together, now that it\u0027s clear what\u0027s going on.\n\nHowever, I also considered that a small change like this one might be easier to merge (sooner) if it were done independently of any of its parents.\n\nTo answer that we need to have a bit of discussion about how much of the several different changes involved here might ever be merged. If it is all of it, then yes, agree, merging this with its parent would be cleaner.","commit_id":"3a2546fd5e1273bfed55fea65556a7f0b3556f51"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"7c80656f437bc9b4f35d9754226bb88b044edd32","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    return os.path.join(dirname, CONFIG_FILE)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def _parse_args(argv, default_config_files\u003dNone):"},{"line_number":62,"context_line":"    logging.register_options(conf.CONF)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    if profiler:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_c738f13e","line":61,"range":{"start_line":61,"start_character":42,"end_line":61,"end_character":47},"updated":"2018-02-15 19:26:48.000000000","message":"nit: logically this value never becomes None. Always specified.","commit_id":"3fac280dea9c3ceb948214c7d3ba6b1652e32520"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"16128fe40272821988888f1f7cfca9ad9de2b917","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    return os.path.join(dirname, CONFIG_FILE)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def _parse_args(argv, default_config_files\u003dNone):"},{"line_number":62,"context_line":"    logging.register_options(conf.CONF)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    if profiler:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_608783b8","line":61,"range":{"start_line":61,"start_character":42,"end_line":61,"end_character":47},"in_reply_to":"3fa0c359_c738f13e","updated":"2018-02-15 21:59:58.000000000","message":"Good catch. Much of the stuff in the whole stack of code is fairly thrown together, piecemeal, as part of the work in the series of blog postings ending https://anticdent.org/placement-container-playground-3.html\n\nI\u0027ve been hoping/assuming that people would come along and say what\u0027s actually possible to consider merging compared with stuff that may not be (for example the patch before this one has a -2 on it that\u0027s been there for about a year and a half.","commit_id":"3fac280dea9c3ceb948214c7d3ba6b1652e32520"}]}