)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e9b92e7a31d045a1e37e61efb60e646f4935aec","unresolved":false,"context_lines":[{"line_number":5110,"context_line":"                      \"old: %(old_cinfo)s\","},{"line_number":5111,"context_line":"                      {\u0027new_cinfo\u0027: new_cinfo, \u0027old_cinfo\u0027: old_cinfo},"},{"line_number":5112,"context_line":"                      instance\u003dinstance)"},{"line_number":5113,"context_line":"            self.driver.swap_volume(context, old_cinfo, new_cinfo, instance,"},{"line_number":5114,"context_line":"                                    mountpoint, resize_to)"},{"line_number":5115,"context_line":"            LOG.debug(\"swap_volume: Driver volume swap returned, new \""},{"line_number":5116,"context_line":"                      \"connection_info is now : %(new_cinfo)s\","}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_b7224d51","line":5113,"updated":"2018-04-11 17:08:16.000000000","message":"Yup: https://review.openstack.org/#/c/460243/16/nova/compute/manager.py","commit_id":"92630aee9e05c9b04f3a602a79c6c8431353303e"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"bffce3b037af479e47181298bb545dd689e0ca69","unresolved":false,"context_lines":[{"line_number":1952,"context_line":"        self.assertTrue(uuidutils.is_uuid_like(volume))"},{"line_number":1953,"context_line":"        return {}"},{"line_number":1954,"context_line":""},{"line_number":1955,"context_line":"    def _assert_swap_volume(self, context, old_connection_info,"},{"line_number":1956,"context_line":"                            new_connection_info, instance, mountpoint,"},{"line_number":1957,"context_line":"                            resize_to):"},{"line_number":1958,"context_line":"        self.assertEqual(2, resize_to)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_1a5d2a78","line":1955,"updated":"2018-02-23 10:42:33.000000000","message":"Was briefly confused as to why we\u0027re adding an argument here but not updating any callers. Answer is that it\u0027s used as a mock side-effect, so the call args are in non-test code.","commit_id":"77200eab3511339673933b762b2bffd1e0accb0c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e9b92e7a31d045a1e37e61efb60e646f4935aec","unresolved":false,"context_lines":[{"line_number":1955,"context_line":"        self.assertTrue(uuidutils.is_uuid_like(volume))"},{"line_number":1956,"context_line":"        return {}"},{"line_number":1957,"context_line":""},{"line_number":1958,"context_line":"    def _assert_swap_volume(self, context, old_connection_info,"},{"line_number":1959,"context_line":"                            new_connection_info, instance, mountpoint,"},{"line_number":1960,"context_line":"                            resize_to):"},{"line_number":1961,"context_line":"        self.assertEqual(2, resize_to)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_570c11a4","line":1958,"updated":"2018-04-11 17:08:16.000000000","message":"Yup: https://review.openstack.org/#/c/460243/16/nova/tests/unit/compute/test_compute_mgr.py","commit_id":"92630aee9e05c9b04f3a602a79c6c8431353303e"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e9b92e7a31d045a1e37e61efb60e646f4935aec","unresolved":false,"context_lines":[{"line_number":15199,"context_line":"        self._test_cleanup_encryption_process_execution_error(not_found\u003dFalse)"},{"line_number":15200,"context_line":""},{"line_number":15201,"context_line":"    @mock.patch.object(libvirt_driver.LibvirtDriver, \u0027_get_volume_encryption\u0027)"},{"line_number":15202,"context_line":"    def test_swap_volume_native_luks_blocked(self, mock_get_encryption):"},{"line_number":15203,"context_line":"        drvr \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI())"},{"line_number":15204,"context_line":"        mock_get_encryption.return_value \u003d {\u0027provider\u0027: \u0027luks\u0027}"},{"line_number":15205,"context_line":"        self.assertRaises(NotImplementedError, drvr.swap_volume, self.context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_da67e8e8","line":15202,"updated":"2018-04-11 17:08:16.000000000","message":"This doesn\u0027t include the other assertions from:\n\nhttps://review.openstack.org/#/c/544238/6/nova/tests/unit/virt/libvirt/test_driver.py\n\n-10!","commit_id":"92630aee9e05c9b04f3a602a79c6c8431353303e"}],"nova/tests/unit/virt/test_block_device.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e9b92e7a31d045a1e37e61efb60e646f4935aec","unresolved":false,"context_lines":[{"line_number":1127,"context_line":"        self.assertFalse(hasattr(test_swap, \u0027refresh_connection_info\u0027))"},{"line_number":1128,"context_line":""},{"line_number":1129,"context_line":""},{"line_number":1130,"context_line":"class TestGetVolumeId(test.NoDBTestCase):"},{"line_number":1131,"context_line":""},{"line_number":1132,"context_line":"    def test_get_volume_id_none_found(self):"},{"line_number":1133,"context_line":"        self.assertIsNone(driver_block_device.get_volume_id(None))"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_b756cd5b","line":1130,"updated":"2018-04-11 17:08:16.000000000","message":"Yup: https://review.openstack.org/#/c/539739/4/nova/tests/unit/virt/test_block_device.py","commit_id":"92630aee9e05c9b04f3a602a79c6c8431353303e"}],"nova/tests/unit/virt/test_virt_drivers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e9b92e7a31d045a1e37e61efb60e646f4935aec","unresolved":false,"context_lines":[{"line_number":492,"context_line":"                                          instance_ref,"},{"line_number":493,"context_line":"                                          \u0027/dev/sda\u0027))"},{"line_number":494,"context_line":"        self.assertIsNone("},{"line_number":495,"context_line":"            self.connection.swap_volume(None, {\u0027driver_volume_type\u0027: \u0027fake\u0027,"},{"line_number":496,"context_line":"                                         \u0027data\u0027: {}},"},{"line_number":497,"context_line":"                                        {\u0027driver_volume_type\u0027: \u0027fake\u0027,"},{"line_number":498,"context_line":"                                         \u0027data\u0027: {}},"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_1748d984","line":495,"updated":"2018-04-11 17:08:16.000000000","message":"Yup: https://review.openstack.org/#/c/460243/16/nova/tests/unit/virt/test_virt_drivers.py","commit_id":"92630aee9e05c9b04f3a602a79c6c8431353303e"}],"nova/virt/block_device.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e9b92e7a31d045a1e37e61efb60e646f4935aec","unresolved":false,"context_lines":[{"line_number":689,"context_line":"            and is_implemented(bdm))"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"def get_volume_id(connection_info):"},{"line_number":693,"context_line":"    if connection_info:"},{"line_number":694,"context_line":"        # Check for volume_id in \u0027data\u0027 and if not there, fallback to"},{"line_number":695,"context_line":"        # the \u0027serial\u0027 that the DriverVolumeBlockDevice adds during attach."}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_774595b3","line":692,"updated":"2018-04-11 17:08:16.000000000","message":"Yup: https://review.openstack.org/#/c/539739/4/nova/virt/block_device.py\n\nAnd we don\u0027t need https://review.openstack.org/#/c/539739/4/nova/virt/libvirt/volume/volume.py from that patch since we\u0027re not adding native luks encryptor support in this patch.","commit_id":"92630aee9e05c9b04f3a602a79c6c8431353303e"}],"nova/virt/driver.py":[{"author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"change_message_id":"6ee2f907b8c53e6f04635ff6b9dac4340ce1797d","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    def swap_volume(self, context, old_connection_info, new_connection_info,"},{"line_number":462,"context_line":"                    instance, mountpoint, resize_to):"},{"line_number":463,"context_line":"        \"\"\"Replace the volume attached to the given `instance`."},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        :param dict old_connection_info:"},{"line_number":466,"context_line":"            The volume for this connection gets detached from the given"},{"line_number":467,"context_line":"            `instance`."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_8eb7abf5","line":464,"updated":"2018-02-13 15:08:40.000000000","message":"you need to add the context param info here.","commit_id":"813685b691699b03e64f6fcd8d66069d16bc4142"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1c3c3594e6f221081bc7773e2a37abfce3c79133","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    def swap_volume(self, context, old_connection_info, new_connection_info,"},{"line_number":462,"context_line":"                    instance, mountpoint, resize_to):"},{"line_number":463,"context_line":"        \"\"\"Replace the volume attached to the given `instance`."},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        :param dict old_connection_info:"},{"line_number":466,"context_line":"            The volume for this connection gets detached from the given"},{"line_number":467,"context_line":"            `instance`."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_316cb6cc","line":464,"in_reply_to":"3fa0c359_0ede3bd9","updated":"2018-02-13 15:30:17.000000000","message":"Yup, this isn\u0027t a straight cherry-pick and I\u0027ve accidentally dropped this as a result, I\u0027ll include it in a respin.","commit_id":"813685b691699b03e64f6fcd8d66069d16bc4142"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dba7ed70891773facb7df0738982e849b69a3827","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    def swap_volume(self, context, old_connection_info, new_connection_info,"},{"line_number":462,"context_line":"                    instance, mountpoint, resize_to):"},{"line_number":463,"context_line":"        \"\"\"Replace the volume attached to the given `instance`."},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"        :param dict old_connection_info:"},{"line_number":466,"context_line":"            The volume for this connection gets detached from the given"},{"line_number":467,"context_line":"            `instance`."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_0ede3bd9","line":464,"in_reply_to":"3fa0c359_8eb7abf5","updated":"2018-02-13 15:22:49.000000000","message":"Yeah you have a point; this is a backport but it was part of the original change:\n\nhttps://review.openstack.org/#/c/460243/16/nova/virt/driver.py","commit_id":"813685b691699b03e64f6fcd8d66069d16bc4142"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e9b92e7a31d045a1e37e61efb60e646f4935aec","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        \"\"\"Detach the disk attached to the instance.\"\"\""},{"line_number":464,"context_line":"        raise NotImplementedError()"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    def swap_volume(self, context, old_connection_info, new_connection_info,"},{"line_number":467,"context_line":"                    instance, mountpoint, resize_to):"},{"line_number":468,"context_line":"        \"\"\"Replace the volume attached to the given `instance`."},{"line_number":469,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_f7d9a555","line":466,"updated":"2018-04-11 17:08:16.000000000","message":"Yup: https://review.openstack.org/#/c/460243/16/nova/virt/driver.py","commit_id":"92630aee9e05c9b04f3a602a79c6c8431353303e"}],"nova/virt/fake.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e9b92e7a31d045a1e37e61efb60e646f4935aec","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        except KeyError:"},{"line_number":309,"context_line":"            pass"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def swap_volume(self, context, old_connection_info, new_connection_info,"},{"line_number":312,"context_line":"                    instance, mountpoint, resize_to):"},{"line_number":313,"context_line":"        \"\"\"Replace the disk attached to the instance.\"\"\""},{"line_number":314,"context_line":"        instance_name \u003d instance.name"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_d7e4a10f","line":311,"updated":"2018-04-11 17:08:16.000000000","message":"Yup: https://review.openstack.org/#/c/460243/16/nova/virt/fake.py","commit_id":"92630aee9e05c9b04f3a602a79c6c8431353303e"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dba7ed70891773facb7df0738982e849b69a3827","unresolved":false,"context_lines":[{"line_number":1213,"context_line":"        \"\"\"Get the encryption metadata dict if it is not provided"},{"line_number":1214,"context_line":"        \"\"\""},{"line_number":1215,"context_line":"        encryption \u003d {}"},{"line_number":1216,"context_line":"        if connection_info.get(\u0027data\u0027, {}).get(\u0027volume_id\u0027):"},{"line_number":1217,"context_line":"            volume_id \u003d connection_info[\u0027data\u0027][\u0027volume_id\u0027]"},{"line_number":1218,"context_line":"            encryption \u003d encryptors.get_encryption_metadata(context,"},{"line_number":1219,"context_line":"                            self._volume_api, volume_id, connection_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_eea98f23","line":1216,"updated":"2018-02-13 15:22:49.000000000","message":"Without backporting cafe3d066ef7021c18961d4b239a10f61db23f2d as part of this change, you\u0027re introducing regression bug 1746609 to stable/pike, which isn\u0027t fun for anyone.","commit_id":"813685b691699b03e64f6fcd8d66069d16bc4142"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1c3c3594e6f221081bc7773e2a37abfce3c79133","unresolved":false,"context_lines":[{"line_number":1213,"context_line":"        \"\"\"Get the encryption metadata dict if it is not provided"},{"line_number":1214,"context_line":"        \"\"\""},{"line_number":1215,"context_line":"        encryption \u003d {}"},{"line_number":1216,"context_line":"        if connection_info.get(\u0027data\u0027, {}).get(\u0027volume_id\u0027):"},{"line_number":1217,"context_line":"            volume_id \u003d connection_info[\u0027data\u0027][\u0027volume_id\u0027]"},{"line_number":1218,"context_line":"            encryption \u003d encryptors.get_encryption_metadata(context,"},{"line_number":1219,"context_line":"                            self._volume_api, volume_id, connection_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_f11ace6c","line":1216,"in_reply_to":"3fa0c359_eea98f23","updated":"2018-02-13 15:30:17.000000000","message":"Gah, nice catch, I\u0027ll merge that fix into this change as well.","commit_id":"813685b691699b03e64f6fcd8d66069d16bc4142"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dba7ed70891773facb7df0738982e849b69a3827","unresolved":false,"context_lines":[{"line_number":1362,"context_line":"        # Given the size of the bugfix it was agreed not to backport the change"},{"line_number":1363,"context_line":"        # to earlier stable branches and to instead block swap volume attempts."},{"line_number":1364,"context_line":"        if self._get_volume_encryption(context, old_connection_info):"},{"line_number":1365,"context_line":"            raise NotImplementedError(_(\"Swap volume is not supported for\""},{"line_number":1366,"context_line":"                \"encrypted volumes until the Queens 17.0.0 release. For more\""},{"line_number":1367,"context_line":"                \"details see https://bugs.launchpad.net/nova/+bug/1739593.\"))"},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"        guest \u003d self._host.get_guest(instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_6e39ffef","line":1366,"range":{"start_line":1365,"start_character":41,"end_line":1366,"end_character":68},"updated":"2018-02-13 15:22:49.000000000","message":"This isn\u0027t totally true either, right? In Queens, swap volume of encrypted volumes is only supported if you\u0027re not using the native luks encryption workflow, so you\u0027d have to be using either (1) cryptsetup for the provider or (2) luks with older qemu/libvirt where native luks encryption isn\u0027t provided.","commit_id":"813685b691699b03e64f6fcd8d66069d16bc4142"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"1c3c3594e6f221081bc7773e2a37abfce3c79133","unresolved":false,"context_lines":[{"line_number":1362,"context_line":"        # Given the size of the bugfix it was agreed not to backport the change"},{"line_number":1363,"context_line":"        # to earlier stable branches and to instead block swap volume attempts."},{"line_number":1364,"context_line":"        if self._get_volume_encryption(context, old_connection_info):"},{"line_number":1365,"context_line":"            raise NotImplementedError(_(\"Swap volume is not supported for\""},{"line_number":1366,"context_line":"                \"encrypted volumes until the Queens 17.0.0 release. For more\""},{"line_number":1367,"context_line":"                \"details see https://bugs.launchpad.net/nova/+bug/1739593.\"))"},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"        guest \u003d self._host.get_guest(instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_112f3a88","line":1366,"range":{"start_line":1365,"start_character":41,"end_line":1366,"end_character":68},"in_reply_to":"3fa0c359_6e39ffef","updated":"2018-02-13 15:30:17.000000000","message":"Correct, I\u0027ll respin and make that clear.","commit_id":"813685b691699b03e64f6fcd8d66069d16bc4142"},{"author":{"_account_id":9963,"name":"Jiri Suchomel","email":"jiri.suchomel@suse.com","username":"jsuchome"},"change_message_id":"0123786763343ffde64d6425c2993b02b9a899fd","unresolved":false,"context_lines":[{"line_number":1363,"context_line":"        # to earlier stable branches and to instead block swap volume attempts."},{"line_number":1364,"context_line":"        if self._get_volume_encryption(context, old_connection_info) or \\"},{"line_number":1365,"context_line":"           self._get_volume_encryption(context, new_connection_info):"},{"line_number":1366,"context_line":"            raise NotImplementedError(_(\"Swap volume is not supported when\""},{"line_number":1367,"context_line":"                \"using encrypted volumes. For more details see \""},{"line_number":1368,"context_line":"                \"https://bugs.launchpad.net/nova/+bug/1739593.\"))"},{"line_number":1369,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_c0ffb0a8","line":1366,"updated":"2018-02-26 11:41:07.000000000","message":"Just a minor bit: there\u0027s a space missing after \"when\"","commit_id":"77200eab3511339673933b762b2bffd1e0accb0c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e9b92e7a31d045a1e37e61efb60e646f4935aec","unresolved":false,"context_lines":[{"line_number":1218,"context_line":"                                               connection_info\u003dconnection_info,"},{"line_number":1219,"context_line":"                                               **encryption)"},{"line_number":1220,"context_line":""},{"line_number":1221,"context_line":"    def _get_volume_encryption(self, context, connection_info):"},{"line_number":1222,"context_line":"        \"\"\"Get the encryption metadata dict if it is not provided"},{"line_number":1223,"context_line":"        \"\"\""},{"line_number":1224,"context_line":"        encryption \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_d72261b9","line":1221,"updated":"2018-04-11 17:08:16.000000000","message":"Matches https://review.openstack.org/#/c/460243/16/nova/virt/libvirt/driver.py@1224 except for https://review.openstack.org/#/c/539739/4/nova/virt/libvirt/driver.py@1277 which is correct.","commit_id":"92630aee9e05c9b04f3a602a79c6c8431353303e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e9b92e7a31d045a1e37e61efb60e646f4935aec","unresolved":false,"context_lines":[{"line_number":1363,"context_line":"        finally:"},{"line_number":1364,"context_line":"            self._host.write_instance_config(xml)"},{"line_number":1365,"context_line":""},{"line_number":1366,"context_line":"    def swap_volume(self, context, old_connection_info,"},{"line_number":1367,"context_line":"                    new_connection_info, instance, mountpoint, resize_to):"},{"line_number":1368,"context_line":""},{"line_number":1369,"context_line":"        # NOTE(lyarwood): Bug #1739593 uncovered a nasty data corruption"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_f7a765bb","line":1366,"range":{"start_line":1366,"start_character":26,"end_line":1366,"end_character":33},"updated":"2018-04-11 17:08:16.000000000","message":"Yup: https://review.openstack.org/#/c/460243/16/nova/virt/libvirt/driver.py@1394\n\nAnd we don\u0027t need the other changes to this method from that patch since we aren\u0027t attaching/detaching encryptors when we connect/disconnect volumes in this patch.","commit_id":"92630aee9e05c9b04f3a602a79c6c8431353303e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e9b92e7a31d045a1e37e61efb60e646f4935aec","unresolved":false,"context_lines":[{"line_number":1370,"context_line":"        # issue that was fixed in Queens by Ica323b87fa85a454fca9d46ada3677f18."},{"line_number":1371,"context_line":"        # Given the size of the bugfix it was agreed not to backport the change"},{"line_number":1372,"context_line":"        # to earlier stable branches and to instead block swap volume attempts."},{"line_number":1373,"context_line":"        if self._get_volume_encryption(context, old_connection_info) or \\"},{"line_number":1374,"context_line":"           self._get_volume_encryption(context, new_connection_info):"},{"line_number":1375,"context_line":"            raise NotImplementedError(_(\"Swap volume is not supported when \""},{"line_number":1376,"context_line":"                \"using encrypted volumes. For more details see \""},{"line_number":1377,"context_line":"                \"https://bugs.launchpad.net/nova/+bug/1739593.\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_3a7704a3","line":1374,"range":{"start_line":1373,"start_character":8,"end_line":1374,"end_character":69},"updated":"2018-04-11 17:08:16.000000000","message":"This is I258127fdcd011ccec721d5ff62eb7f128f130336 which is (1) not mentioned in the commit message and (2) is not yet in stable/queens, so that needs to be resolved first. -1 for that.","commit_id":"92630aee9e05c9b04f3a602a79c6c8431353303e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"262e467797c50af1b6bdc4e9f4e3d7a7a6cb7eaa","unresolved":false,"context_lines":[{"line_number":1370,"context_line":"        # issue that was fixed in Queens by Ica323b87fa85a454fca9d46ada3677f18."},{"line_number":1371,"context_line":"        # Given the size of the bugfix it was agreed not to backport the change"},{"line_number":1372,"context_line":"        # to earlier stable branches and to instead block swap volume attempts."},{"line_number":1373,"context_line":"        if (self._get_volume_encryption(context, old_connection_info) or"},{"line_number":1374,"context_line":"            self._get_volume_encryption(context, new_connection_info)):"},{"line_number":1375,"context_line":"            raise NotImplementedError(_(\"Swap volume is not supported when \""},{"line_number":1376,"context_line":"                \"using encrypted volumes. For more details see \""}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_16d0bb1e","line":1373,"updated":"2018-04-12 16:19:11.000000000","message":"nit: I kind of expected this to be:\n\n    old_encrypt \u003d self._get_volume_encryption(context, old_connection_info)\n    new_encrypt \u003d self._get_volume_encryption(context, new_connection_info)\n    if old_encrypt or new_encrypt:\n        raise NotImplementedError(_(\"Swap volume is not supported for \"","commit_id":"51b08c31245e28e2e3d67e9de953a04b2a957347"}],"releasenotes/notes/bug-1739593-cve-2017-18191-25fe48d336d8cf13.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"230c9bc41f686a4d63ff1b2013611245bbf594c9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    This release includes fixes for security vulnerabilities."},{"line_number":4,"context_line":"security:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    [CVE-2017-18191] Swapping encrypted volumes can lead to data loss and a possible compute host DOS attack."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    * `Bug 1739593 \u003chttps://bugs.launchpad.net/nova/+bug/1739593\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f6a8fd7_79fdf138","line":6,"updated":"2018-04-17 14:29:26.000000000","message":"Wrap at 79 characters please.","commit_id":"de86ee6fa74e3a0b522fa1b5328c59f18bfac7df"}]}