)]}'
{"nova/virt/ironic/patcher.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5e5d377273aedc323cd2a218c3b96ec7ad6587c5","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            # NOTE(mgoddard): Don\u0027t JSON encode the traits list - ironic"},{"line_number":119,"context_line":"            # expects instance_info.traits to be a list."},{"line_number":120,"context_line":"            patch.append({\u0027path\u0027: \u0027/instance_info/traits\u0027,"},{"line_number":121,"context_line":"                          \u0027op\u0027: \u0027add\u0027, \u0027value\u0027: traits})"},{"line_number":122,"context_line":"        return patch"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_cbc12556","line":121,"updated":"2018-02-13 14:33:38.000000000","message":"cra*ola, how did we miss that? :-(","commit_id":"54713a834f2a0e5b55b8f77c601ff35eb74b9b09"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3e418adfa3ba991e97221cb87a865183cdaff869","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            # NOTE(mgoddard): Don\u0027t JSON encode the traits list - ironic"},{"line_number":119,"context_line":"            # expects instance_info.traits to be a list."},{"line_number":120,"context_line":"            patch.append({\u0027path\u0027: \u0027/instance_info/traits\u0027,"},{"line_number":121,"context_line":"                          \u0027op\u0027: \u0027add\u0027, \u0027value\u0027: traits})"},{"line_number":122,"context_line":"        return patch"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_0bde2dd9","line":121,"in_reply_to":"3fa0c359_cbc12556","updated":"2018-02-13 14:46:57.000000000","message":"Because it\u0027s the same pattern as the capabilities line above.\n\nGiven that ironic supports either nested JSON or no nested JSON for capabilities [1], they should probably be unnested too. Possibly not worth it at this point if they are going away though.\n\n[1] https://github.com/openstack/ironic/blob/180277a65a5ad7f9cdc55d55aee08ef25ff92f8b/ironic/drivers/modules/deploy_utils.py#L572","commit_id":"54713a834f2a0e5b55b8f77c601ff35eb74b9b09"}]}