)]}'
{"nova/compute/rpcapi.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5acf72336dc17fe7a0593e7a9d5cfaf2463335a3","unresolved":false,"context_lines":[{"line_number":806,"context_line":"            return result"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":"    def prep_resize(self, ctxt, instance, image, instance_type, host,"},{"line_number":809,"context_line":"                    migration, request_spec\u003dNone,"},{"line_number":810,"context_line":"                    filter_properties\u003dNone, node\u003dNone,"},{"line_number":811,"context_line":"                    clean_shutdown\u003dTrue, host_list\u003dNone):"},{"line_number":812,"context_line":"        image_p \u003d jsonutils.to_primitive(image)"},{"line_number":813,"context_line":"        msg_args \u003d {\u0027instance\u0027: instance,"},{"line_number":814,"context_line":"                    \u0027instance_type\u0027: instance_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_5612fb59","side":"PARENT","line":811,"range":{"start_line":809,"start_character":39,"end_line":811,"end_character":55},"updated":"2018-02-20 16:10:29.000000000","message":"Why are you removing defaults from the kwargs? There are a few where you are doing this, and then a few methods where you don\u0027t, so it\u0027s a bit confusing.","commit_id":"c966524672cedba5c1bc40b76daf0b3745dc0c1d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"51f8eb525695178d3a1f95ac6dbd555c6b111d37","unresolved":false,"context_lines":[{"line_number":806,"context_line":"            return result"},{"line_number":807,"context_line":""},{"line_number":808,"context_line":"    def prep_resize(self, ctxt, instance, image, instance_type, host,"},{"line_number":809,"context_line":"                    migration, request_spec\u003dNone,"},{"line_number":810,"context_line":"                    filter_properties\u003dNone, node\u003dNone,"},{"line_number":811,"context_line":"                    clean_shutdown\u003dTrue, host_list\u003dNone):"},{"line_number":812,"context_line":"        image_p \u003d jsonutils.to_primitive(image)"},{"line_number":813,"context_line":"        msg_args \u003d {\u0027instance\u0027: instance,"},{"line_number":814,"context_line":"                    \u0027instance_type\u0027: instance_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_7678572a","side":"PARENT","line":811,"range":{"start_line":809,"start_character":39,"end_line":811,"end_character":55},"in_reply_to":"3fa0c359_5612fb59","updated":"2018-02-20 16:20:46.000000000","message":"(10:11:53 AM) dansmith: mriedem: because  those are things that were added as optional just for compatibility when adding a new param that really should be passed all the time","commit_id":"c966524672cedba5c1bc40b76daf0b3745dc0c1d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5acf72336dc17fe7a0593e7a9d5cfaf2463335a3","unresolved":false,"context_lines":[{"line_number":1262,"context_line":"        client \u003d self.router.client(ctxt)"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        if not client.can_send_version(version):"},{"line_number":1265,"context_line":"            raise exception.TriggerCrashDumpNotSupported()"},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"        cctxt \u003d client.prepare(server\u003d_compute_host(None, instance),"},{"line_number":1268,"context_line":"                version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_b6a7bf0b","side":"PARENT","line":1265,"range":{"start_line":1265,"start_character":28,"end_line":1265,"end_character":56},"updated":"2018-02-20 16:10:29.000000000","message":"There are quite a few exceptions we raise like this if the compute rpc api version can\u0027t be sent; we can likely remove the definitions for several of these in a follow up.","commit_id":"c966524672cedba5c1bc40b76daf0b3745dc0c1d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3c2ad8935cd995adf12fc9b86621629d7f6306a1","unresolved":false,"context_lines":[{"line_number":1262,"context_line":"        client \u003d self.router.client(ctxt)"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        if not client.can_send_version(version):"},{"line_number":1265,"context_line":"            raise exception.TriggerCrashDumpNotSupported()"},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"        cctxt \u003d client.prepare(server\u003d_compute_host(None, instance),"},{"line_number":1268,"context_line":"                version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_8f0b89d3","side":"PARENT","line":1265,"range":{"start_line":1265,"start_character":28,"end_line":1265,"end_character":56},"in_reply_to":"3fa0c359_2cb2834a","updated":"2018-02-20 17:20:01.000000000","message":"I was over-complicating this. We support the API supporting N and N-1 computes for rolling upgrades. This means the API in Rocky can support anything added before and in Queens, and expects things from at least Queens. So the API shouldn\u0027t expect to ever hit any of these old compat flows.","commit_id":"c966524672cedba5c1bc40b76daf0b3745dc0c1d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"73f32ad60da7e9572946bfab82bef30acbb3b99a","unresolved":false,"context_lines":[{"line_number":1262,"context_line":"        client \u003d self.router.client(ctxt)"},{"line_number":1263,"context_line":""},{"line_number":1264,"context_line":"        if not client.can_send_version(version):"},{"line_number":1265,"context_line":"            raise exception.TriggerCrashDumpNotSupported()"},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"        cctxt \u003d client.prepare(server\u003d_compute_host(None, instance),"},{"line_number":1268,"context_line":"                version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_2cb2834a","side":"PARENT","line":1265,"range":{"start_line":1265,"start_character":28,"end_line":1265,"end_character":56},"in_reply_to":"3fa0c359_b6a7bf0b","updated":"2018-02-20 16:39:14.000000000","message":"Or maybe we can\u0027t remove these just yet in case there are Queens computes still sending them?","commit_id":"c966524672cedba5c1bc40b76daf0b3745dc0c1d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"51f8eb525695178d3a1f95ac6dbd555c6b111d37","unresolved":false,"context_lines":[{"line_number":793,"context_line":"        cctxt.cast(ctxt, \u0027reset_network\u0027, instance\u003dinstance)"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"    def resize_instance(self, ctxt, instance, migration, image, instance_type,"},{"line_number":796,"context_line":"                        clean_shutdown\u003dTrue):"},{"line_number":797,"context_line":"        msg_args \u003d {\u0027instance\u0027: instance, \u0027migration\u0027: migration,"},{"line_number":798,"context_line":"                    \u0027image\u0027: image,"},{"line_number":799,"context_line":"                    \u0027instance_type\u0027: instance_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_f68c6736","line":796,"range":{"start_line":796,"start_character":24,"end_line":796,"end_character":43},"updated":"2018-02-20 16:20:46.000000000","message":"You removed the default for this parameter from prep_resize but not there. The ComputeManager._prep_resize defaults this to True anyway, so it\u0027s always going to default internal to the compute manager anyway, but just a subtle difference here in what I think is actually a default (optional) parameter.","commit_id":"a761e57368280b6d3e931831ecd393fd5787b3ef"}]}