)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"3ea198da8337d7efc8cdc507181e1d4baef19afb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Sync middleware audit, base, and notifier from oslo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Pull in middleware modules required to support CADF auditing"},{"line_number":10,"context_line":"reports from Nova."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id15f95a0c354270ba2d5aecb12c4f910905e8c20"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2Fvrs%3D","line":10,"updated":"2013-10-29 16:04:46.000000000","message":"It\u0027s comman practice to paste the commit id and patch title respectively in commit message here like this one https://review.openstack.org/#/c/52153/\n\nBesides is this syncing for a bug? or blueprint? if so we\u0027d better to reference that here as well, thanks.","commit_id":"cd4426c8e22eaf4d8ea5c4d539816d10433cbb72"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"0ca8dcc0a8cd055938b70cbe676342e7fb6bdc5d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Sync middleware audit, base, and notifier from oslo"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Pull in middleware modules required to support CADF auditing"},{"line_number":10,"context_line":"reports from Nova."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id15f95a0c354270ba2d5aecb12c4f910905e8c20"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2FvEg%3D","line":10,"in_reply_to":"AAAATn%2F%2Fvrs%3D","updated":"2013-10-29 18:20:32.000000000","message":"Done","commit_id":"cd4426c8e22eaf4d8ea5c4d539816d10433cbb72"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"356e311331c02144ce3fb6b068e1d7fea7f78903","unresolved":false,"context_lines":[{"line_number":14,"context_line":"I05ff58 Move wsgi module to deprecated package"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Id15f95a0c354270ba2d5aecb12c4f910905e8c20"},{"line_number":17,"context_line":"blueprint support-standard-audit-formats"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2BYx0%3D","line":17,"updated":"2013-11-26 16:28:20.000000000","message":"nit: follow best practice here https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"35f8c4b05ca4634afed615ca6fdae06823f67371"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7630979f28c2a3e375e04ce34661122c8c8156b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Pull in middleware modules required to support CADF auditing"},{"line_number":10,"context_line":"reports from Nova."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Iead243 Middleware: add notifier"},{"line_number":13,"context_line":"Ie67cf4 Add audit middleware"},{"line_number":14,"context_line":"I05ff58 Move wsgi module to deprecated package"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F93vk%3D","line":11,"updated":"2013-12-05 00:50:35.000000000","message":"Might be worth pointing out that audit requires notifier which requires base, that would probably help clarify my question about why we don\u0027t have correlation_id, debug and sizelimit in this sync.","commit_id":"3c841d70fcd064e46a30bff6c6eb59484efd3123"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"549500d8f107c0f8d03d366e09486dfb148a1ce4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Pull in middleware modules required to support CADF auditing"},{"line_number":10,"context_line":"reports from Nova."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Iead243 Middleware: add notifier"},{"line_number":13,"context_line":"Ie67cf4 Add audit middleware"},{"line_number":14,"context_line":"I05ff58 Move wsgi module to deprecated package"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F9y%2Bw%3D","line":11,"in_reply_to":"AAAATn%2F93vk%3D","updated":"2013-12-05 20:06:47.000000000","message":"Done","commit_id":"3c841d70fcd064e46a30bff6c6eb59484efd3123"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"68e97a475509698cf23debb43e5bc7b92328f675","unresolved":false,"context_lines":[{"line_number":10,"context_line":"reports from Nova."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Iead243 Middleware: add notifier"},{"line_number":13,"context_line":"Ie67cf4 Add audit middleware"},{"line_number":14,"context_line":"I05ff58 Move wsgi module to deprecated package"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"blueprint support-standard-audit-formats"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F93yo%3D","line":13,"updated":"2013-12-05 00:45:56.000000000","message":"Gerrit isn\u0027t able to find the patch by this change hash, is it correct?","commit_id":"3c841d70fcd064e46a30bff6c6eb59484efd3123"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"549500d8f107c0f8d03d366e09486dfb148a1ce4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"reports from Nova."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Iead243 Middleware: add notifier"},{"line_number":13,"context_line":"Ie67cf4 Add audit middleware"},{"line_number":14,"context_line":"I05ff58 Move wsgi module to deprecated package"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"blueprint support-standard-audit-formats"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F9y%2BE%3D","line":13,"in_reply_to":"AAAATn%2F93wY%3D","updated":"2013-12-05 20:06:47.000000000","message":"Yeah, some of the hashes aren\u0027t found, even with some longer hashes when a shorter has is found.  For example, I05ff58 works but not I05ff583e.","commit_id":"3c841d70fcd064e46a30bff6c6eb59484efd3123"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c7630979f28c2a3e375e04ce34661122c8c8156b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"reports from Nova."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Iead243 Middleware: add notifier"},{"line_number":13,"context_line":"Ie67cf4 Add audit middleware"},{"line_number":14,"context_line":"I05ff58 Move wsgi module to deprecated package"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"blueprint support-standard-audit-formats"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F93wY%3D","line":13,"in_reply_to":"AAAATn%2F93yo%3D","updated":"2013-12-05 00:50:35.000000000","message":"Ah, might be a conflict with another change, expanding the hash to Ie67cf4a works.","commit_id":"3c841d70fcd064e46a30bff6c6eb59484efd3123"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"68e97a475509698cf23debb43e5bc7b92328f675","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Iead243 Middleware: add notifier"},{"line_number":13,"context_line":"Ie67cf4 Add audit middleware"},{"line_number":14,"context_line":"I05ff58 Move wsgi module to deprecated package"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"blueprint support-standard-audit-formats"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F93xU%3D","line":14,"updated":"2013-12-05 00:45:56.000000000","message":"Seems that it\u0027s more I04b0cf - that\u0027s the latest version of base.py from oslo that\u0027s in here.","commit_id":"3c841d70fcd064e46a30bff6c6eb59484efd3123"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"549500d8f107c0f8d03d366e09486dfb148a1ce4","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Iead243 Middleware: add notifier"},{"line_number":13,"context_line":"Ie67cf4 Add audit middleware"},{"line_number":14,"context_line":"I05ff58 Move wsgi module to deprecated package"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"blueprint support-standard-audit-formats"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATn%2F9y%2BA%3D","line":14,"in_reply_to":"AAAATn%2F93xU%3D","updated":"2013-12-05 20:06:47.000000000","message":"I added that one to the list.","commit_id":"3c841d70fcd064e46a30bff6c6eb59484efd3123"}],"nova/openstack/common/middleware/notifier.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"68e97a475509698cf23debb43e5bc7b92328f675","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @webob.dec.wsgify"},{"line_number":113,"context_line":"    def __call__(self, req):"},{"line_number":114,"context_line":"        if req.method in self.ignore_req_list:"},{"line_number":115,"context_line":"            return req.get_response(self.application)"},{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            self.process_request(req)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F93zI%3D","line":114,"updated":"2013-12-05 00:45:56.000000000","message":"Looks like this is from change I840c43 which isn\u0027t in your commit message list.","commit_id":"3c841d70fcd064e46a30bff6c6eb59484efd3123"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"549500d8f107c0f8d03d366e09486dfb148a1ce4","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @webob.dec.wsgify"},{"line_number":113,"context_line":"    def __call__(self, req):"},{"line_number":114,"context_line":"        if req.method in self.ignore_req_list:"},{"line_number":115,"context_line":"            return req.get_response(self.application)"},{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            self.process_request(req)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9y9o%3D","line":114,"in_reply_to":"AAAATn%2F93zI%3D","updated":"2013-12-05 20:06:47.000000000","message":"I added that one to the list.","commit_id":"3c841d70fcd064e46a30bff6c6eb59484efd3123"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"68e97a475509698cf23debb43e5bc7b92328f675","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            try:"},{"line_number":119,"context_line":"                response \u003d req.get_response(self.application)"},{"line_number":120,"context_line":"            except Exception:"},{"line_number":121,"context_line":"                type, value, traceback \u003d sys.exc_info()"},{"line_number":122,"context_line":"                self.process_response(req, None, value, traceback)"},{"line_number":123,"context_line":"                raise"},{"line_number":124,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F93zE%3D","line":121,"updated":"2013-12-05 00:45:56.000000000","message":"Missing I519788, do we want it?","commit_id":"3c841d70fcd064e46a30bff6c6eb59484efd3123"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"549500d8f107c0f8d03d366e09486dfb148a1ce4","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            try:"},{"line_number":119,"context_line":"                response \u003d req.get_response(self.application)"},{"line_number":120,"context_line":"            except Exception:"},{"line_number":121,"context_line":"                type, value, traceback \u003d sys.exc_info()"},{"line_number":122,"context_line":"                self.process_response(req, None, value, traceback)"},{"line_number":123,"context_line":"                raise"},{"line_number":124,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9y9g%3D","line":121,"in_reply_to":"AAAATn%2F93zE%3D","updated":"2013-12-05 20:06:47.000000000","message":"I\u0027d prefer not to add that one at this point, since it\u0027s an extra thing to review if I add it.  And it\u0027s not required for the CADF functions to work.  If anyone has a strong opinion that it gets added, I can do that.\n\nThe reason it\u0027s not there now is that it was merged after I did the original sync in the code.","commit_id":"3c841d70fcd064e46a30bff6c6eb59484efd3123"}]}